Re: Review Request 68304: Fixed a bug in the agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207167 --- Patch looks great! Reviews applied: [68304] Passed command:

Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review207163 --- PASS: Mesos patch 67932 was successfully built and tested.

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

> On Aug. 7, 2018, 4:03 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/utils.cpp > > Line 102 (original), 105 (patched) > > > > > > Are we guaranteed that there are no short-lived processes, other than >

Re: Review Request 68304: Fixed a bug in the agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207168 --- src/slave/slave.cpp Line 1366 (original), 1383 (patched)

Re: Review Request 68304: Fixed a bug in the agent authentication retry logic.

> On Aug. 13, 2018, 2:03 p.m., Gastón Kleiman wrote: > > src/slave/slave.cpp > > Line 1366 (original), 1383 (patched) > > > > > > Should we multiply `maxBackoff` by `2` here? I don't see it being > > increased

Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Bugs: MESOS-9146

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68321/#review207170 --- Bad patch! Reviews applied: [68321, 68296] Failed command:

Re: Review Request 68305: Increased and added flag for the master's authentication timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68305/#review207176 --- src/master/flags.cpp Lines 237-243 (patched)

Re: Review Request 68304: Fixed a bug in the agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207172 --- Just a quick review since you're updating the logic. How about:

Re: Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68219/#review207185 --- Ship it!

Re: Review Request 68333: Made CNI isolator cleanup more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68333/#review207192 --- Ship it! Ship It! - Deepak Goel On Aug. 13, 2018, 10:59

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68222/#review207193 --- src/tests/containerizer/docker_volume_isolator_tests.cpp Lines

Re: Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

> On Aug. 14, 2018, 7:30 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/secret.cpp > > Lines 287 (patched) > > > > > > Why not the same order as previous patches? I guess it does not

Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/#review207196 --- Ship it! Ship It! - Deepak Goel On Aug. 13, 2018, 11 p.m.,

Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68327/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos

Review Request 68307: Added a test for master's handling of stale authentication requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/ --- Review request for mesos. Bugs: MESOS-9144

Review Request 68326: Introduced FUTURE_EXITED and DROP_EXITED in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68326/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos

Review Request 68306: Fixed an authentication request amplification issue in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68306/ --- Review request for mesos, Alexander Rojas, Gastón Kleiman, Meng Zhu, Till

Review Request 68325: Updated libprocess filtering to take the Process UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68325/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos

Review Request 68305: Increased and added flag for the master's authentication timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68305/ --- Review request for mesos, Alexander Rojas, Gastón Kleiman, Meng Zhu, Till

Review Request 68329: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68329/ --- Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu. Bugs:

Review Request 68331: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68331/ --- Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu. Bugs:

Re: Review Request 68334: Used state::checkpoint instead in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68334/ --- (Updated Aug. 13, 2018, 11:03 p.m.) Review request for mesos, Deepak Goel,

Re: Review Request 68216: Updated `volume/image` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68216/#review207180 --- src/slave/containerizer/mesos/isolators/volume/image.cpp Lines

Re: Review Request 68220: Updated the test `ROOT_SecretInVolumeWithRootFilesystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68220/#review207188 --- Ship it! Ship It! - Gilbert Song On Aug. 7, 2018, 7:23

Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68221/#review207189 ---

Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/#review207187 --- Ship it! LGTM - Sergey Urbanovich On Aug. 13, 2018, 11

Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/#review207203 --- PASS: Mesos patch 68335 was successfully built and tested.

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207178 --- src/slave/flags.cpp Lines 365-380 (patched)

Re: Review Request 68053: Call any function in a specified namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68053/#review207184 --- Ship it! Ship It! - Jie Yu On July 31, 2018, 5:30 p.m.,

Re: Review Request 68333: Made CNI isolator cleanup more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68333/#review207194 --- Ship it! Ship It! - Sergey Urbanovich On Aug. 13, 2018,

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207191 --- I hit this issue on my box ``` I0813 16:42:29.687569 31007

Re: Review Request 68329: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68329/#review207201 --- PASS: Mesos patch 68329 was successfully built and tested.

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/ --- (Updated Aug. 14, 2018, 2:14 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 68218: Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68218/#review207183 --- Ship it! Ship It! - Gilbert Song On Aug. 7, 2018, 7:22

Re: Review Request 68334: Used state::checkpoint instead in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68334/#review207206 --- Ship it! - Sergey Urbanovich On Aug. 13, 2018, 11:04

Re: Review Request 68334: Used state::checkpoint instead in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68334/ --- (Updated Aug. 13, 2018, 11:04 p.m.) Review request for mesos, Deepak Goel,

Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review207200 --- Patch looks great! Reviews applied: [67931, 67930, 67984, 67932]

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68307/#review207199 --- PASS: Mesos patch 68307 was successfully built and tested.

Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

> On Aug. 13, 2018, 12:15 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > > Line 373 (original), 373 (patched) > > > > > > Not yours, but could we remove this? I

Review Request 68333: Made CNI isolator cleanup more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68333/ --- Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.

Re: Review Request 68304: Fixed a bug in the agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 13, 2018, 2:53 p.m.) Review request for mesos, Benjamin Mahler

Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/ --- Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.

Review Request 68334: Used state::checkpoint intead in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68334/ --- Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207182 --- PASS: Mesos patch 68324 was successfully built and tested.

Re: Review Request 68331: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68331/#review207202 --- PASS: Mesos patch 68331 was successfully built and tested.

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/#review207208 --- Patch looks great! Reviews applied: [68304, 68324] Passed

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

> On Aug. 13, 2018, 4:14 p.m., Benjamin Mahler wrote: > > src/slave/flags.cpp > > Lines 365-380 (patched) > > > > > > Maybe we should start these with `authentication`? How about: > > > > ``` > >

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207207 --- PASS: Mesos patch 68054 was successfully built and tested.

Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68324/ --- (Updated Aug. 13, 2018, 10:37 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

> On Aug. 13, 2018, 4:06 p.m., Benjamin Mahler wrote: > > Just a quick review since you're updating the logic. > > > > How about: > > > > ``` > > Fixed a backoff overflow bug in agent authentication retry logic. > > ``` > > > > A little more in the commit description to clarify the old vs new

Re: Review Request 68304: Fixed a backoff overflow bug in agent authentication retry logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- (Updated Aug. 13, 2018, 10:33 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68054: Added networking statistics to cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207156 --- Patch looks great! Reviews applied: [68052, 68053, 68054]

Re: Review Request 68296: Add 'handler' field to batched state requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- (Updated Aug. 13, 2018, 1:45 p.m.) Review request for mesos, Alexander

Review Request 68321: Add '/state-summary' to batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68321/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68321/#review207155 --- FAIL: Failed to apply the dependent review: 68296. Failed