Re: Review Request 68426: Refactored some cgroups helpers to do verify from callers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68426/#review207619 --- Fix it, then Ship it! src/linux/cgroups.hpp Lines 80

Re: Review Request 68319: Put binaries into root folder in libprocess.

> On Aug. 20, 2018, 8:18 nachm., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? Thanks for engaging. The main idea would be

Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.

> On Aug. 17, 2018, 7:22 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['68420', '68422', '68375', '68297', '68374', '68301']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68362/#review207627 --- Ship it! Ship It! - Chun-Hung Hsiao On Aug. 15, 2018, 1:53

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Aug. 17, 2018, 10:29 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 7934 (patched) > > > > > > `OPERATION_GONE_BY_OPERATOR` is not a terminal state: > > > >

Re: Review Request 68319: Put binaries into root folder in libprocess.

> On Aug. 20, 2018, 11:18 a.m., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? > > Benjamin Bannier wrote: > Thanks for

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 17, 2018, 10:02 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 343 (patched) > > > > > > `flags.container_ports_protected_range` is already an interval

Re: Review Request 68343: Moved state serialization into separate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/ --- (Updated Aug. 20, 2018, 6:34 p.m.) Review request for mesos and Alexander

Re: Review Request 68429: Fixed paths to 3rdparty test executable under Windows.

> On Aug. 20, 2018, 5:54 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['68318', '68319', '68429']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 68396: Updated the ::pipe() system calls to pipe2 in posix subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68396/#review207629 --- 3rdparty/libprocess/src/posix/subprocess.cpp Line 66 (original),

Re: Review Request 68429: Fixed paths to 3rdparty test executable under Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68429/#review207620 --- Patch looks great! Reviews applied: [68318, 68319, 68429]

Re: Review Request 68319: Put binaries into root folder in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68319/#review207624 --- I have to ask: why? I've personally thought it would be nicer to

Re: Review Request 68331: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68331/#review207639 --- Ship it! Ship It! - Akash Gupta On Aug. 13, 2018, 10:35

Re: Review Request 68329: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68329/#review207640 --- Ship it! Ship It! - Akash Gupta On Aug. 20, 2018, 10:11

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 20, 2018, 9:53 p.m.) Review request for mesos and James Peach.

Re: Review Request 68329: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68329/ --- (Updated Aug. 20, 2018, 3:11 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 68319: Put binaries into root folder in libprocess.

> On Aug. 20, 2018, 8:18 p.m., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? > > Benjamin Bannier wrote: > Thanks for

Re: Review Request 68431: Made an operation reconciliation test more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68431/#review207633 --- Ship it! Ship It! - Greg Mann On Aug. 20, 2018, 9:09 p.m.,

Re: Review Request 68397: Updated the ::pipe() system calls to pipe2 in lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68397/ --- (Updated Aug. 20, 2018, 2:38 p.m.) Review request for mesos, Andrew

Re: Review Request 68319: Put binaries into root folder in libprocess.

> On Aug. 20, 2018, 11:18 a.m., Andrew Schwartzmeyer wrote: > > I have to ask: why? I've personally thought it would be nicer to remove > > this rather unexpected logic (from a CMake standpoint) from Mesos. Why add > > it to stout and libprocess? > > Benjamin Bannier wrote: > Thanks for

Re: Review Request 68397: Updated the ::pipe() system calls to pipe2 in lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68397/#review207637 --- FAIL: Failed to apply the dependent review: 63682. Failed

Re: Review Request 68431: Made an operation reconciliation test more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68431/#review207636 --- PASS: Mesos patch 68431 was successfully built and tested.

Re: Review Request 68398: Added `fs::used` helper API to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68398/#review207631 --- 3rdparty/stout/include/stout/windows/fs.hpp Lines 57 (patched)

Re: Review Request 68396: Updated the ::pipe() system calls to pipe2 in posix subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68396/ --- (Updated Aug. 20, 2018, 2:37 p.m.) Review request for mesos, Andrew

Re: Review Request 68329: Windows: Made `libwinio` the default option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68329/#review207643 --- PASS: Mesos patch 68329 was successfully built and tested.

Re: Review Request 68397: Updated the ::pipe() system calls to pipe2 in lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68397/#review207638 --- Ship it! Ship It! - Jie Yu On Aug. 20, 2018, 9:38 p.m.,

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207644 --- PASS: Mesos patch 68366 was successfully built and tested.

Review Request 68431: Made an operation reconciliation test more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68431/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8872

Re: Review Request 68431: Made an operation reconciliation test more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68431/#review207641 --- Patch looks great! Reviews applied: [68431] Passed command:

Re: Review Request 68426: Refactored some cgroups helpers to do verify from callers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68426/#review207600 --- PASS: Mesos patch 68426 was successfully built and tested.

Re: Review Request 68319: Put binaries into root folder in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68319/#review207610 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207611 --- PASS: Mesos patch 68145 was successfully built and tested.

Re: Review Request 68410: Made OPERATION_GONE_BY_OPERATOR a terminal operation status update.

> On Aug. 17, 2018, 11:38 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8040 (patched) > > > > > > According to `mesos.proto`, `OPERATION_GONE_BY_OPERATOR` is not > > terminal, similar to

Re: Review Request 68296: Added 'handler' field to batched requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/#review207606 --- Fix it, then Ship it! src/master/http.cpp Line 3031

Re: Review Request 68343: Moved state serialization into separate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207605 --- src/master/http.cpp Line 3031 (original), 3030 (patched)

Re: Review Request 68144: Added methods to remove resource providers from provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68144/ --- (Updated Aug. 20, 2018, 11:52 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68362: Made RP manager only send resource provider ID on state updates.

> On Aug. 18, 2018, 12:34 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 7684-7690 (original) > > > > > > Where do we update the operations and total resources? The `if` statement removed here was

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Aug. 18, 2018, 12:29 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 7934 (patched) > > > > > > `OPERATION_GONE_BY_OPERATOR` is not a terminal state: > > > >

Re: Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/ --- (Updated Aug. 20, 2018, 11:52 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68343: Moved state serialization into separate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207607 --- src/master/master.hpp Lines 1402-1403 (patched)

Review Request 68319: Put binaries into root folder in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68319/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/ --- (Updated Aug. 20, 2018, 11:52 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68321/#review207608 --- src/master/master.hpp Lines 1410-1425 (patched)

Re: Review Request 68426: Refactored some cgroups helpers to do verify from callers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68426/#review207602 --- Patch looks great! Reviews applied: [68426] Passed command:

Re: Review Request 68429: Fixed paths to 3rdparty test executable under Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68429/#review207612 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 68429: Fixed paths to 3rdparty test executable under Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68429/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Re: Review Request 68145: Sent an event to resource providers when they are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207615 --- Patch looks great! Reviews applied: [68407, 68143, 68144, 68146,

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

> On Aug. 17, 2018, 8:37 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/utils.cpp > > Line 53 (original), 53-56 (patched) > > > > > > Swap these two sentences, otherwise a reader might think that

Re: Review Request 68343: Moved state serialization into separate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/ --- (Updated Aug. 20, 2018, 2:08 p.m.) Review request for mesos and Alexander

Re: Review Request 68343: Moved state serialization into separate function.

> On Aug. 20, 2018, 9:43 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 3031 (original), 3030-3031 (patched) > > > > > > Is pass-by-value intentional? I think it is required by `async()`, but

Re: Review Request 68348: Fixed wrong `mnt` namespace detection for non-command executor tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68348/#review207618 --- PASS: Mesos patch 68348 was successfully built and tested.

Re: Review Request 68296: Added 'handler' field to batched requests.

> On Aug. 20, 2018, 9:51 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 3031 (original), 3035-3036 (patched) > > > > > > These will become `const &`. Huh, weird, this looks like another

Re: Review Request 68296: Added 'handler' field to batched requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- (Updated Aug. 20, 2018, 2:11 p.m.) Review request for mesos, Alexander

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

> On Aug. 17, 2018, 8:37 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/utils.cpp > > Lines 81-83 (patched) > > > > > > Let's unite `candidate` and `hasGrandchild` into `Option > > candidate;` >