Re: Review Request 68732: Cached weights in the sorters nodes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208779 --- src/master/allocator/sorter/drf/sorter.cpp Line 311 (original),

Re: Review Request 68401: Added persistent volume support to the `disk/xfs` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68401/#review208778 --- src/slave/containerizer/mesos/isolators/xfs/disk.hpp Lines 83

Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorters performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68731/#review208774 --- I am honestly surprised by the improvement this patch brings. Did

Review Request 68773: Added more logging to `DynamicReservationFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68773/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Bugs:

Re: Review Request 68773: Added more logging to `DynamicReservationFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68773/#review208780 --- PASS: Mesos patch 68773 was successfully built and tested.

Re: Review Request 68760: Added a `terminate` function to `ContainerDaemon`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68760/#review208765 --- src/slave/container_daemon.hpp Lines 72 (patched)

Re: Review Request 68761: Made the actors in resource providers managed by libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68761/#review208766 --- This seems to be a pretty dramatic change of the API of these

Re: Review Request 68763: WIP: Stopped resource providers when removing resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68763/#review208767 --- src/resource_provider/daemon.cpp Line 115 (original), 115

Review Request 68768: Fixed disconnection while sending acknowledgment to IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68768/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8545

Re: Review Request 68759: Cleaned up the `ContainerDaemon` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68759/ --- (Updated Sept. 20, 2018, 3:16 a.m.) Review request for mesos, Benjamin

Re: Review Request 68761: Made the actors in resource providers managed by libprocess.

> On Sept. 19, 2018, 3:16 p.m., Benjamin Bannier wrote: > > This seems to be a pretty dramatic change of the API of these classes. > > Could you explain when and how users can safely recreate e.g., a > > `StorageLocalResourceProvider` with identical config (e.g., identical > > `workDir`)?

Re: Review Request 68762: WIP: Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68762/ --- (Updated Sept. 20, 2018, 5:46 a.m.) Review request for mesos, Benjamin

Review Request 68778: Set master/agent flags in `StorageLocalResourceProviderTest` fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68778/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Repository: mesos

Review Request 68777: Set master/agent flags in `AgentResourceProviderConfigApiTest` fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68777/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-9228

Re: Review Request 68760: Added a `terminate` function to `ContainerDaemon`.

> On Sept. 19, 2018, 3:04 p.m., Benjamin Bannier wrote: > > src/slave/container_daemon.hpp > > Lines 72 (patched) > > > > > > Missing comma after `completed`? No there's no missing comma. Let me rephrase it to `The

Re: Review Request 68777: Set master/agent flags in `AgentResourceProviderConfigApiTest` fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68777/#review208785 --- PASS: Mesos patch 68777 was successfully built and tested.

Re: Review Request 68778: Set master/agent flags in `StorageLocalResourceProviderTest` fixture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68778/#review208786 --- PASS: Mesos patch 68778 was successfully built and tested.

Re: Review Request 68759: Cleaned up the `ContainerDaemon` implementation.

> On Sept. 19, 2018, 1:38 p.m., Benjamin Bannier wrote: > > src/slave/container_daemon.hpp > > Lines 86 (patched) > > > > > > Any reason we don't just use a `process::Promise` terminated here > > instead of sharing

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/ --- (Updated Sept. 20, 2018, 3:37 a.m.) Review request for mesos, Benjamin

Re: Review Request 68757: Removed `ROOT` requirements for `AgentResourceProviderConfigApiTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68757/#review208761 --- Ship it! Ship It! - Jan Schlicht On Sept. 19, 2018, 6:49

Re: Review Request 68757: Removed `ROOT` requirements for `AgentResourceProviderConfigApiTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68757/#review208760 --- Ship it! Ship It! - Benjamin Bannier On Sept. 19, 2018,

***UNCHECKED*** Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68756/#review208753 --- src/resource_provider/daemon.cpp Lines 463-464 (original),

Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68756/#review208759 --- src/resource_provider/local.hpp Lines 47 (patched)

Re: Review Request 68759: Cleaned up the `ContainerDaemon` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68759/#review208763 --- src/slave/container_daemon.hpp Lines 86 (patched)

***UNCHECKED*** Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/#review208762 --- src/tests/agent_resource_provider_config_api_tests.cpp Lines

Re: Review Request 68768: Fixed disconnection while sending acknowledgment to IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68768/#review208769 --- PASS: Mesos patch 68768 was successfully built and tested.

Re: Review Request 68732: Cached weights in the sorters nodes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68732/#review208768 --- src/master/allocator/sorter/drf/sorter.hpp Lines 249 (patched)

Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

> On Sept. 19, 2018, 12:41 p.m., Benjamin Bannier wrote: > > src/resource_provider/local.cpp > > Lines 38-40 (patched) > > > > > > These trigger warnings with clang, > > ``` > >

Review Request 68769: Fixed rtnl_act leak in routing::filter::internal::attach().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68769/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68756/ --- (Updated Sept. 19, 2018, 6:36 p.m.) Review request for mesos, Benjamin

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

> On Sept. 19, 2018, 1:12 p.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Lines 508-511 (patched) > > > > > > We don't seem to explicitly need this here. Is this

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/ --- (Updated Sept. 20, 2018, 2:53 a.m.) Review request for mesos, Benjamin

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/ --- (Updated Sept. 20, 2018, 3:45 a.m.) Review request for mesos, Benjamin

Re: Review Request 68760: Added a `terminate` function to `ContainerDaemon`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68760/ --- (Updated Sept. 20, 2018, 4:31 a.m.) Review request for mesos, Benjamin

Re: Review Request 68769: Fixed rtnl_act leak in routing::filter::internal::attach().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68769/#review208771 --- Ship it! Ship It! - Jie Yu On Sept. 19, 2018, 6:27 p.m.,

Re: Review Request 68769: Fixed rtnl_act leak in routing::filter::internal::attach().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68769/#review208772 --- PASS: Mesos patch 68769 was successfully built and tested.

Re: Review Request 68654: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/#review208752 --- PASS: Mesos patch 68654 was successfully built and tested.

Re: Review Request 68755: Removed unnecessary failure handling in agent HTTP API handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68755/#review208755 --- Ship it! Ship It! - Benjamin Bannier On Sept. 19, 2018,

Re: Review Request 68654: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/ --- (Updated Sept. 19, 2018, 7:05 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/#review208749 --- PASS: Mesos patch 68758 was successfully built and tested.

Re: Review Request 68654: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/ --- (Updated Sept. 19, 2018, 6:30 a.m.) Review request for mesos, Armand Grillet,

***UNCHECKED*** Re: Review Request 68763: WIP: Stopped resource providers when removing resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68763/#review208751 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68755: Removed unnecessary failure handling in agent HTTP API handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68755/#review208758 --- Ship it! Ship It! - Jan Schlicht On Sept. 19, 2018, 6:47