Re: Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`.

2018-10-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68970/#review209400 --- PASS: Mesos patch 68970 was successfully built and tested.

Re: Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`.

2018-10-10 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68970/#review209406 --- Ship it! Ship It! - Till Toenshoff On Oct. 10, 2018, 5:21

Re: Review Request 68971: Added pylint init-hook to add Mesos library to `PYTHONPATH`.

2018-10-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68971/#review209403 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 68976: Added `post()` function to new CLI for interacting with the HTTP API.

2018-10-10 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68976/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551

Review Request 68977: Added Record-IO encoder and decoder to new CLI.

2018-10-10 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551

Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`.

2018-10-10 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68978/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551

Re: Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`.

2018-10-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68978/#review209414 --- PASS: Mesos patch 68978 was successfully built and tested.

Re: Review Request 68706: Added master failover reregistration progress metrics.

2018-10-10 Thread Xudong Ni via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 10, 2018, 5:22 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 68971: Added pylint init-hook to add Mesos library to `PYTHONPATH`.

2018-10-10 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68971/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551

Re: Review Request 68955: Add per framework metrics in member function.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68955/ --- (Updated Oct. 10, 2018, 9:55 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68954: Fix tests related to allocator options refactor.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68954/ --- (Updated Oct. 10, 2018, 9:55 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68956: Add flag to toggle per framework metrics.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 10, 2018, 9:55 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68955: Add per framework metrics in member function.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68955/ --- (Updated Oct. 10, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 10, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68953: Refactor allocator configuration into class.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 10, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68956: Add flag to toggle per framework metrics.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 10, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68954: Fix tests related to allocator options refactor.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68954/ --- (Updated Oct. 10, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68953: Refactor allocator configuration into class.

2018-10-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/#review209421 --- include/mesos/allocator/allocator.hpp Lines 47 (patched)

Re: Review Request 68957: Add documentation for per-framework metrics flag.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 10, 2018, 9:55 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68953: Refactor allocator configuration into class.

2018-10-10 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 10, 2018, 9:55 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 68984: Changed a benign warning log message in slave.cpp to info.

2018-10-10 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68984/ --- Review request for mesos. Repository: mesos Description --- Currently,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

2018-10-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209423 --- PASS: Mesos patch 68957 was successfully built and tested.

[GitHub] asfgit closed pull request #311: BugFix backporting 1.4.x

2018-10-10 Thread GitBox
asfgit closed pull request #311: BugFix backporting 1.4.x URL: https://github.com/apache/mesos/pull/311 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

Re: Review Request 68984: Changed a benign warning log message in slave.cpp to info.

2018-10-10 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68984/ --- (Updated Oct. 10, 2018, 4:54 p.m.) Review request for mesos. Changes ---

[GitHub] asfgit closed pull request #312: BugFix backporting 1.5.x

2018-10-10 Thread GitBox
asfgit closed pull request #312: BugFix backporting 1.5.x URL: https://github.com/apache/mesos/pull/312 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] asfgit closed pull request #313: BugFix backporting 1.6.x

2018-10-10 Thread GitBox
asfgit closed pull request #313: BugFix backporting 1.6.x URL: https://github.com/apache/mesos/pull/313 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

Review Request 68986: Created cgroup recursively when calling prepare on containers.

2018-10-10 Thread fei long
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68986/ --- Review request for mesos and Jie Yu. Bugs: MESOS-9305

Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

2018-10-10 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68987/ --- Review request for mesos and Jie Yu. Bugs: MESOS-9308

Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

2018-10-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68987/#review209434 --- Ship it! Ship It! - Gilbert Song On Oct. 10, 2018, 10:18

Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

2018-10-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68987/#review209433 --- Ship it! Ship It! - Jie Yu On Oct. 11, 2018, 5:18 a.m.,

Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

2018-10-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68987/#review209435 --- Do we want a simple unit test? - Gilbert Song On Oct. 10,

Re: Review Request 68986: Created cgroup recursively when calling prepare on containers.

2018-10-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68986/#review209436 --- Ship it! Seems like we aim to backport this improvement to

Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

2018-10-10 Thread Chun-Hung Hsiao
> On Oct. 11, 2018, 5:19 a.m., Gilbert Song wrote: > > Do we want a simple unit test? I'll follow up with one tomorrow. - Chun-Hung --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 68984: Changed a benign warning log message in slave.cpp to info.

2018-10-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68984/#review209424 --- PASS: Mesos patch 68984 was successfully built and tested.

Re: Review Request 68706: Added master failover reregistration progress metrics.

2018-10-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review209425 --- Patch looks great! Reviews applied: [68706] Passed command: