Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68995/#review209495 --- Ship it! Ship It! - James Peach On Oct. 11, 2018, 2:12

Re: Review Request 68999: Fixed the XFS project ID labeling to not cross mount points.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68999/#review209496 --- src/slave/containerizer/mesos/isolators/xfs/utils.cpp Lines 370

Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68646/#review209494 --- Fix it, then Ship it!

Re: Review Request 68642: Added `lsof()` into stout.

> On Sept. 6, 2018, 5:37 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/lsof.hpp > > Lines 29 (patched) > > > > > > Why hashset rather than vector? By definition there aren't any > > duplicates,

Re: Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68644/#review209489 --- 3rdparty/libprocess/src/posix/subprocess.hpp Lines 213 (patched)

Re: Review Request 68645: Updated IO switchboard to use subprocess's `whitelist_fds` parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68645/#review209493 --- Ship it! Ship It! - James Peach On Sept. 6, 2018, 1:25

Re: Review Request 68991: Added a test `FsTest.Lsof`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/#review209492 --- Fix it, then Ship it!

Re: Review Request 68977: Added Record-IO encoder and decoder to new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/ --- (Updated oct. 12, 2018, 11:16 après-midi) Review request for mesos and Kevin

Re: Review Request 68995: Removed the child hook `UNSET_CLOEXEC`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68995/#review209505 --- Patch looks great! Reviews applied: [68642, 68991, 68643, 68644,

Review Request 69009: Added a sync option for `write` and POSIX `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs:

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209509 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 12, 2018,

Re: Review Request 68994: Logged request processing time for some endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68994/#review209506 --- Ship it! As we already discussed offline, it's a bit

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209512 --- src/slave/state.hpp Line 192 (original), 196 (patched)

Re: Review Request 68999: Fixed the XFS project ID labeling to not cross mount points.

> On Oct. 12, 2018, 5:55 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Lines 370 (patched) > > > > > > I'm planning to update this to: > > ``` > > CHECK_EQ(-1,

Re: Review Request 68977: Added Record-IO encoder and decoder to new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68977/#review209507 --- PASS: Mesos patch 68977 was successfully built and tested.

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/ --- (Updated Oct. 12, 2018, 11:53 p.m.) Review request for mesos, Andrew

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209508 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68999: Fixed the XFS project ID labeling to not cross mount points.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68999/#review209500 --- Ship it! +1 on the issue you raised yourself as well.

Re: Review Request 69003: Added `task exec` to new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/ --- (Updated oct. 12, 2018, 11:18 après-midi) Review request for mesos and Kevin

Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs:

Re: Review Request 68994: Logged request processing time for some endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68994/#review209511 --- Patch looks great! Reviews applied: [68992, 68993, 68994]

Re: Review Request 69003: WIP: Added `task exec` to new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/#review209478 --- PASS: Mesos patch 69003 was successfully built and tested.

Re: Review Request 68986: Created cgroup recursively when calling prepare on containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68986/#review209482 --- PASS: Mesos patch 68986 was successfully built and tested.

Re: Review Request 68986: Created cgroup recursively when calling prepare on containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68986/ --- (Updated Oct. 12, 2018, 9:30 a.m.) Review request for mesos and Jie Yu.