Re: Review Request 69575: Send operation feedback when agent was marked as gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69575/ --- (Updated Dec. 27, 2018, 4:47 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 69597: Remove outstanding operations when removing agents.

> On Dec. 20, 2018, 1:56 p.m., Benno Evers wrote: > > src/master/master.cpp > > Lines 8885 (patched) > > > > > > After some discussion with @bbannier, I moved the removal into > > `markGone()` since we were not

Re: Review Request 68018: Added `SeccompFilter` class.

> On Dec. 26, 2018, 7:40 a.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 73 (patched) > > > > > > Should `int arch` be `ContainerSeccompProfile::Architecture arch`? The return type of

Re: Review Request 69597: Remove outstanding operations when removing agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69597/ --- (Updated Dec. 27, 2018, 4:50 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 69575: Send operation feedback when agent was marked as gone.

> On Dec. 21, 2018, 4:34 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 4885 (patched) > > > > > > s/operationId.value()/operationId/ > > Benno Evers wrote: > Dropping this, as would result in a

Re: Review Request 69409: Added Seccomp parser tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/#review211561 --- src/tests/containerizer/linux_seccomp_parser_tests.cpp Lines

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Dec. 21, 2018, 9:23 a.m., Qian Zhang wrote: > > include/mesos/slave/containerizer.proto > > Lines 197 (patched) > > > > > > Can you please elaborate a bit why our internal json format is > > incompatible with

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/#review211541 --- Fix it, then Ship it!

Re: Review Request 68020: Added Seccomp-related flags to the agent.

> On Dec. 27, 2018, 3:44 p.m., Qian Zhang wrote: > > src/slave/flags.hpp > > Lines 192 (patched) > > > > > > Why not make this flag as optional too? If we make this flag as optional, then we do not need to use

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review211543 --- src/slave/containerizer/mesos/launch.cpp Lines 1196-1197

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/#review211538 --- docs/mesos-containerizer.md Lines 52 (patched)

Re: Review Request 68016: Added libseccomp to the build.

> On Dec. 25, 2018, 8:34 a.m., Qian Zhang wrote: > > cmake/CompilationConfigure.cmake > > Lines 449-452 (original), 449-452 (patched) > > > > > > Do we need to check the required headers/libs (like below) after