Re: Review Request 69723: Enabled operation feedback on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69723/#review212144 --- PASS: Mesos patch 69723 was successfully built and tested.

Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.

> On Jan. 14, 2019, 6:52 p.m., Joseph Wu wrote: > > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/ > > The patch is a bit old, but could be re-used if necessary. > > fei long wrote: > Since your patch has not been merged, I copied your code and passed the > test

Re: Review Request 69781: Fixed flakiness of resource provider ContainerTerminationMetric test.

> On Jan. 18, 2019, 4:22 a.m., Chun-Hung Hsiao wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3340 (patched) > > > > > > Could it be possible that the second `UpdateSlaveMessage` has been

Re: Review Request 69781: Fixed flakiness of resource provider ContainerTerminationMetric test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69781/ --- (Updated Jan. 18, 2019, 12:45 p.m.) Review request for mesos and Chun-Hung

Re: Review Request 69781: Fixed flakiness of resource provider ContainerTerminationMetric test.

> On Jan. 18, 2019, 4:42 a.m., Chun-Hung Hsiao wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3330 (patched) > > > > > > Is this really required? This one conservative approach to deal

Re: Review Request 69723: Enabled operation feedback on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69723/ --- (Updated Jan. 18, 2019, 1:45 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 69787: Added a proxy mode to the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69787/#review212136 --- src/examples/test_csi_plugin.cpp Lines 115 (patched)

Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.

> On Jan. 14, 2019, 7:52 p.m., Joseph Wu wrote: > > Here's a test I wrote for this issue: https://reviews.apache.org/r/65366/ > > The patch is a bit old, but could be re-used if necessary. > > fei long wrote: > Since your patch has not been merged, I copied your code and passed the > test

Re: Review Request 69781: Fixed flakiness of resource provider ContainerTerminationMetric test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69781/#review212142 --- PASS: Mesos patch 69781 was successfully built and tested.

Re: Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/#review212138 --- PASS: Mesos patch 69158 was successfully built and tested.

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212141 --- Patch looks great! Reviews applied: [69082] Passed command:

Re: Review Request 68018: Added `SeccompFilter` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/ --- (Updated Jan. 18, 2019, 8 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/#review212153 --- FAIL: Failed to apply the dependent review: 67844. Failed

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review212146 --- Fix it, then Ship it!

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

> On Jan. 15, 2019, 6:22 p.m., Benjamin Mahler wrote: > > Should we be surfacing a close EINTR as an error or let that be silent? > > I think these errors need some message pre-fixing? E.g. > > > > ``` > > Failed to close '3': Bad file number > > ``` > > > > As it stands the error messages

Re: Review Request 68019: Added a parser for the Docker Seccomp config format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68019/#review212164 --- src/linux/seccomp/seccomp_parser.cpp Lines 84-89 (patched)

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/#review212160 --- Fix it, then Ship it!

Re: Review Request 68020: Added Seccomp-related flags to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68020/#review212162 --- Ship it! src/slave/flags.cpp Lines 1397 (patched)

Review Request 69790: Fixed a typo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69790/ --- Review request for mesos, Benno Evers and Greg Mann. Repository: mesos

Review Request 69792: Added an ostream operator for `Operation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69792/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9356

Review Request 69793: Added the `ResourceState` agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69793/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9356

Review Request 69795: Made agent recover atomically checkpointed resources and operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69795/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9356

Review Request 69794: Made agent checkpoint operations affecting default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69794/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9356

Review Request 69791: Made it possible to checkpoint resources without downgrading them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69791/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9356

Re: Review Request 68018: Added `SeccompFilter` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/#review212159 --- Ship it! Ship It! - Gilbert Song On Jan. 18, 2019, noon,

Re: Review Request 69795: Made agent recover atomically checkpointed resources and operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69795/#review212161 --- PASS: Mesos patch 69795 was successfully built and tested.

Re: Review Request 68019: Added a parser for the Docker Seccomp config format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68019/#review212151 --- Fix it, then Ship it! src/linux/seccomp/seccomp_parser.cpp

Re: Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/ --- (Updated Jan. 18, 2019, 10:39 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211839 --- For consistency if we updated command excutor we should update