Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71639/#review218432 --- Patch looks great! Reviews applied: [71639] Passed command:

[GitHub] [mesos] ArmandGrillet commented on issue #345: Allow `mesos task exec/attach` for any task_id

ArmandGrillet commented on issue #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#issuecomment-547362391 @bmahler Please review, LGTM. This is an automated message from the

Re: Review Request 71646: Optimized tracking of cluster resource totals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71646/ --- (Updated Oct. 29, 2019, 2:56 p.m.) Review request for mesos, Benjamin Mahler

Review Request 71679: Added 'source' field to operator reservation API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71679/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9982

Review Request 71700: Updated offer operation resource validation for reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 71686: Added 'source' field to scheduler reservation API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71686/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9988

Review Request 71687: Rejected scheduler calls that include reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71687/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9983

Re: Review Request 71698: Optimized tracking of cluster resource totals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71698/#review218437 --- Bad review! Reviews applied: [71698] Error: 2019-10-29 17:46:22

Review Request 71688: Reject operator API calls that include reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71688/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71695/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9987 and MESOS-9989

Review Request 71690: Added function to compute a common reservation ancestor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71690/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9984

Review Request 71696: Updated validation of 'Reserve' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71696/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9985

Review Request 71699: Consolidated 'Master::authorizeReserveResources' overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71699/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9990

Review Request 71697: Optimized tracking of cluster resource totals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71697/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-10015

Review Request 71698: Optimized tracking of cluster resource totals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71698/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-10015

Re: Review Request 71697: Optimized tracking of cluster resource totals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71697/#review218435 --- Bad review! Reviews applied: [71697] Error: 2019-10-29 16:48:01

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

> On Oct. 28, 2019, 6:07 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 7848 (patched) > > > > > > Hm.. don't we enforce agent removal by not allowing the agent to > > re-register? > > > >

Re: Review Request 71700: Updated offer operation resource validation for reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218439 --- Bad patch! Reviews applied: [71679, 71686, 71699, 71687, 71688,

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218442 --- src/master/master.cpp Lines 7848 (patched)

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

> On Oct. 28, 2019, 6:07 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 7848 (patched) > > > > > > Hm.. don't we enforce agent removal by not allowing the agent to > > re-register? > > > >