Re: Review Request 39579: Updated docker registry client to check HTTP code.

2015-10-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39579/#review103791 --- Ship it! LGTM! Ship It! - Gilbert Song On Oct. 23, 2015, 12:58

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-21 Thread Gilbert Song
ingify(image)' as key. Thanks, Gilbert Song

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-21 Thread Gilbert Song
discarded. If yes, over write to the hashmap. 2. The current hashmap uses 'stringify(image::name)' as key, but it may not be unique because there is chance that layer_ids can be changed. One solution is to have 'stringify(image)' as key. Thanks, Gilbert Song

Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

2015-10-27 Thread Gilbert Song
+ clang-3.6) Thanks, Gilbert Song

Review Request 39712: Serialize Docker Registry Responses as Protobuf

2015-10-28 Thread Gilbert Song
://reviews.apache.org/r/39712/diff/ Testing (updated) --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

2015-10-28 Thread Gilbert Song
cf8aac383d6c6ec875b34af0460120ff521ce20e Diff: https://reviews.apache.org/r/39712/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

2015-10-28 Thread Gilbert Song
/ Testing --- make check (Ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-11-10 Thread Gilbert Song
87f145cd957dcb8fd3188c866212b417f0ab6296 docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 Diff: https://reviews.apache.org/r/39484/diff/ Testing --- Github gist Thanks, Gilbert Song

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-11 Thread Gilbert Song
re failed/discarded. If yes, over write to the hashmap. 2. The current hashmap uses 'stringify(image::name)' as key, but it may not be unique because there is chance that layer_ids can be changed. One solution is to have 'stringify(image)' as key. Thanks, Gilbert Song

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-11 Thread Gilbert Song
mean gtest would clean up when finished? - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review105773 --- On Nov.

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-11 Thread Gilbert Song
/abc/ef existed. We should want it true to create directory tree. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39331/#review105965 --------

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-09 Thread Gilbert Song
re failed/discarded. If yes, over write to the hashmap. 2. The current hashmap uses 'stringify(image::name)' as key, but it may not be unique because there is chance that layer_ids can be changed. One solution is to have 'stringify(image)' as key. Thanks, Gilbert Song

Re: Review Request 40211: Add mesos provisioner doc.

2015-11-11 Thread Gilbert Song
/master/docs/containerizer.md /g - Gilbert Song On Nov. 11, 2015, 4:29 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 40286: Fix registry puller to return correct rootfs path.

2015-11-13 Thread Gilbert Song
. - Gilbert Song On Nov. 13, 2015, 8:46 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-11-16 Thread Gilbert Song
/mesos_containerizer_tests.cpp d1ff139b0674ea266a4d554de112094045add509 Diff: https://reviews.apache.org/r/40372/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-11-16 Thread Gilbert Song
src/tests/containerizer/mesos_containerizer_tests.cpp d1ff139b0674ea266a4d554de112094045add509 Diff: https://reviews.apache.org/r/40372/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40199: Fix CMake build.

2015-11-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40199/#review106152 --- Ship it! Ship It! - Gilbert Song On Nov. 11, 2015, 1:09 p.m

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-11 Thread Gilbert Song
re failed/discarded. If yes, over write to the hashmap. 2. The current hashmap uses 'stringify(image::name)' as key, but it may not be unique because there is chance that layer_ids can be changed. One solution is to have 'stringify(image)' as key. Thanks, Gilbert Song

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

2015-11-11 Thread Gilbert Song
2efe64f7896beb97f14aa2754569bd8383a67ac7 Diff: https://reviews.apache.org/r/39712/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 39695: Relocate launcher and linux_launcher as MesosContainerizer specific

2015-11-11 Thread Gilbert Song
/ Testing --- make check (Ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-11-17 Thread Gilbert Song
src/tests/containerizer/mesos_containerizer_tests.cpp d1ff139b0674ea266a4d554de112094045add509 Diff: https://reviews.apache.org/r/40372/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-11-17 Thread Gilbert Song
re failed/discarded. If yes, over write to the hashmap. 2. The current hashmap uses 'stringify(image::name)' as key, but it may not be unique because there is chance that layer_ids can be changed. One solution is to have 'stringify(image)' as key. Thanks, Gilbert Song

Re: Review Request 40044: Remove unused parameter in moveLayers()

2015-11-09 Thread Gilbert Song
(Ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Review Request 40044: Remove unused parameter in moveLayers()

2015-11-06 Thread Gilbert Song
--- Remove unused parameter in moveLayers() Diffs - src/slave/containerizer/mesos/provisioner/docker/store.cpp bb02d650e16d45fcf337a7954f7a26143fb2c69f Diff: https://reviews.apache.org/r/40044/diff/ Testing --- make check (Ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 39868: Moved ProvisionerProcess to header for testing.

2015-11-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39868/#review104803 --- Ship it! LGTM. - Gilbert Song On Nov. 2, 2015, 11:04 a.m

Re: Review Request 40030: Fix for some style issues.

2015-11-06 Thread Gilbert Song
check(Ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40017: Add Docker Image type to Container Image for v1 API.

2015-11-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40017/#review105507 --- Ship it! Ship It! - Gilbert Song On Nov. 6, 2015, 4:16 a.m

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102709 --- Ship it! Ship It! - Gilbert Song On Oct. 14, 2015, 11:26 a.m

Review Request 39331: Support docker local store pull image simultaneously

2015-10-14 Thread Gilbert Song
, Gilbert Song

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review102839 --- Ship it! Ship It! - Gilbert Song On Oct. 15, 2015, 12:17 p.m

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-15 Thread Gilbert Song
. Thanks, Gilbert Song

Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-15 Thread Gilbert Song
in corresponding changes(fix conflicts during rebasing) in these patches on reviewboard if this post was merged. Please make a note below if you currently have patches working on MesosContainerizer and want this patch to be discarded and redo in the future. Thanks, Gilbert Song

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song
/diff/ Testing --- make check Thanks, Gilbert Song

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song
/diff/ Testing --- make check Thanks, Gilbert Song

Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song
, Gilbert Song

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song
/39451/diff/ Testing --- make check Thanks, Gilbert Song

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song
/diff/ Testing --- make check Thanks, Gilbert Song

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-20 Thread Gilbert Song
ingify(image)' as key. Thanks, Gilbert Song

Review Request 39484: Add resource usage section to MesosContainerizer and DockerContainerizer documentation

2015-10-20 Thread Gilbert Song
5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0 Diff: https://reviews.apache.org/r/39484/diff/ Testing --- Github gist Thanks, Gilbert Song

Re: Review Request 39331: Support docker local store pull image simultaneously

2015-10-20 Thread Gilbert Song
ingify(image)' as key. Thanks, Gilbert Song

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Gilbert Song
on reviewboard if this post was merged. Please make a note below if you currently have patches working on MesosContainerizer and want this patch to be discarded and redo in the future. Thanks, Gilbert Song

Re: Review Request 39494: Added libevent and ssl flags to config docs.

2015-10-20 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review103319 --- Ship it! Ship It! - Gilbert Song On Oct. 20, 2015, 2:58 p.m

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Gilbert Song
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/#review103157 --- On Oct. 20, 2015, 3 p.m., Gilbert Song wrote: > > --- > This is an automaticall

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

2015-10-20 Thread Gilbert Song
y, visit: https://reviews.apache.org/r/39360/#review103150 --- On Oct. 20, 2015, 3 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-12 Thread Gilbert Song
d Mazumdar wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 386 > > <https://reviews.apache.org/r/38919/diff/4/?file=1092077#file1092077line386> > > > > How about: > > > > // Test Manifest Validation with empty repeated 'fsLayers' field. > > > > Ditto for the following test-case. Nice

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-05 Thread Gilbert Song
-CREATION src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38901/diff/ Testing --- make check (ubuntu 14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-05 Thread Gilbert Song
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review101387 --- On Oct. 5, 2015, 12:14 p.m., Gilbert Song wrote: > > ---

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-05 Thread Gilbert Song
/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38901/diff/ Testing --- make check (ubuntu 14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-07 Thread Gilbert Song
/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38901/diff/ Testing --- make check (ubuntu 14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-12 Thread Gilbert Song
good point. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38901/#review102105 --- On Oct. 9, 2015,

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-06 Thread Gilbert Song
/docker/spec.cpp PRE-CREATION src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38919/diff/ Testing --- make check (Ubuntu14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38779: Use new HTTP status code check in scheduler.

2015-10-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/#review101685 --- Ship it! Ship It! - Gilbert Song On Oct. 6, 2015, 1:27 p.m

Re: Review Request 38814: add test cases for sha512 digest verifier

2015-10-06 Thread Gilbert Song
and Timothy Chen. Repository: mesos Description --- add test cases for sha512 digest verifier Diffs (updated) - 3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38814/diff/ Testing --- make check (ubuntu 14.04) Thanks, Gilbert

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-06 Thread Gilbert Song
/docker/spec.cpp PRE-CREATION src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38919/diff/ Testing --- make check (Ubuntu14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
/docker/spec.cpp PRE-CREATION src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38919/diff/ Testing --- make check (Ubuntu14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
/docker/spec.cpp PRE-CREATION src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38919/diff/ Testing --- make check (Ubuntu14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-09 Thread Gilbert Song
/docker/spec.cpp PRE-CREATION src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38919/diff/ Testing --- make check (Ubuntu14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-09 Thread Gilbert Song
/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38901/diff/ Testing --- make check (ubuntu 14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf

2015-11-17 Thread Gilbert Song
edfbb6fe932173dcbb15133e0eb685d86dd09c00 Diff: https://reviews.apache.org/r/39712/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-09-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review99319 --- Ship it! This improvement brings convenience. - Gilbert Song

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

2015-09-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review99296 --- Ship it! Ship It! - Gilbert Song On Sept. 10, 2015, 6:31 p.m

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-16 Thread Gilbert Song
9) <https://reviews.apache.org/r/38137/#comment155918> Comments of returned list scenario, with a given specified image. Of course, no need to do so if we decided to merge APPC and DOCKER provisioner together. - Gilbert Song On Sept. 11,

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-16 Thread Gilbert Song
be applied to appc provisioner. - Gilbert Song On Sept. 11, 2015, 7:42 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 38814: add test cases for sha512 digest verifier

2015-09-28 Thread Gilbert Song
Description --- add test cases for sha512 digest verifier Diffs - 3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38814/diff/ Testing --- make check (ubuntu 14.04) Thanks, Gilbert Song

Review Request 38816: make changes corresponding to the change in remote_puller.cpp

2015-09-28 Thread Gilbert Song
/ Testing --- make check (ubuntu 14.04) libevent and ssl enabled in configuration (e.g., '../configure --disable-java --disable-python --enable-libevent --enable-ssl --enable-debug') Thanks, Gilbert Song

Re: Review Request 38816: add test case for docker remotePuller

2015-09-28 Thread Gilbert Song
') Thanks, Gilbert Song

Re: Review Request 38747: Adding digest utilities

2015-09-28 Thread Gilbert Song
test case) 3rdparty/libprocess/include/process/digest.hpp (line 275) <https://reviews.apache.org/r/38747/#comment158090> This line is supposed to be deleted. - Gilbert Song On Sept. 25, 2015, 8:33 p.m., Joj

Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-09-30 Thread Gilbert Song
/ Testing --- make check (ubuntu 14.04 + clang++-3.6) Thanks, Gilbert Song

Review Request 38919: Validation of Docker Image Manifests

2015-10-01 Thread Gilbert Song
/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38919/diff/ Testing --- make check (Ubuntu14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38814: add test cases for sha512 digest verifier

2015-10-02 Thread Gilbert Song
and Timothy Chen. Repository: mesos Description --- add test cases for sha512 digest verifier Diffs (updated) - 3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38814/diff/ Testing --- make check (ubuntu 14.04) Thanks, Gilbert

Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.

2015-10-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101335 --- Ship it! Ship It! - Gilbert Song On Oct. 2, 2015, 9:51 a.m

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-02 Thread Gilbert Song
/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38901/diff/ Testing --- make check (ubuntu 14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38816: add test case for docker remotePuller

2015-10-02 Thread Gilbert Song
: https://reviews.apache.org/r/38816/diff/ Testing --- make check (ubuntu 14.04) libevent and ssl enabled in configuration (e.g., '../configure --disable-java --disable-python --enable-libevent --enable-ssl --enable-debug') Thanks, Gilbert Song

Re: Review Request 38919: Validation of Docker Image Manifests

2015-10-05 Thread Gilbert Song
/docker/spec.cpp PRE-CREATION src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38919/diff/ Testing --- make check (Ubuntu14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

2015-10-06 Thread Gilbert Song
/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c Diff: https://reviews.apache.org/r/38901/diff/ Testing --- make check (ubuntu 14.04 + clang++-3.6) Thanks, Gilbert Song

Re: Review Request 41011: Unified Container: Implemented interface for runtime configure to be returned from provisioner to mesos containerizer.

2015-12-08 Thread Gilbert Song
8a2c9bbf7e01a62ad92ba19216b32f6e813cd736 src/tests/containerizer/provisioner_appc_tests.cpp 9c5d91ba1fd49602418a0dd7c26b3132d3ac1a68 Diff: https://reviews.apache.org/r/41011/diff/ Testing --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

2015-12-02 Thread Gilbert Song
) --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

2015-12-02 Thread Gilbert Song
e49bc3ab0323ae1cf2cfb81c53f5ee0f57dd0b06 src/tests/containerizer/mesos_containerizer_tests.cpp fe679354d04d68b68e168cd8c4eab23898f6532f Diff: https://reviews.apache.org/r/40372/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer.

2015-12-02 Thread Gilbert Song
Diff: https://reviews.apache.org/r/40884/diff/ Testing --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40954: Fix comments in TaskHealthStatus message proto.

2015-12-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40954/#review108944 --- Ship it! Ship It! - Gilbert Song On Dec. 3, 2015, 9:44 p.m

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review108792 --- Ship it! Ship It! - Gilbert Song On Dec. 2, 2015, 10:28 p.m

Re: Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer.

2015-12-04 Thread Gilbert Song
/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e Diff: https://reviews.apache.org/r/40884/diff/ Testing --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 41119: Cleaned up DRF allocator tests.

2015-12-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41119/#review109468 --- Ship it! Ship It! - Gilbert Song On Dec. 8, 2015, 9:54 p.m

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-09 Thread Gilbert Song
://reviews.apache.org/r/40944/diff/ Testing --- make check(ubuntu14.04 + clang3.6) Thanks, Gilbert Song

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

2015-12-09 Thread Gilbert Song
33d6fb3e82ff7328ad093648a45546a18ec7b8cb src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a Diff: https://reviews.apache.org/r/40838/diff/ Testing --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer.

2015-12-09 Thread Gilbert Song
/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e Diff: https://reviews.apache.org/r/40884/diff/ Testing --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-04 Thread Gilbert Song
://reviews.apache.org/r/40944/diff/ Testing --- make check(ubuntu14.04 + clang3.6) Thanks, Gilbert Song

Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-03 Thread Gilbert Song
--- make check(ubuntu14.04 + clang3.6) Thanks, Gilbert Song

Review Request 40888: Add volume driver plugin to mesos v1 proto.

2015-12-02 Thread Gilbert Song
. Repository: mesos Description --- Add volume driver plugin to mesos v1 proto. Diffs - include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd Diff: https://reviews.apache.org/r/40888/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-03 Thread Gilbert Song
c63bf53fee40ef12536a16e11f4d5224c4e4278e Diff: https://reviews.apache.org/r/40944/diff/ Testing --- make check(ubuntu14.04 + clang3.6) Thanks, Gilbert Song

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-04 Thread Gilbert Song
://reviews.apache.org/r/40944/diff/ Testing --- make check(ubuntu14.04 + clang3.6) Thanks, Gilbert Song

Re: Review Request 41467: Added docs/mesos-provisioner.md to docs/home.md

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41467/#review110757 --- Ship it! Ship It! - Gilbert Song On Dec. 16, 2015, 1:27 p.m

Re: Review Request 41371: Fixed getting started instructions for centos 7.1.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41371/#review110796 --- Ship it! Ship It! - Gilbert Song On Dec. 16, 2015, 3:06 p.m

Re: Review Request 41372: Added update for systemd in centos Getting Started.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41372/#review110797 --- Ship it! Ship It! - Gilbert Song On Dec. 16, 2015, 3:07 p.m

Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

2015-12-16 Thread Gilbert Song
, because of different versions of ubuntu14.04. - Gilbert Song On Dec. 16, 2015, 3:06 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41011: Unified Container: Implemented interface for runtime configure to be returned from provisioner to mesos containerizer.

2015-12-16 Thread Gilbert Song
Diff: https://reviews.apache.org/r/41011/diff/ Testing --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Re: Review Request 41194: Unified Container: Cleanup uneccessary JSON parse in local puller.

2015-12-16 Thread Gilbert Song
/local_puller.cpp f8856664b39de0a07a3c3d7de8e03658acba9631 Diff: https://reviews.apache.org/r/41194/diff/ Testing --- make check(ubuntu14.04 + clang-3.6) Thanks, Gilbert Song

Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-16 Thread Gilbert Song
3f1717b770e139c3759aab0aeda9dbcf5029b0c2 Diff: https://reviews.apache.org/r/41487/diff/ Testing --- make check Thanks, Gilbert Song

Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-16 Thread Gilbert Song
/slave/containerizer/mesos/provisioner/store.hpp 8d1493856420dee3210af79b628c8c770c5c8550 src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 Diff: https://reviews.apache.org/r/41491/diff/ Testing --- make check Thanks, Gilbert Song

Review Request 41489: Provisioner: Implemented docker v1 parse serialization method in spec.

2015-12-16 Thread Gilbert Song
3f1717b770e139c3759aab0aeda9dbcf5029b0c2 Diff: https://reviews.apache.org/r/41489/diff/ Testing --- make check Thanks, Gilbert Song

  1   2   3   4   5   6   7   8   9   10   >