ingify(image)' as key.
Thanks,
Gilbert Song
discarded. If yes, over write to the hashmap.
2. The current hashmap uses 'stringify(image::name)' as key, but it may not be
unique because there is chance that layer_ids can be changed.
One solution is to have 'stringify(image)' as key.
Thanks,
Gilbert Song
+ clang-3.6)
Thanks,
Gilbert Song
://reviews.apache.org/r/39712/diff/
Testing (updated)
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
/
Testing
---
make check (Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
87f145cd957dcb8fd3188c866212b417f0ab6296
docs/docker-containerizer.md 5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0
Diff: https://reviews.apache.org/r/39484/diff/
Testing
---
Github gist
Thanks,
Gilbert Song
re failed/discarded. If yes, over write to the hashmap.
2. The current hashmap uses 'stringify(image::name)' as key, but it may not be
unique because there is chance that layer_ids can be changed.
One solution is to have 'stringify(image)' as key.
Thanks,
Gilbert Song
mean gtest would clean up when finished?
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/#review105773
---
On Nov.
/abc/ef existed.
We should want it true to create directory tree.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39331/#review105965
--------
re failed/discarded. If yes, over write to the hashmap.
2. The current hashmap uses 'stringify(image::name)' as key, but it may not be
unique because there is chance that layer_ids can be changed.
One solution is to have 'stringify(image)' as key.
Thanks,
Gilbert Song
/master/docs/containerizer.md /g
- Gilbert Song
On Nov. 11, 2015, 4:29 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
.
- Gilbert Song
On Nov. 13, 2015, 8:46 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/mesos_containerizer_tests.cpp
d1ff139b0674ea266a4d554de112094045add509
Diff: https://reviews.apache.org/r/40372/diff/
Testing
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
src/tests/containerizer/mesos_containerizer_tests.cpp
d1ff139b0674ea266a4d554de112094045add509
Diff: https://reviews.apache.org/r/40372/diff/
Testing
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106152
---
Ship it!
Ship It!
- Gilbert Song
On Nov. 11, 2015, 1:09 p.m
re failed/discarded. If yes, over write to the hashmap.
2. The current hashmap uses 'stringify(image::name)' as key, but it may not be
unique because there is chance that layer_ids can be changed.
One solution is to have 'stringify(image)' as key.
Thanks,
Gilbert Song
2efe64f7896beb97f14aa2754569bd8383a67ac7
Diff: https://reviews.apache.org/r/39712/diff/
Testing
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
/
Testing
---
make check (Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
src/tests/containerizer/mesos_containerizer_tests.cpp
d1ff139b0674ea266a4d554de112094045add509
Diff: https://reviews.apache.org/r/40372/diff/
Testing
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
re failed/discarded. If yes, over write to the hashmap.
2. The current hashmap uses 'stringify(image::name)' as key, but it may not be
unique because there is chance that layer_ids can be changed.
One solution is to have 'stringify(image)' as key.
Thanks,
Gilbert Song
(Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
---
Remove unused parameter in moveLayers()
Diffs
-
src/slave/containerizer/mesos/provisioner/docker/store.cpp
bb02d650e16d45fcf337a7954f7a26143fb2c69f
Diff: https://reviews.apache.org/r/40044/diff/
Testing
---
make check (Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39868/#review104803
---
Ship it!
LGTM.
- Gilbert Song
On Nov. 2, 2015, 11:04 a.m
check(Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40017/#review105507
---
Ship it!
Ship It!
- Gilbert Song
On Nov. 6, 2015, 4:16 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102709
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 14, 2015, 11:26 a.m
,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39353/#review102839
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 15, 2015, 12:17 p.m
.
Thanks,
Gilbert Song
in corresponding changes(fix conflicts during
rebasing) in these patches on reviewboard if this post was merged. Please make
a note below if you currently have patches working on MesosContainerizer and
want this patch to be discarded and redo in the future.
Thanks,
Gilbert Song
/diff/
Testing
---
make check
Thanks,
Gilbert Song
/diff/
Testing
---
make check
Thanks,
Gilbert Song
,
Gilbert Song
/39451/diff/
Testing
---
make check
Thanks,
Gilbert Song
/diff/
Testing
---
make check
Thanks,
Gilbert Song
5f8a1a9242bb795b56ac8274b9cf9a7324cbddb0
Diff: https://reviews.apache.org/r/39484/diff/
Testing
---
Github gist
Thanks,
Gilbert Song
ingify(image)' as key.
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39494/#review103319
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 20, 2015, 2:58 p.m
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39360/#review103157
---
On Oct. 20, 2015, 3 p.m., Gilbert Song wrote:
>
> ---
> This is an automaticall
y, visit:
https://reviews.apache.org/r/39360/#review103150
---
On Oct. 20, 2015, 3 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
d Mazumdar wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 386
> > <https://reviews.apache.org/r/38919/diff/4/?file=1092077#file1092077line386>
> >
> > How about:
> >
> > // Test Manifest Validation with empty repeated 'fsLayers' field.
> >
> > Ditto for the following test-case.
Nice
-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38901/diff/
Testing
---
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101387
---
On Oct. 5, 2015, 12:14 p.m., Gilbert Song wrote:
>
> ---
/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38901/diff/
Testing
---
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
good point.
- Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review102105
---
On Oct. 9, 2015,
/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38919/diff/
Testing
---
make check (Ubuntu14.04 + clang++-3.6)
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38779/#review101685
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 6, 2015, 1:27 p.m
/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38919/diff/
Testing
---
make check (Ubuntu14.04 + clang++-3.6)
Thanks,
Gilbert Song
/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38919/diff/
Testing
---
make check (Ubuntu14.04 + clang++-3.6)
Thanks,
Gilbert Song
/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38919/diff/
Testing
---
make check (Ubuntu14.04 + clang++-3.6)
Thanks,
Gilbert Song
/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38919/diff/
Testing
---
make check (Ubuntu14.04 + clang++-3.6)
Thanks,
Gilbert Song
/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38901/diff/
Testing
---
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
edfbb6fe932173dcbb15133e0eb685d86dd09c00
Diff: https://reviews.apache.org/r/39712/diff/
Testing
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/#review99319
---
Ship it!
This improvement brings convenience.
- Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37826/#review99296
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 10, 2015, 6:31 p.m
be applied to appc provisioner.
- Gilbert Song
On Sept. 11, 2015, 7:42 a.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
Description
---
add test cases for sha512 digest verifier
Diffs
-
3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/38814/diff/
Testing
---
make check (ubuntu 14.04)
Thanks,
Gilbert Song
/
Testing
---
make check (ubuntu 14.04)
libevent and ssl enabled in configuration (e.g., '../configure --disable-java
--disable-python --enable-libevent --enable-ssl --enable-debug')
Thanks,
Gilbert Song
')
Thanks,
Gilbert Song
test case)
3rdparty/libprocess/include/process/digest.hpp (line 275)
<https://reviews.apache.org/r/38747/#comment158090>
This line is supposed to be deleted.
- Gilbert Song
On Sept. 25, 2015, 8:33 p.m., Joj
/
Testing
---
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38919/diff/
Testing
---
make check (Ubuntu14.04 + clang++-3.6)
Thanks,
Gilbert Song
and Timothy Chen.
Repository: mesos
Description
---
add test cases for sha512 digest verifier
Diffs (updated)
-
3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/38814/diff/
Testing
---
make check (ubuntu 14.04)
Thanks,
Gilbert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38960/#review101335
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 2, 2015, 9:51 a.m
/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38901/diff/
Testing
---
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
: https://reviews.apache.org/r/38816/diff/
Testing
---
make check (ubuntu 14.04)
libevent and ssl enabled in configuration (e.g., '../configure --disable-java
--disable-python --enable-libevent --enable-ssl --enable-debug')
Thanks,
Gilbert Song
/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38919/diff/
Testing
---
make check (Ubuntu14.04 + clang++-3.6)
Thanks,
Gilbert Song
/provisioner_docker_tests.cpp
d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38901/diff/
Testing
---
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
)
---
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
e49bc3ab0323ae1cf2cfb81c53f5ee0f57dd0b06
src/tests/containerizer/mesos_containerizer_tests.cpp
fe679354d04d68b68e168cd8c4eab23898f6532f
Diff: https://reviews.apache.org/r/40372/diff/
Testing
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Diff: https://reviews.apache.org/r/40884/diff/
Testing
---
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40954/#review108944
---
Ship it!
Ship It!
- Gilbert Song
On Dec. 3, 2015, 9:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40435/#review108792
---
Ship it!
Ship It!
- Gilbert Song
On Dec. 2, 2015, 10:28 p.m
/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
Diff: https://reviews.apache.org/r/40884/diff/
Testing
---
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41119/#review109468
---
Ship it!
Ship It!
- Gilbert Song
On Dec. 8, 2015, 9:54 p.m
://reviews.apache.org/r/40944/diff/
Testing
---
make check(ubuntu14.04 + clang3.6)
Thanks,
Gilbert Song
33d6fb3e82ff7328ad093648a45546a18ec7b8cb
src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a
Diff: https://reviews.apache.org/r/40838/diff/
Testing
---
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e
Diff: https://reviews.apache.org/r/40884/diff/
Testing
---
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
://reviews.apache.org/r/40944/diff/
Testing
---
make check(ubuntu14.04 + clang3.6)
Thanks,
Gilbert Song
---
make check(ubuntu14.04 + clang3.6)
Thanks,
Gilbert Song
.
Repository: mesos
Description
---
Add volume driver plugin to mesos v1 proto.
Diffs
-
include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
Diff: https://reviews.apache.org/r/40888/diff/
Testing
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
c63bf53fee40ef12536a16e11f4d5224c4e4278e
Diff: https://reviews.apache.org/r/40944/diff/
Testing
---
make check(ubuntu14.04 + clang3.6)
Thanks,
Gilbert Song
://reviews.apache.org/r/40944/diff/
Testing
---
make check(ubuntu14.04 + clang3.6)
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41467/#review110757
---
Ship it!
Ship It!
- Gilbert Song
On Dec. 16, 2015, 1:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41371/#review110796
---
Ship it!
Ship It!
- Gilbert Song
On Dec. 16, 2015, 3:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41372/#review110797
---
Ship it!
Ship It!
- Gilbert Song
On Dec. 16, 2015, 3:07 p.m
, because of different
versions of ubuntu14.04.
- Gilbert Song
On Dec. 16, 2015, 3:06 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
Diff: https://reviews.apache.org/r/41011/diff/
Testing
---
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
/local_puller.cpp
f8856664b39de0a07a3c3d7de8e03658acba9631
Diff: https://reviews.apache.org/r/41194/diff/
Testing
---
make check(ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41487/diff/
Testing
---
make check
Thanks,
Gilbert Song
/slave/containerizer/mesos/provisioner/store.hpp
8d1493856420dee3210af79b628c8c770c5c8550
src/tests/containerizer/provisioner_docker_tests.cpp
3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41491/diff/
Testing
---
make check
Thanks,
Gilbert Song
3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41489/diff/
Testing
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/41490/diff/
Testing
---
make check
Thanks,
Gilbert Song
/41407/diff/
Testing
---
make check
Thanks,
Gilbert Song
/docker/paths.hpp
7e5122d956c82e6cbd62fc217158205ea05f4290
src/slave/containerizer/mesos/provisioner/docker/paths.cpp
9c1f6a19c59b12f58b0550d022f9128e7015a4e9
Diff: https://reviews.apache.org/r/41406/diff/
Testing
---
make check
Thanks,
Gilbert Song
://reviews.apache.org/r/41488/diff/
Testing
---
make check
Thanks,
Gilbert Song
ed e-mail. To reply, visit:
https://reviews.apache.org/r/41406/#review110901
---
On Dec. 16, 2015, 6:38 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To
is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41407/#review110705
---
On Dec. 16, 2015, 6:38 p.m., Gilbert Song wrote:
>
> ---
> This
/containerizer/store.hpp 0d2879602f01e3dfcc20d7f2272ea01e47729574
Diff: https://reviews.apache.org/r/41125/diff/
Testing
---
make check (ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
/provisioner_docker_tests.cpp
3f1717b770e139c3759aab0aeda9dbcf5029b0c2
Diff: https://reviews.apache.org/r/41487/diff/
Testing
---
make check
Thanks,
Gilbert Song
1 - 100 of 2187 matches
Mail list logo