bluezd opened a new pull request #353: hook manager mutex and global variable
enhancement
URL: https://github.com/apache/mesos/pull/353
This patch aims to fix issue [MESOS-9337]
1. add missing mutex acquisition for the potential race
2. change the global mutex and map variable to
kamaradclimber opened a new pull request #354: Avoid error on mesos logs upon
docker image fetch
URL: https://github.com/apache/mesos/pull/354
When fetching docker image, fetcher test curl support for --http1.1
flag.
This patch makes sure we properly capture stderr to avoid displaying
bmahler commented on a change in pull request #353: hook manager mutex and
global variable enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r396652595
##
File path: src/hook/manager.cpp
##
@@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
namesp
bmahler commented on a change in pull request #353: hook manager mutex and
global variable enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r396651964
##
File path: src/hook/manager.cpp
##
@@ -240,18 +242,20 @@ Future
// `DockerTaskExecutorPrepareInf
bluezd commented on issue #353: hook manager mutex and global variable
enhancement
URL: https://github.com/apache/mesos/pull/353#issuecomment-602944778
@bmahler Thanks for your info, I will update the patch on my own and submit
later.
--
bluezd commented on a change in pull request #353: hook manager mutex and
global variable enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r396867675
##
File path: src/hook/manager.cpp
##
@@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
namespa
bluezd commented on a change in pull request #353: hook manager mutex and
global variable enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r396867472
##
File path: src/hook/manager.cpp
##
@@ -240,18 +242,20 @@ Future
// `DockerTaskExecutorPrepareInfo
bluezd commented on issue #353: hook manager mutex and global variable
enhancement
URL: https://github.com/apache/mesos/pull/353#issuecomment-602971351
@bmahler I have re-submitted the changes. Could you please review it again ?
-
bmahler commented on issue #353: hook manager mutex and global variable
enhancement
URL: https://github.com/apache/mesos/pull/353#issuecomment-603473389
@asekretenko these are good questions to be asking, as I also felt this
looked a bit strange. I suspect it's just modeled in the same way
bmahler commented on a change in pull request #353: hook manager mutex and
global variable enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r397425354
##
File path: src/hook/manager.cpp
##
@@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
namesp
bmahler commented on a change in pull request #353: hook manager mutex and
global variable enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r397426753
##
File path: src/hook/manager.cpp
##
@@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
namesp
bmahler commented on issue #354: Avoid error on mesos logs upon docker image
fetch
URL: https://github.com/apache/mesos/pull/354#issuecomment-603477873
Thanks @kamaradclimber, we chatted a bit in slack about this since it looked
a bit surprising to me:
https://mesos.slack.com/archiv
bluezd commented on a change in pull request #353: hook manager mutex and
global variable enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r397585853
##
File path: src/hook/manager.cpp
##
@@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
namespa
bluezd commented on a change in pull request #353: Hook manager mutex and
global variable enhancement.
URL: https://github.com/apache/mesos/pull/353#discussion_r397585853
##
File path: src/hook/manager.cpp
##
@@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
namesp
bluezd commented on a change in pull request #353: Hook manager mutex and
global variable enhancement.
URL: https://github.com/apache/mesos/pull/353#discussion_r397585853
##
File path: src/hook/manager.cpp
##
@@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
namesp
asfgit closed pull request #354: Avoid error on mesos logs upon docker image
fetch
URL: https://github.com/apache/mesos/pull/354
This is an automated message from the Apache Git Service.
To respond to the message, please log
bmahler closed pull request #353: Hook manager mutex and global variable
enhancement.
URL: https://github.com/apache/mesos/pull/353
This is an automated message from the Apache Git Service.
To respond to the message, please
cf-natali opened a new pull request #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355
It's a workaround for kernel bugs
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/kernel/cgroup/cgroup.c?id=9c974c77246460fa6a92c18554c
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r401684158
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string& cg
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r401705020
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string&
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r402256087
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string& cg
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r402382128
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string&
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r404414704
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string&
cf-natali opened a new pull request #356: libprocess: check protobuf
(de)serialisation success.
URL: https://github.com/apache/mesos/pull/356
Before the code didn't check at all the return value of
`Message::SerializeToString`, which can fail for various reasons,
e.g. out-of-memory, m
bmahler commented on issue #356: libprocess: check protobuf (de)serialisation
success.
URL: https://github.com/apache/mesos/pull/356#issuecomment-610138094
Thanks for reporting this Charles! I will take a closer look soon to confirm
the error handling in this patch is correct and complete.
cf-natali commented on issue #356: libprocess: check protobuf (de)serialisation
success.
URL: https://github.com/apache/mesos/pull/356#issuecomment-610241483
> Can you extract the contributors.yaml change from this PR? We enforce that
commits in the project do not mix unrelated changes.
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r404835680
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string& cg
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r404838566
##
File path: docs/contributors.yaml
##
@@ -231,6 +231,12 @@
jira_user: drcrallen
reviewboard_user: drcralle
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r405018860
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string&
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r405018860
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string&
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r405029624
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string& cg
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r405042359
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string&
bmahler commented on issue #356: libprocess: check protobuf (de)serialisation
success.
URL: https://github.com/apache/mesos/pull/356#issuecomment-610590957
Took a look at the protobuf code:
> Before the code didn't check at all the return value of
> Message::SerializeToString, whi
bmahler commented on a change in pull request #356: libprocess: check protobuf
(de)serialisation success.
URL: https://github.com/apache/mesos/pull/356#discussion_r405086348
##
File path: 3rdparty/libprocess/include/process/protobuf.hpp
##
@@ -39,8 +39,11 @@ inline void po
bmahler commented on a change in pull request #356: libprocess: check protobuf
(de)serialisation success.
URL: https://github.com/apache/mesos/pull/356#discussion_r405082745
##
File path: 3rdparty/libprocess/include/process/protobuf.hpp
##
@@ -329,13 +332,11 @@ class Proto
cf-natali commented on a change in pull request #356: libprocess: check
protobuf (de)serialisation success.
URL: https://github.com/apache/mesos/pull/356#discussion_r405139203
##
File path: 3rdparty/libprocess/include/process/protobuf.hpp
##
@@ -39,8 +39,11 @@ inline void
cf-natali commented on a change in pull request #356: libprocess: check
protobuf (de)serialisation success.
URL: https://github.com/apache/mesos/pull/356#discussion_r405139102
##
File path: 3rdparty/libprocess/include/process/protobuf.hpp
##
@@ -329,13 +332,11 @@ class Pro
cf-natali commented on issue #356: libprocess: check protobuf (de)serialisation
success.
URL: https://github.com/apache/mesos/pull/356#issuecomment-610643627
> This will only return false for the message being too large? Where do you
see out of memory being handled?
Agreed. I *thoug
cf-natali commented on issue #356: libprocess: check protobuf (de)serialisation
success.
URL: https://github.com/apache/mesos/pull/356#issuecomment-610644546
On a slightly-tangential subject: how do you deal with formatting?
I can see that there's a `support/clang-format` file, but apply
bmahler commented on issue #356: libprocess: check protobuf (de)serialisation
success.
URL: https://github.com/apache/mesos/pull/356#issuecomment-610660551
> On a slightly-tangential subject: how do you deal with formatting?
I can see that there's a support/clang-format file, but applyin
bmahler closed pull request #356: libprocess: check protobuf (de)serialisation
success.
URL: https://github.com/apache/mesos/pull/356
This is an automated message from the Apache Git Service.
To respond to the message, pleas
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r405612984
##
File path: docs/contributors.yaml
##
@@ -231,6 +231,12 @@
jira_user: drcrallen
reviewboard_user: drcral
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r405615701
##
File path: src/linux/cgroups.cpp
##
@@ -696,13 +696,24 @@ Try remove(const string& hierarchy, const
string&
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406246095
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,98 @@ static Try cloneCpusetCpusMems(
return Nothing();
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406268132
##
File path: src/linux/cgroups.cpp
##
@@ -1535,22 +1629,20 @@ class Destroyer : public Process
void remove()
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406270107
##
File path: src/linux/cgroups.cpp
##
@@ -1535,22 +1629,20 @@ class Destroyer : public Process
void remove()
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406378209
##
File path: src/linux/cgroups.cpp
##
@@ -1535,22 +1629,20 @@ class Destroyer : public Process
void remove
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406378922
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,98 @@ static Try cloneCpusetCpusMems(
return Nothing();
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406378603
##
File path: src/linux/cgroups.cpp
##
@@ -1535,22 +1629,20 @@ class Destroyer : public Process
void remove
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406738281
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing(
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406760777
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing(
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406729204
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing(
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406727510
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing(
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406744824
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing(
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406854135
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing();
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406854300
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing();
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406855188
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing();
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406855125
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing();
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r406855260
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing();
cf-natali commented on issue #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#issuecomment-612129236
> It seems the existing method `cgroups::remove` is not used anywhere except
in the unit test codes, so do we still need it? Or we want to change it
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407035630
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems(
return Nothing(
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407051855
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,73 @@ static Try cloneCpusetCpusMems(
return Nothing(
qianzhangxa commented on issue #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#issuecomment-612398466
> > It seems the existing method `cgroups::remove` is not used anywhere
except in the unit test codes, so do we still need it? Or we want to chang
qianzhangxa edited a comment on issue #355: Handle EBUSY when destroying a
cgroup.
URL: https://github.com/apache/mesos/pull/355#issuecomment-612398466
> > It seems the existing method `cgroups::remove` is not used anywhere
except in the unit test codes, so do we still need it? Or we want
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407163471
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,73 @@ static Try cloneCpusetCpusMems(
return Nothing();
cf-natali commented on issue #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#issuecomment-612580001
> > > It seems the existing method `cgroups::remove` is not used anywhere
except in the unit test codes, so do we still need it? Or we want to chang
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407207279
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,73 @@ static Try cloneCpusetCpusMems(
return Nothing(
qianzhangxa commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407208547
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,73 @@ static Try cloneCpusetCpusMems(
return Nothing(
qianzhangxa commented on issue #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#issuecomment-612629131
> > > > It seems the existing method `cgroups::remove` is not used anywhere
except in the unit test codes, so do we still need it? Or we want to c
cf-natali commented on issue #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#issuecomment-612649988
OK, hopefully good to merge now :).
This is an automated message from the Apache Gi
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407228978
##
File path: src/linux/cgroups.cpp
##
@@ -263,6 +265,73 @@ static Try cloneCpusetCpusMems(
return Nothing();
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407230922
##
File path: src/linux/cgroups.cpp
##
@@ -691,21 +760,6 @@ Try create(
}
-Try remove(const string& hierarchy
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r407235607
##
File path: src/linux/cgroups.cpp
##
@@ -691,21 +760,6 @@ Try create(
}
-Try remove(const string& hierarc
Bo98 opened a new pull request #357: Fixed missing find_if namespace
qualification
URL: https://github.com/apache/mesos/pull/357
See 0273fbc2638c581528cc5819da2e0c9b1a9c235e for why this is needed. This
one was just left out from that commit, but is included in FreeBSD's patches.
bmahler commented on issue #357: Fixed missing find_if namespace qualification
URL: https://github.com/apache/mesos/pull/357#issuecomment-613043220
Thanks! This is now committed
This is an automated message from the Apache Git
bmahler closed pull request #357: Fixed missing find_if namespace qualification
URL: https://github.com/apache/mesos/pull/357
This is an automated message from the Apache Git Service.
To respond to the message, please log on
abudnik commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r408157119
##
File path: src/tests/containerizer/cgroups_isolator_tests.cpp
##
@@ -1489,7 +1489,7 @@ TEST_F(CgroupsIsolatorTe
cf-natali commented on a change in pull request #355: Handle EBUSY when
destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355#discussion_r408645634
##
File path: src/tests/containerizer/cgroups_isolator_tests.cpp
##
@@ -1489,7 +1489,7 @@ TEST_F(CgroupsIsolator
asfgit closed pull request #355: Handle EBUSY when destroying a cgroup.
URL: https://github.com/apache/mesos/pull/355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
cf-natali opened a new pull request #358: Mention that tests should be run as
root/admin in contribution guides.
URL: https://github.com/apache/mesos/pull/358
@abudnik
This is an automated message from the Apache Git Service
bmahler commented on issue #358: Mention that tests should be run as root/admin
in contribution guides.
URL: https://github.com/apache/mesos/pull/358#issuecomment-614808981
@abudnik perhaps we could be a bit more specific about when to run as root?
We have a lot of test filters so it
cf-natali opened a new pull request #359: Made the cgroup listener stop logging
spurious error on finalization.
URL: https://github.com/apache/mesos/pull/359
Before, running any task would cause the following error to be logged
when the OOM listener was finalized:
```
E0418 14:
bmahler commented on issue #359:
URL: https://github.com/apache/mesos/pull/359#issuecomment-616714632
Looks good, adjusted the commit description a bit and pushed this.
This is an automated message from the Apache Git Service
akornatskyy opened a new pull request #360:
URL: https://github.com/apache/mesos/pull/360
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
akornatskyy commented on pull request #360:
URL: https://github.com/apache/mesos/pull/360#issuecomment-619805494
@asekretenko @greggomann Fixed mesos java bindings for cmake by reversing
dependency so `libmesos-java` depends on `libmesos`.
-
akornatskyy opened a new pull request #361:
URL: https://github.com/apache/mesos/pull/361
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
akornatskyy commented on pull request #361:
URL: https://github.com/apache/mesos/pull/361#issuecomment-619808069
@asekretenko @greggomann : this is another improvement to cmake to be able
to build with a custom location of boost-libs, curl and libseccomp.
-
greggomann commented on a change in pull request #361:
URL: https://github.com/apache/mesos/pull/361#discussion_r416643733
##
File path: 3rdparty/CMakeLists.txt
##
@@ -696,7 +701,16 @@ if (ENABLE_SECCOMP_ISOLATOR)
URL ${LIBSECCOMP_URL}
URL_HASH
akornatskyy commented on a change in pull request #361:
URL: https://github.com/apache/mesos/pull/361#discussion_r416710336
##
File path: 3rdparty/CMakeLists.txt
##
@@ -696,7 +701,16 @@ if (ENABLE_SECCOMP_ISOLATOR)
URL ${LIBSECCOMP_URL}
URL_HASH
greggomann commented on a change in pull request #361:
URL: https://github.com/apache/mesos/pull/361#discussion_r416997093
##
File path: 3rdparty/CMakeLists.txt
##
@@ -194,29 +194,34 @@ endfunction()
# Boost: C++ Libraries.
# http://www.boost.org
###
-EXT
akornatskyy commented on a change in pull request #361:
URL: https://github.com/apache/mesos/pull/361#discussion_r417074587
##
File path: 3rdparty/CMakeLists.txt
##
@@ -194,29 +194,34 @@ endfunction()
# Boost: C++ Libraries.
# http://www.boost.org
###
-EX
cf-natali opened a new pull request #362:
URL: https://github.com/apache/mesos/pull/362
This is a follow-up to MESOS-10107, which introduced retries when
calling rmdir on a seemingly empty cgroup fails with EBUSY because of
various kernel bugs.
At the time, the fix introduced a boun
cf-natali commented on pull request #362:
URL: https://github.com/apache/mesos/pull/362#issuecomment-624897538
@vinodkone
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vinodkone commented on pull request #362:
URL: https://github.com/apache/mesos/pull/362#issuecomment-624911683
I'll let @abudnik and @qianzhangxa review this since they have the most
context.
This is an automated message fro
cf-natali commented on pull request #362:
URL: https://github.com/apache/mesos/pull/362#issuecomment-624914041
Note that this might help us alleviate
https://issues.apache.org/jira/browse/MESOS-8038
If a process cannot be killed - e.g. stuck in uninterruptible D state - the
cgroup d
cf-natali commented on a change in pull request #362:
URL: https://github.com/apache/mesos/pull/362#discussion_r421371142
##
File path: src/linux/cgroups.cpp
##
@@ -1611,6 +1612,8 @@ class Destroyer : public Process
// The killer processes used to atomically kill tasks in
cf-natali commented on a change in pull request #362:
URL: https://github.com/apache/mesos/pull/362#discussion_r421370904
##
File path: src/linux/cgroups.cpp
##
@@ -291,8 +290,9 @@ Future remove(const string& hierarchy, const
string& cgroup)
[=](const Nothing&) mutable
cf-natali commented on pull request #362:
URL: https://github.com/apache/mesos/pull/362#issuecomment-625436409
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
greggomann commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r424678947
##
File path: 3rdparty/CMakeLists.txt
##
@@ -99,6 +99,12 @@ else ()
set(LIBRARY_SUFFIX ${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()
+if (WIN32 AND BUILD_
greggomann commented on a change in pull request #363:
URL: https://github.com/apache/mesos/pull/363#discussion_r424680213
##
File path: 3rdparty/CMakeLists.txt
##
@@ -99,6 +99,12 @@ else ()
set(LIBRARY_SUFFIX ${CMAKE_STATIC_LIBRARY_SUFFIX})
endif ()
+if (WIN32 AND BUILD_
1 - 100 of 1051 matches
Mail list logo
