---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43741/#review119732
---
Ship it!
Good catch.
- James Peach
On Feb. 18, 2016, 10:48
51f016b049c6e947c4d27fbbbf79c53f9ec5a51e
src/tests/hdfs_tests.cpp 29f156028af57b83ee2aa299f3b1c89e96d15fd0
Diff: https://reviews.apache.org/r/42370/diff/
Testing
---
make check on Centos6 w/ devtoolset-3. Running in production for a number of
weeks.
Thanks,
James Peach
/slave/containerizer/fetcher.cpp 33dfcade6beb53a5a6dbc41a8f3380f5cb30a161
src/tests/fetcher_tests.cpp fb47706eb90ae5808bafe13c681d609a808b0c8e
Diff: https://reviews.apache.org/r/44029/diff/
Testing
---
``make check`` on OS X.
Thanks,
James Peach
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44029/#review120864
---
On Feb. 25, 2016, 6:32 p.m., James Peach wrote:
>
> ---
(line 338)
<https://reviews.apache.org/r/44151/#comment182831>
It would be cleaner just to pass the vector data directly:
```C
::setgroups(gids.size(), &gids[0])
```
- James Peach
On Feb. 29, 2016, 12:08 a.m., Ji
(line 310)
<https://reviews.apache.org/r/44151/#comment182833>
Darwin does have a ``gid_t`` type, why is this ifdef needed?
- James Peach
On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote:
>
> ---
> This is an automatically g
(line 314)
<https://reviews.apache.org/r/44151/#comment182835>
On mosys systems, you should get the max groups from ``sysconf``.
- James Peach
On Feb. 29, 2016, 12:08 a.m., Jie Yu wrote:
>
> ---
> This is an automatica
generations to add a
comment about where the relative paths actually point to and constructing this
path is safe.
- James Peach
On Feb. 27, 2016, 1:55 a.m., Zhiwei Chen wrote:
>
> ---
> This is an automatically generated e-mail.
approach available to users, it's easier to
> then come back and impose a deprecate cycle for the default behavior. What do
> you think?
>
> James Peach wrote:
> Yes, there's definitely compatibility concern (for example,
> ``http://foo/bar/baz?filename.zip`` would
44342/diff/
Testing
---
Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
Thanks,
James Peach
, visit:
https://reviews.apache.org/r/44342/#review121878
---
On March 3, 2016, 4:55 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
iff: https://reviews.apache.org/r/44342/diff/
Testing
---
Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
Thanks,
James Peach
ly work in linux?
Yes.
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review121889
---
On March 3
--------
On March 3, 2016, 5 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44342/
> --
iff: https://reviews.apache.org/r/44342/diff/
Testing
---
Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
Thanks,
James Peach
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review121890
---
On March 3, 2016, 6:06 p.m., James Peach wrote:
>
> ---
> This
.org/r/44342/#review121890
---
On March 3, 2016, 6:06 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review121952
---
On March 3, 2016, 6:06 p.m., James Peach wrote:
>
> ---
> This is a
.
Thanks,
James Peach
gt; <https://reviews.apache.org/r/44342/diff/3/?file=1279808#file1279808line191>
> >
> > Why a union here?
The union is to avoid a ``reinterpret_cast`` later.
- James
---
This is an automatically generated e-mail. To
.org/r/44342/diff/3/?file=1279808#file1279808line17>
> >
> > Add a link that explains this?
>
> James Peach wrote:
> A link to what?
I described the problem in more detail.
> On March 9, 2016, 6:03 p.m., Jiang Yan Xu wrote:
> > src/slave/conta
fs.cpp PRE-CREATION
src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388
src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe
Diff: https://reviews.apache.org/r/44342/diff/
Testing
---
Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
Thanks,
James Peach
src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388
src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe
Diff: https://reviews.apache.org/r/44342/diff/
Testing
---
Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
Thanks,
James Peach
/linux/xfs.cpp PRE-CREATION
src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44749/diff/
Testing
---
make check on Fedora 23.
Thanks,
James Peach
/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388
src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe
Diff: https://reviews.apache.org/r/44342/diff/
Testing
---
Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
Thanks,
James Peach
://reviews.apache.org/r/44945/diff/
Testing
---
Make check. Manual verification.
Thanks,
James Peach
fs.cpp PRE-CREATION
src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388
src/slave/flags.cpp b77afa956834bb5b1f85301d7a5f386ab9da41e3
Diff: https://reviews.apache.org/r/44948/diff/
Testing
---
Make check. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
/containerizer/xfs_quota_tests.cpp PRE-CREATION
src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
ck. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
://reviews.apache.org/r/44945/diff/
Testing
---
Make check. Manual verification.
Thanks,
James Peach
://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
/containerizer/xfs_quota_tests.cpp PRE-CREATION
src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
.
Thanks,
James Peach
(updated)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
/linux/xfs.hpp PRE-CREATION
src/linux/xfs.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44946/diff/
Testing
---
Make check. Manual verification. Tests in subsequent patches.
Thanks,
James Peach
/linux/xfs.hpp PRE-CREATION
src/linux/xfs.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44946/diff/
Testing
---
Make check. Manual verification. Tests in subsequent patches.
Thanks,
James Peach
://reviews.apache.org/r/44946/diff/
Testing
---
Make check. Manual verification. Tests in subsequent patches.
Thanks,
James Peach
Testing
---
Make check. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
(updated)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
> On March 17, 2016, 3:44 p.m., James Peach wrote:
> > Ship It!
Verified that this patch fixes the chunked response parsing.
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44944/#review124027
---
Ship it!
Ship It!
- James Peach
On March 17, 2016, 1:50 a.m
e alternative imposes
an undue burden on operators because they will have to repackage if they want
to enable a feature.
However, I'm not going to argue this any furthere here. I'll just guard this
with ``AC_ARG_WITH`` (@xujyan is right this should have been ``AC_ARG
9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8
Diff: https://reviews.apache.org/r/44945/diff/
Testing
---
Make check. Manual verification.
Thanks,
James Peach
9dd21b56af0500f7125b07bf535b45fe5c544aaf
src/linux/xfs.hpp PRE-CREATION
src/linux/xfs.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44946/diff/
Testing
---
Make check. Manual verification. Tests in subsequent patches.
Thanks,
James Peach
/containerizer/xfs_quota_tests.cpp PRE-CREATION
src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
ck. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
If not, worth adding a TODO.
Basic blocks not related to the underlying filesystem block size, they are just
a 512 byte unit used in the quota API.
- James
---
This is an automatically generated e-mail. To reply, vis
9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8
Diff: https://reviews.apache.org/r/44945/diff/
Testing
---
Make check. Manual verification.
Thanks,
James Peach
9dd21b56af0500f7125b07bf535b45fe5c544aaf
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
9dd21b56af0500f7125b07bf535b45fe5c544aaf
src/linux/xfs.hpp PRE-CREATION
src/linux/xfs.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44946/diff/
Testing
---
Make check. Manual verification. Tests in subsequent patches.
Thanks,
James Peach
d10fa2e7fc7c477de2f0e30e10da6d817ecbf404
docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
differences in semantics.
Diffs (updated)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
44948/diff/
Testing
---
Make check. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
9dd21b56af0500f7125b07bf535b45fe5c544aaf
src/linux/xfs.hpp PRE-CREATION
src/linux/xfs.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44946/diff/
Testing
---
Make check. Manual verification. Tests in subsequent patches.
Thanks,
James Peach
> On March 19, 2016, 10:10 p.m., Jie Yu wrote:
> > src/linux/xfs.cpp, line 53
> > <https://reviews.apache.org/r/44946/diff/3/?file=1304831#file1304831line53>
> >
> > Instead of relying on parameter, can we use os::stat::isdir here?
>
> James Peac
9dd21b56af0500f7125b07bf535b45fe5c544aaf
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
semantics.
Diffs (updated)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
9dd21b56af0500f7125b07bf535b45fe5c544aaf
src/linux/xfs.hpp PRE-CREATION
src/linux/xfs.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44946/diff/
Testing
---
Make check. Manual verification. Tests in subsequent patches.
Thanks,
James Peach
9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8
Diff: https://reviews.apache.org/r/44945/diff/
Testing
---
Make check. Manual verification.
Thanks,
James Peach
d10fa2e7fc7c477de2f0e30e10da6d817ecbf404
docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
Testing
---
Make check. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/#review124486
---
On March 21, 2016, 9:47 p.m., James Peach wrote:
>
>
://reviews.apache.org/r/44948/#review124486
---
On March 21, 2016, 9:47 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. T
9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8
Diff: https://reviews.apache.org/r/44945/diff/
Testing
---
Make check. Manual verification.
Thanks,
James Peach
d10fa2e7fc7c477de2f0e30e10da6d817ecbf404
docs/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
9dd21b56af0500f7125b07bf535b45fe5c544aaf
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
.
Thanks,
James Peach
Testing
---
Make check. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
semantics.
Diffs (updated)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
://reviews.apache.org/r/44945/diff/
Testing
---
Make check. Manual verification.
Thanks,
James Peach
/containerizer/xfs_quota_tests.cpp PRE-CREATION
src/tests/environment.cpp ee59a09c44242a2d31ff539106edbcb316b120aa
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
To reply, visit:
https://reviews.apache.org/r/44946/#review124827
---
On March 22, 2016, 1:20 a.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To rep
-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
(updated)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
ck. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
.
Thanks,
James Peach
structure to zero, to get the same result.
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44946/#review124248
---
On
/containerizer/xfs_quota_tests.cpp PRE-CREATION
src/tests/environment.cpp 7617e43587cb81104786d06f753f08565a6c2d0a
Diff: https://reviews.apache.org/r/44947/diff/
Testing
---
Make check. Manual testing. These tests.
Thanks,
James Peach
for is
enabled.
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44945/#review125457
---
On March 26, 2016, 5:05 p.m.,
9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8
Diff: https://reviews.apache.org/r/44945/diff/
Testing
---
Make check. Manual verification.
Thanks,
James Peach
(updated)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
.
Thanks,
James Peach
sk" would be a reasonable choice.
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/#review124983
---
On March 22, 2016, 1
-
On March 22, 2016, 11:24 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44948/
> ---
n
> > all checks succeed.
> >
> > Would this work?
> >
> > If we do this, then the message could be `AC_MSG_CHECKING([whether we
> > can enable the XFS disk isolator])`
>
> James Peach wrote:
> No, this message should be outside the check
/stout/tests/protobuf_tests.pb.cc``?
- James Peach
On March 28, 2016, 7:05 p.m., Zhiwei Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On March 28, 2016, 7:13 p.m., James Peach wrote:
> > Do you also need to regenerate
> > ``3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc``?
Oh, I see it is in [r44257](https://reviews.apache.org/r/44
/mesos-containerizer.md 15fb5bdbe74e059614b8948108f32cd04b623305
Diff: https://reviews.apache.org/r/44950/diff/
Testing
---
Make check. Source inspection.
Thanks,
James Peach
.
Diffs (updated)
-
src/tests/containerizer/xfs_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44949/diff/
Testing
---
Make check. Manual testing.
Thanks,
James Peach
ad57664367
src/slave/flags.cpp fd9fbbaa911cc77a21574ba314c50ac226fa49ce
Diff: https://reviews.apache.org/r/44948/diff/
Testing
---
Make check. Manual testing. Tests in subsequent patches.
Thanks,
James Peach
ound the set of possible IDs and this ID is not longer possible.
- James
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44948/#review124983
--
21e2965bb7cd9b88a5c787dd3efe0673c71cdc4f
src/slave/containerizer/mesos/isolators/xfs/utils.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/xfs/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/44946/diff/
Testing
---
Make check. Manual verification. Tests in subsequent patches.
Thanks,
James Peach
.
Thanks,
James Peach
1 - 100 of 1755 matches
Mail list logo
