Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread James Peach
://reviews.apache.org/r/33491/diff/ Testing --- Ran make check on CentOS 7 and OS X 10.10.3. Thanks, James Peach

Re: Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread James Peach
` below? Is it possible for only some of these calls to fail with EPERM? James Peach wrote: If you do a ``setgid`` to your current GID, it succeeds and does nothing, but ``initgroups`` ends up calling ``setgroups`` which fails with EPERM. If you were trying to switch to a different

Re: Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread James Peach
--- On April 23, 2015, 8:16 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33491/ --- (Updated April 23, 2015, 8:16

Review Request 33446: Link to mesos-containerizer from the main documentation page.

2015-04-22 Thread James Peach
documentation and verify the link is corect using ``middleman server``. Thanks, James Peach

Re: Review Request 33446: Link to mesos-containerizer from the main documentation page.

2015-04-22 Thread James Peach
/ Testing --- Build the Mesos documentation and verify the link is corect using ``middleman server``. Thanks, James Peach

Review Request 33754: Update pthread autoconf macros for libprocess.

2015-05-01 Thread James Peach
2cf20de144a11be2aa603b04ea511244191037b7 3rdparty/libprocess/m4/ax_pthread.m4 PRE-CREATION Diff: https://reviews.apache.org/r/33754/diff/ Testing --- Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and Mac OS X 10.10.3. Thanks, James Peach

Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-01 Thread James Peach
2cf20de144a11be2aa603b04ea511244191037b7 m4/ax_pthread.m4 PRE-CREATION m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d Diff: https://reviews.apache.org/r/33753/diff/ Testing --- Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and Mac OS X 10.10.3. Thanks, James Peach

Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-05-01 Thread James Peach
and --disable-foo do different things. Thanks, James Peach

Review Request 33755: Remove the unused acx_pthread autoconf macro from stout.

2015-05-01 Thread James Peach
--- Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and Mac OS X 10.10.3. Thanks, James Peach

Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-05-05 Thread James Peach
that the default CentOS 6 GCC toolchain is still rejected as too old. Thanks, James Peach

Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread James Peach
as too old. Thanks, James Peach

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread James Peach
On May 5, 2015, 4:29 p.m., Cody Maloney wrote: configure.ac, line 575 https://reviews.apache.org/r/33849/diff/1/?file=950367#file950367line575 Can you check ax_cxx_compiler_version = Clang/LLVM 3.5 here? Or does that not work on both OS X and Linux? James Peach wrote: Hmm

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33849/#review82524 --- On May 5, 2015, 3:53 p.m., James Peach wrote

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread James Peach
On May 5, 2015, 4:29 p.m., Cody Maloney wrote: configure.ac, line 575 https://reviews.apache.org/r/33849/diff/1/?file=950367#file950367line575 Can you check ax_cxx_compiler_version = Clang/LLVM 3.5 here? Or does that not work on both OS X and Linux? James Peach wrote: Hmm

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-05-05 Thread James Peach
/ Testing --- Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 6 GCC toolchain is still rejected as too old. Thanks, James Peach

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-05-15 Thread James Peach
check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 6 GCC toolchain is still rejected as too old. Thanks, James Peach

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/#review84185 --- On May 1, 2015, 4:02 p.m., James Peach wrote

Review Request 35234: libprocess: consistent handling of --enable options

2015-06-08 Thread James Peach
is that the only safe path is to use the bundled gmock. There's no real path through the build to use decoupled gmock and gtest, it seems to be assumed that gmock will provide gtest. Thanks, James Peach

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-06-08 Thread James Peach
reflects the expected compiler flags. Verify that --enable-foo and --disable-foo do different things. Thanks, James Peach

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-08 Thread James Peach
: $ onfigure.developer --disable-bundled --with-zookeeper=bundled --with-gmock=bundled To work completely, this change needs to be propagated to libprocess, which I can do once reviewers agree that it's the right behavior. Thanks, James Peach

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-06-09 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35234/#review87101 --- On June 9, 2015, 12:04 a.m., James Peach wrote: --- This is an automatically generated e

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread James Peach
--- On May 15, 2015, 4:24 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33850

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-06-04 Thread James Peach
/#review82272 --- On May 1, 2015, 7:51 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752

Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-04 Thread James Peach
reviewers agree that it's the right behavior. Thanks, James Peach

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-06-04 Thread James Peach
the package locally, and if not enable the bundled one). Internally we don't really use that codepath though. James Peach wrote: In this case, the previous logic was that with_bundled_wheel is yes if without_bundled_wheel=no and enable_bundled=yes. The new logic

Re: Review Request 35234: libprocess: consistent handling of --enable options

2015-08-19 Thread James Peach
would pick up gtest headers from the system and gmock from libprocess 3rdparty. My conclusion is that the only safe path is to use the bundled gmock. There's no real path through the build to use decoupled gmock and gtest, it seems to be assumed that gmock will provide gtest. Thanks, James

Review Request 36951: MESOS-3052: optimize slave ID comparisons

2015-07-30 Thread James Peach
in production for a few weeks, yields ~50% CPU reduction. Tested with make check and make bench. Thanks, James Peach

Re: Review Request 36951: MESOS-3052: optimize slave ID comparisons

2015-07-30 Thread James Peach
/diff/ Testing (updated) --- Running in production for a few weeks, yields ~10% CPU reduction. Tested with make check and make bench. Thanks, James Peach

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-04 Thread James Peach
On Aug. 4, 2015, 6:36 a.m., Michael Park wrote: src/tests/containerizer/memory_test_helper.cpp, line 81 https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81 What's the significance in the order in which these are called? I would've expected something like:

Review Request 37133: Add a frameworks parameter to the hierarchical allocator benchmark.

2015-08-05 Thread James Peach
/hierarchical_allocator_tests.cpp c92d47aa0a06088f1f8fe749a629c27bfadd3c6d Diff: https://reviews.apache.org/r/37133/diff/ Testing --- make check make bench Thanks, James Peach

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-04 Thread James Peach
), whereas mlock() is called for already allocated pages. I could probably change mlockall(MCL_FUTURE) to mlockall(MCL_CURRENT) in your snippet and make it work that way. I'll test to verify and will update the patch accordingly. Thanks! James Peach wrote: IMHO it would be better to add

Review Request 37222: Enable automake maintainer mode.

2015-08-07 Thread James Peach
for the --disable-maintainer-mode option. Thanks, James Peach

Review Request 37221: Enable automake maintainer mode.

2015-08-07 Thread James Peach
option. Thanks, James Peach

Re: Review Request 37257: Add SUPPRESS call interface to the scheduler

2015-08-08 Thread James Peach
. This makes it more consistent with declining offers and allows frameorks to avoid sending an explicit revive. - James Peach On Aug. 8, 2015, 4:25 p.m., Guangya Liu wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-07-14 Thread James Peach
: $ onfigure.developer --disable-bundled --with-zookeeper=bundled --with-gmock=bundled To work completely, this change needs to be propagated to libprocess, which I can do once reviewers agree that it's the right behavior. Thanks, James Peach

Re: Review Request 36510: Update .gitignore with intermediate build artifacts.

2015-07-15 Thread James Peach
-mail. To reply, visit: https://reviews.apache.org/r/36510/#review91751 --- On July 15, 2015, 4:11 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply

Review Request 36510: Update .gitignore with intermediate build artifacts.

2015-07-15 Thread James Peach
tree, run ```git status``` and note the reduced clutter. Thanks, James Peach

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-08-24 Thread James Peach
reflects the expected compiler flags. Verify that --enable-foo and --disable-foo do different things. Thanks, James Peach

Re: Review Request 39597: Add Newbie guide.

2015-10-23 Thread James Peach
and GTest. At least I've always been unsuccessful in building against unbundled versions of those components. - James Peach On Oct. 23, 2015, 3:08 p.m., Diana Arroyo wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 39774: Fix libprocess protobuf library detection.

2015-10-29 Thread James Peach
and manual verification with an external protobuf installation. Thanks, James Peach

Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2015-10-29 Thread James Peach
/browse/MESOS-3725 Repository: mesos Description --- Update ModuleTest to not assume dynamic dlopen search. Diffs - src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 Diff: https://reviews.apache.org/r/39781/diff/ Testing --- make check Thanks, James

Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2015-10-29 Thread James Peach
Thanks, James Peach

Review Request 39770: Write a newline in ABORT().

2015-10-29 Thread James Peach
2b003d26d6b6b65b1d7b1dd6396f808c35b53177 Diff: https://reviews.apache.org/r/39770/diff/ Testing --- make check and manual testing. Thanks, James Peach

Review Request 39782: Add a comment for os::libraries::setPaths.

2015-10-29 Thread James Peach
changes. Thanks, James Peach

Review Request 39775: Fix Mesos protobuf library detection

2015-10-29 Thread James Peach
with an external protobuf installation. Thanks, James Peach

Review Request 39771: Show the failing path when execvpe(2) fails.

2015-10-29 Thread James Peach
testing. Thanks, James Peach

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-10-29 Thread James Peach
--- make check && make bench Thanks, James Peach

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-11 Thread James Peach
://reviews.apache.org/r/40177/diff/ Testing --- make check on CentOS 6.7. Manual testing with a rolling upgrade from 0.22 Thanks, James Peach

Re: Review Request 39800: Fix HDFS du output parsing.

2015-11-13 Thread James Peach
://reviews.apache.org/r/39800/diff/ Testing --- make check. Manual testing with a framework that uses the fetcher with HDFS urls. Thanks, James Peach

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-11 Thread James Peach
uch as possible just in case. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106142 --- On Nov.

Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread James Peach
--- make check on CentOS 6.7. Manual testing with a rolling upgrade from 0.22 Thanks, James Peach

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

2015-10-29 Thread James Peach
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/#review104507 ------- On Oct. 29, 2015, 9 p.m., James Peach wrote: > > --- > This is an a

Review Request 39799: Allow hdfs URLs in the HDFS wrapper API.

2015-10-29 Thread James Peach
the fetcher with HDFS urls. Thanks, James Peach

Review Request 39800: Fix HDFS du output parsing.

2015-10-29 Thread James Peach
the fetcher with HDFS urls. Thanks, James Peach

Re: Review Request 39770: Write a newline in ABORT().

2015-11-03 Thread James Peach
/include/stout/abort.hpp 2b003d26d6b6b65b1d7b1dd6396f808c35b53177 Diff: https://reviews.apache.org/r/39770/diff/ Testing --- make check and manual testing. Thanks, James Peach

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

2015-11-03 Thread James Peach
/ Testing --- make check and manual testing. Thanks, James Peach

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

2015-11-03 Thread James Peach
y generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/#review104994 ------- On Oct. 29, 2015, 9 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

2015-11-03 Thread James Peach
--- make check and manual testing. Thanks, James Peach

Review Request 39938: Document OS X SIGPIPE delivery.

2015-11-04 Thread James Peach
--- make check Thanks, James Peach

Review Request 39941: SIGPIPE is ignored in libprocess so stop handling it.

2015-11-04 Thread James Peach
://reviews.apache.org/r/39941/diff/ Testing --- make check. Run IOTest.Write in a loop on OS X. Thanks, James Peach

Review Request 39940: Globally ignore SIGPIPE in libprocess.

2015-11-04 Thread James Peach
4a7b9b68731ba1ac489109f20af2c1eec0bdc84f Diff: https://reviews.apache.org/r/39940/diff/ Testing --- make check. Run IOTest.Write in a loop on OS X. Thanks, James Peach

Re: Review Request 39217: Windows: Added `stout/os/ftruncate.hpp`.

2015-10-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/#review102973 --- Ship it! Ship It! - James Peach On Oct. 16, 2015, 7:54 p.m

Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

2015-10-15 Thread James Peach
/ftruncate.hpp (line 30) <https://reviews.apache.org/r/39217/#comment160610> Should this be ```_chsize_s``` so you can use a large offset? - James Peach On Oct. 15, 2015, 8:36 p.m., Alex Clemmer wrote: > > --- > This is a

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread James Peach
this: SED_I = $(SED) -i.orig foo: bar $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@ - James Peach On Oct. 14, 2015, 6:26 p.m., Neil Conway wrote: > > --- > This is an automatically generat

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102727 --- Ship it! Ship It! - James Peach On Oct. 14, 2015, 11:41 p.m

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread James Peach
> On Oct. 14, 2015, 11:24 p.m., James Peach wrote: > > Automake detects sed, so I think that you should do something like this: > > > > SED_I = $(SED) -i.orig > > > > foo: bar > > $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_p

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102726 --- Ship it! Ship It! - James Peach On Oct. 14, 2015, 11:41 p.m

Review Request 39350: Adopt os::pipe in libprocess.

2015-10-15 Thread James Peach
: https://reviews.apache.org/r/39350/diff/ Testing --- OS X and CentOS 6 make && make check Thanks, James Peach

Review Request 39348: Fix signal blocking race condition on OS X.

2015-10-15 Thread James Peach
3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 Diff: https://reviews.apache.org/r/39348/diff/ Testing --- OS X and CentOS 6 make && make check Thanks, James Peach

Review Request 39349: Add a Stout wrapper for pipe(2).

2015-10-15 Thread James Peach
/3rdparty/stout/tests/os/signals_tests.cpp 4bb79fdc161483cfc2b7a7a15e5c3ce62ceb493d 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp ee2a7a79617612ed448e650cc77608c4962fe5a5 Diff: https://reviews.apache.org/r/39349/diff/ Testing --- OS X and CentOS 6 make && make check Thanks

Review Request 39347: Add stout wrappers for toggling NOSIGPIPE on file descriptors.

2015-10-15 Thread James Peach
/posix/fcntl.hpp a9cb07ecd16f363cf2f77bc867277c737adfb68b 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/fcntl.hpp 0bad61561ae25adb7ff6d731452577133688f8d4 Diff: https://reviews.apache.org/r/39347/diff/ Testing --- OS X and CentOS 6 make && make check Thanks, James Peach

Review Request 39351: Adopt os::pipe in Mesos.

2015-10-15 Thread James Peach
feca2043503436ac9abac6017ae9059b3fcbed21 Diff: https://reviews.apache.org/r/39351/diff/ Testing --- OS X and CentOS 6 make && make check Thanks, James Peach

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

2015-10-08 Thread James Peach
```. - James Peach On Oct. 8, 2015, 7:28 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39138/ > --

Re: Review Request 39138: Renamed libprocess tests to libprocess-tests.

2015-10-08 Thread James Peach
> On Oct. 8, 2015, 9:24 p.m., James Peach wrote: > > You should also rename ```benchmarks``` and ```ssl-client```. > > Kapil Arya wrote: > Good suggestion. But I think, it will be better to do that in a separate > RR (just to keep this RR chain strictly rel

Re: Review Request 39230: Added check for SASL deprecation into configuration phase.

2015-10-12 Thread James Peach
``` is a little clearer that ```AC_LANG_SOURCE```. If you are going to rely on the diagnostic pragmas, an alternative is to simply use those to disable the warning in the SASL wrappers which is a little more tightly scoped. - James Peach On Oct. 12, 2015, 1:25 p.m., Till Toenshoff wrote

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-18 Thread James Peach
ested. We now upgrade the checkpoint during recovery but only if we need to. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106142 -----

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-18 Thread James Peach
://reviews.apache.org/r/40177/diff/ Testing --- make check on CentOS 6.7. Manual testing with a rolling upgrade from 0.22 Thanks, James Peach

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-08-26 Thread James Peach
, this alost works: $ onfigure.developer --disable-bundled --with-zookeeper=bundled --with-gmock=bundled To work completely, this change needs to be propagated to libprocess, which I can do once reviewers agree that it's the right behavior. Thanks, James Peach

Re: Review Request 35084: Provide consistent behavior for bundled packages.

2015-08-26 Thread James Peach
. Thanks, James Peach

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-08-26 Thread James Peach
that the status summary reflects the expected compiler flags. Verify that --enable-foo and --disable-foo do different things. Thanks, James Peach

Re: Review Request 35084: Provided consistent behavior for bundled packages.

2015-08-26 Thread James Peach
--- On July 15, 2015, 4:59 a.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35084

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-08-26 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review96588 --- On Aug. 26, 2015, 8:11 p.m., James Peach wrote

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-08-31 Thread James Peach
b2160f50db3e0b0d04b0625e7589004016c0f746 Diff: https://reviews.apache.org/r/37958/diff/ Testing --- "make check" on CentOS 6 w/ devtoolset-3. Running in production for multiple weeks. Thanks, James Peach

Review Request 37958: Add an option to only perform batch allocations.

2015-08-31 Thread James Peach
CentOS 6 w/ devtoolset-3. Running in production for multiple weeks. Thanks, James Peach

Re: Review Request 37873: Add quiesce logic in allocator

2015-08-31 Thread James Peach
> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 909 > > > > > > We need to store the information that a framework is quiescing offers > > in a more memory

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread James Peach
ly, visit: https://reviews.apache.org/r/37958/#review97311 ------- On Sept. 1, 2015, 4:34 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread James Peach
9748ca0b3fee25dcec51c64d8ba84dbd4aaf src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569 Diff: https://reviews.apache.org/r/37958/diff/ Testing --- "make check" on CentOS 6 w/ devtoolset-3. Running in production for multiple weeks. Thanks, James Peach

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread James Peach
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97311 --- On Sept. 1, 2015, 4:34 p.m., James Peach wrote: > > -

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-02 Thread James Peach
flag on the framework. - James Peach On Aug. 31, 2015, 5:49 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-02 Thread James Peach
> On Sept. 2, 2015, 4:07 p.m., James Peach wrote: > > Using a ```RefusedFilter``` for this is not the right solution. The point > > of the suppress call is to have a cheap way to disable offers at a > > framework granularity. Adding a ```RefusedFilter``` for the to

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-01 Thread James Peach
on cycle. We could pass down a flag or wrap it in some other way, but that did not seem any less clumsy. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#revie

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-29 Thread James Peach
irectly is a total hack. To do it right, I'd have to plumb an ```allocate()``` call all the way through the ```Allocator``` interface. Is that the right approach? - James --- This is an automatically generated e-mail. T

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
&& make bench Thanks, James Peach

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
&& make bench Thanks, James Peach

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
/ Testing --- make check && make bench Thanks, James Peach

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
t; > > result.await(); > > ``` > > > > However; the allocate function would need to return something other > > than `void` such as `Nothing` for that to work. > > James Peach wrote: > Yeh, the place where I call ```allocate()``` directly is a t

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-30 Thread James Peach
--- make check && make bench Thanks, James Peach

Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-09-22 Thread James Peach
slows down. After around 200 cycles the slowdown increases out of proportion. Diffs - src/tests/hierarchical_allocator_tests.cpp 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 Diff: https://reviews.apache.org/r/38649/diff/ Testing --- make check && make bench Thanks, James Peach

Review Request 38648: Hack the allocator interface to expose the batch allocation internals.

2015-09-22 Thread James Peach
4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 Diff: https://reviews.apache.org/r/38648/diff/ Testing --- make check && make bench Thanks, James Peach

Review Request 37913: Improve allocator filtering by keeping per-slave filter sets.

2015-08-28 Thread James Peach
/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1 support/jenkins_build.sh 8451c055e27a4f64d14fe5ece15d749d092c9a2d Diff: https://reviews.apache.org/r/37913/diff/ Testing --- make check on CentOS 6 w/ devtoolset-3. Thanks, James Peach

  1   2   3   4   5   6   7   8   9   10   >