Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

2015-05-14 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/#review83786 --- On May 13, 2015, 4:36 p.m., Kapil Arya wrote: --- This is an automatically generated e

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

2015-05-14 Thread Kapil Arya
for the hook to complete without worrying about the master/slave/framework shutting down in the meantime. Kapil Arya wrote: I haven't considered the explicit message. I will try to find a prior example and adjust accordingly. Since we have already decoupled shutdown with successful

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

2015-05-14 Thread Kapil Arya
, 2015, 4:36 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/ --- (Updated May 13, 2015, 4:36 p.m

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

2015-05-13 Thread Kapil Arya
98d859f3db6013a2e155d838f590a0cde6dc5ed5 src/tests/hook_tests.cpp a65c0ab7c41ec3b7964f9d572381fa3e61746dc3 Diff: https://reviews.apache.org/r/29947/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
by __linux__. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review88442 --- On June 22, 2015, 1:56 p.m., Kapil Arya wrote

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- make check Thanks, Kapil Arya

Re: Review Request 35774: Removed libgen.h include.

2015-06-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35774/#review88990 --- Ship it! Ship It! - Kapil Arya On June 23, 2015, 4:26 a.m

Re: Review Request 35775: Removed libgen.h include.

2015-06-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35775/#review88991 --- Ship it! Ship It! - Kapil Arya On June 23, 2015, 4:27 a.m

Re: Review Request 35131: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35131/#review88980 --- Ship it! Ship It! - Kapil Arya On June 23, 2015, 4:26 a.m

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-23 Thread Kapil Arya
this header here? There is no other change in the file. src/slave/state.hpp (lines 130 - 131) https://reviews.apache.org/r/34260/#comment141580 I think this will fit on one line :-). - Kapil Arya On June 23, 2015, 4:26 a.m., Till Toenshoff wrote

Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path

2015-06-23 Thread Kapil Arya
/35766/? - Kapil Arya On June 22, 2015, 10:39 p.m., Roger Ignazio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35763

Re: Review Request 34256: Added Path::dirname() and Path::basename().

2015-06-23 Thread Kapil Arya
(lines 40 - 52) https://reviews.apache.org/r/34256/#comment141577 It probably applies to the Class itself, but should we also be testing for repeated middle slashes like /a//b/c//d/? Or is it beyond the scope of Path class? - Kapil Arya On June 23, 2015, 4:26 a.m., Till Toenshoff wrote

Re: Review Request 34259: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34259/#review88981 --- Ship it! Ship It! - Kapil Arya On June 23, 2015, 4:26 a.m

Re: Review Request 35771: Fixed post-reviews.py hanging bug.

2015-06-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35771/#review88972 --- Ship it! Ship It! - Kapil Arya On June 23, 2015, 3:17 a.m

Review Request 35756: Fixed a race condition in hook tests for remove-executor hook.

2015-06-22 Thread Kapil Arya
Diff: https://reviews.apache.org/r/35756/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 35756: Fixed a race condition in hook tests for remove-executor hook.

2015-06-23 Thread Kapil Arya
--- On June 23, 2015, 5:47 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35756/ --- (Updated June 23, 2015, 5

Re: Review Request 35766: Added --with-libnl=DIR configure flag.

2015-06-23 Thread Kapil Arya
, the LDFLAGS options isn't needed. Thanks, Kapil Arya

Re: Review Request 35861: Correct include list errors for stout

2015-06-25 Thread Kapil Arya
the differentiation between `#include stout/os.hpp` and `#include os.hpp`? - Kapil Arya On June 25, 2015, 5:58 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35861

Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

2015-06-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35917/#review89476 --- Ship it! Ship It! - Kapil Arya On June 26, 2015, 3:47 a.m

Re: Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Kapil Arya
563e9c529444b3e980db6d04173f0d016a737c74 Diff: https://reviews.apache.org/r/35762/diff/ Testing --- Tested by running configure check with 3.2.25 and 3.2.26. Thanks, Kapil Arya

Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Kapil Arya
check with 3.2.25 and 3.2.26. Thanks, Kapil Arya

Review Request 35765: Updated network-monitoring docs to reflect correct libnl version.

2015-06-22 Thread Kapil Arya
://issues.apache.org/jira/browse/MESOS-2917 Repository: mesos Description --- The correct libnl required version is = 3.2.26. Diffs - docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22 Diff: https://reviews.apache.org/r/35765/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

2015-06-22 Thread Kapil Arya
/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

2015-06-22 Thread Kapil Arya
8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review88902 --- On June 22, 2015, 10:48 p.m., Kapil Arya wrote: --- This is an automatically generated e

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
Thanks, Kapil Arya

Re: Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Kapil Arya
- configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 Diff: https://reviews.apache.org/r/35762/diff/ Testing --- Tested by running configure check with 3.2.25 and 3.2.26. Thanks, Kapil Arya

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
check Thanks, Kapil Arya

Review Request 35766: Added --with-libnl=DIR configure flag.

2015-06-23 Thread Kapil Arya
://reviews.apache.org/r/35766/diff/ Testing --- Tested with: ``` ../configure --with-network-isolator --with-libnl=/usr/local LDFLAGS=-L/usr/local/lib64 ``` On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options isn't needed. Thanks, Kapil Arya

Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

2015-06-22 Thread Kapil Arya
8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
) Failed to synchronize with slave (it's probably exited) Failed to synchronize with slave (it's probably exited) thinkpad:/home/kapil/mesos/netns/build-port-mapping # ``` Thanks, Kapil Arya

Re: Review Request 35766: Added --with-libnl=DIR configure flag.

2015-06-23 Thread Kapil Arya
options isn't needed. Thanks, Kapil Arya

Re: Review Request 35766: Added --with-nl=DIR configure flag.

2015-06-23 Thread Kapil Arya
``` On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options isn't needed. Thanks, Kapil Arya

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-17 Thread Kapil Arya
Diff: https://reviews.apache.org/r/30339/diff/ Testing --- make check Thanks, Kapil Arya

Review Request 35585: Updated Isolator to return required namespaces.

2015-06-17 Thread Kapil Arya
6b24e2990311d0b09b3f6f2bb4ab29ee83fc src/slave/containerizer/isolators/network/port_mapping.hpp ee869ce71a68f51d58159c701d3c5d1e502b Diff: https://reviews.apache.org/r/35585/diff/ Testing --- make check Thanks, Kapil Arya

Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

2015-06-17 Thread Kapil Arya
Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
3ffde6d6b2faeb5a8a40eb27c3b0a2b7f9ecd2b1 Diff: https://reviews.apache.org/r/30339/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review86436 --- On June 15, 2015, 5:22 p.m., Kapil Arya wrote

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-15 Thread Kapil Arya
/30339/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-01 Thread Kapil Arya
271cb03770cd08406054dfce35d0821475e49b05 src/tests/hook_tests.cpp 3ffde6d6b2faeb5a8a40eb27c3b0a2b7f9ecd2b1 Diff: https://reviews.apache.org/r/30339/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-01 Thread Kapil Arya
--- On June 1, 2015, 5:26 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-01 Thread Kapil Arya
3ffde6d6b2faeb5a8a40eb27c3b0a2b7f9ecd2b1 Diff: https://reviews.apache.org/r/30339/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review86091 --- On June 1, 2015, 5:46 p.m., Kapil Arya wrote: --- This is an automatically generated

Re: Review Request 36071: Add flow diagram for docker containerizer.

2015-07-01 Thread Kapil Arya
On July 1, 2015, 11:45 a.m., Till Toenshoff wrote: When trying to apply locally, I get: ``` $ ./support/apply-review.sh 36071 2015-07-01 17:43:28 URL:https://reviews.apache.org/r/36071/diff/raw/ [1338/1338] - 36071.patch [1] 36071.patch:15: new blank line at EOF. + error:

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-07-01 Thread Kapil Arya
/35855/#comment142943 Nice catch. Seems like you've caught as potential segfault (here and below) :-). - Kapil Arya On July 1, 2015, 1:24 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36037: Adding /call endpoint to Master

2015-07-01 Thread Kapil Arya
:-). - Kapil Arya On June 30, 2015, 9:52 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037

Re: Review Request 35974: Fix missing new line in ssl_client.

2015-06-27 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35974/#review89632 --- Ship it! Ship It! - Kapil Arya On June 27, 2015, 3:30 p.m

Re: Review Request 36200: Change framework for framwork

2015-07-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36200/#review90490 --- Ship it! Ship It! - Kapil Arya On July 6, 2015, 9:38 a.m

Re: Review Request 36078: Refactored Call message to include Subscribe message.

2015-06-30 Thread Kapil Arya
://reviews.apache.org/r/36078/#comment142933 May be I am missing something here, but shouldn't we avoid changing the numbered tags for the message fields? This would mean that we should introduce Subscribe as: `optional Subscribe subscribe = 10'`. - Kapil Arya On July 1, 2015, 1

Re: Review Request 36078: Refactored Call message to include Subscribe message.

2015-07-01 Thread Kapil Arya
/scheduler/scheduler.proto https://reviews.apache.org/r/36078/#comment142935 How are we going to allow backwards compatibility. Shouldn't we just mark framework_info as optional and keep setting it for older Masters? - Kapil Arya On July 1, 2015, 1:23 a.m., Vinod Kone wrote

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Kapil Arya
Diff: https://reviews.apache.org/r/37007/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Kapil Arya
and taskId. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93827 --- On Aug. 1, 2015, 12:24 a.m., Kapil Arya wrote

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-22 Thread Kapil Arya
) https://reviews.apache.org/r/37669/#comment151333 s/version4/version5 - Kapil Arya On Aug. 22, 2015, 2:10 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-22 Thread Kapil Arya
17) https://reviews.apache.org/r/37669/#comment151331 Since we are using just `std::min`, can't we simple use an `if` or `?:` to avoid including this file. There were some concerns previously about the build speed, etc. - Kapil Arya On Aug. 22, 2015, 2:10 a.m., haosdent huang wrote

Re: Review Request 36026: Fixed typo in slave flags.

2015-06-29 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89819 --- Ship it! Ship It! - Kapil Arya On June 29, 2015, 7:03 p.m

Review Request 36021: Disabled flaky HookTest::VerifySlaveLaunchExecutorHook test.

2015-06-29 Thread Kapil Arya
/r/36021/diff/ Testing --- Thanks, Kapil Arya

Re: Review Request 36026: Fixed typo in slave flags.

2015-06-29 Thread Kapil Arya
/#comment142611 s/that // or s/that the/ that of the/ - Kapil Arya On June 29, 2015, 6:56 p.m., Brendan Chang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026

Re: Review Request 36867: Add labels to FrameworkInfo.

2015-07-28 Thread Kapil Arya
` declaration inside the `if` block as well. - Kapil Arya On July 27, 2015, 9:25 p.m., Neil Conway wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36867

Re: Review Request 32587: Stopped using RunTaskMessage.framework_id.

2015-07-28 Thread Kapil Arya
://reviews.apache.org/r/32587/diff/ Testing --- make check TODO: Test for upgrade path. Thanks, Kapil Arya

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2015-08-01 Thread Kapil Arya
(updated) --- make check. Thanks, Kapil Arya

Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Kapil Arya
. Thanks, Kapil Arya

Re: Review Request 32587: Stopped using RunTaskMessage.framework_id.

2015-07-28 Thread Kapil Arya
f3b731542f9db4f966970ecb2bb96eb828350dea Diff: https://reviews.apache.org/r/32587/diff/ Testing (updated) --- make check Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with 0.23.0 and the current master to verify compatibility checks. Thanks, Kapil Arya

Re: Review Request 32587: Stopped using RunTaskMessage.framework_id.

2015-07-28 Thread Kapil Arya
://reviews.apache.org/r/32587/diff/ Testing --- make check Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with 0.23.0 and the current master to verify compatibility checks. Thanks, Kapil Arya

Re: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.

2015-07-28 Thread Kapil Arya
51a4db17d13dd8dbff6a5eb2ceabee269275f6f6 src/tests/containerizer/port_mapping_tests.cpp 778dc8cdfee1fd4098a6332b9219764527cd7b59 Diff: https://reviews.apache.org/r/36831/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.

2015-07-28 Thread Kapil Arya
51a4db17d13dd8dbff6a5eb2ceabee269275f6f6 src/tests/containerizer/port_mapping_tests.cpp 778dc8cdfee1fd4098a6332b9219764527cd7b59 Diff: https://reviews.apache.org/r/36831/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Kapil Arya
, 2015, 5:45 a.m.) Review request for mesos, Bernd Mathiske, Kapil Arya, Marco Massenzio, and Sebastien Pahl. Bugs: MESOS-2337 https://issues.apache.org/jira/browse/MESOS-2337 Repository: mesos Description --- Let __init__.py getting installed to $PREFIX/lib/pythonX.Y

Re: Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

2015-08-05 Thread Kapil Arya
/ Testing --- make check with a couple of added checks that verify that the executor_id is set in the incoming TaskStatus in Master as well as Scheduler. Thanks, Kapil Arya

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-03 Thread Kapil Arya
} file be placed inside `include/mesos/master/` instead since the authorizer is only for the master. Does it make sense to do that? If it does, then should we also move src/authorize inside src/master? - Kapil Arya On Aug. 3, 2015, 5:47 a.m., Alexander Rojas wrote

Re: Review Request 32587: Stopped using RunTaskMessage.framework_id.

2015-07-30 Thread Kapil Arya
f3b731542f9db4f966970ecb2bb96eb828350dea Diff: https://reviews.apache.org/r/32587/diff/ Testing --- make check Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with 0.23.0 and the current master to verify compatibility checks. Thanks, Kapil Arya

Re: Review Request 32587: Stopped using RunTaskMessage.framework_id.

2015-07-30 Thread Kapil Arya
f3b731542f9db4f966970ecb2bb96eb828350dea Diff: https://reviews.apache.org/r/32587/diff/ Testing --- make check Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with 0.23.0 and the current master to verify compatibility checks. Thanks, Kapil Arya

Re: Review Request 32587: Stopped using RunTaskMessage.framework_id.

2015-07-30 Thread Kapil Arya
/32587/#review93560 --- On July 30, 2015, 12:18 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32587

Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.

2015-08-07 Thread Kapil Arya
8153ce4826f94d5771c93d37c59fdc4991352e66 src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 Diff: https://reviews.apache.org/r/37228/diff/ Testing --- make check. Thanks, Kapil Arya

Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

2015-08-04 Thread Kapil Arya
/tests/scheduler_tests.cpp 98fc70bf43ba99b54064a236795c7e1269004b71 Diff: https://reviews.apache.org/r/37053/diff/ Testing --- make check with a couple of added checks that verify that the executor_id is set in the incoming TaskStatus in Master as well as Scheduler. Thanks, Kapil Arya

Re: Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

2015-08-04 Thread Kapil Arya
as well as Scheduler. Thanks, Kapil Arya

Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.

2015-08-07 Thread Kapil Arya
f181b1b23cec57a9cce6311127f733f17fbd87e4 Diff: https://reviews.apache.org/r/37228/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-13 Thread Kapil Arya
` here as well? - Kapil Arya On Aug. 7, 2015, 11:08 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819

Re: Review Request 37443: Add labels to FrameworkInfo (v2)

2015-08-13 Thread Kapil Arya
/#comment150215 Indent by four spaces. - Kapil Arya On Aug. 13, 2015, 3:50 p.m., James DeFelice wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443

Re: Review Request 37443: Add labels to FrameworkInfo (v2)

2015-08-13 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37443/#review95325 --- Ship it! Ship It! - Kapil Arya On Aug. 13, 2015, 4:20 p.m

Re: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.

2015-07-27 Thread Kapil Arya
59f08c0c175ea800ba23d85666d20b6a7b6d07d6 src/tests/containerizer/port_mapping_tests.cpp 45ef97a4822edacd2c2964e63ec624fe4190b3b9 Diff: https://reviews.apache.org/r/36831/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.

2015-07-27 Thread Kapil Arya
, Kapil Arya

Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

2015-07-27 Thread Kapil Arya
Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya

Re: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.

2015-07-27 Thread Kapil Arya
59f08c0c175ea800ba23d85666d20b6a7b6d07d6 src/tests/containerizer/port_mapping_tests.cpp 45ef97a4822edacd2c2964e63ec624fe4190b3b9 Diff: https://reviews.apache.org/r/36831/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 36867: Add labels to FrameworkInfo.

2015-07-27 Thread Kapil Arya
labels? You can find the example in MasterTest.TaskLabels test in master_tests.cpp. - Kapil Arya On July 27, 2015, 9:25 p.m., Neil Conway wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

2015-07-23 Thread Kapil Arya
. Diffs - src/slave/containerizer/mesos/containerizer.cpp 609620c4322e41562597ee682b311cd320bca6d2 src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya

Review Request 36754: Updated Isolator::prepare to return IsolatorPrepareInfo.

2015-07-23 Thread Kapil Arya
with an added test (in the followup review). Thanks, Kapil Arya

Re: Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

2015-07-23 Thread Kapil Arya
/containerizer.cpp 609620c4322e41562597ee682b311cd320bca6d2 src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db src/tests/isolator.hpp fd6aec74edf49153d31b559d56e8e06c15836f68 Diff: https://reviews.apache.org/r/36718/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 36754: Updated Isolator::prepare to return ContainerPrepareInfo.

2015-07-26 Thread Kapil Arya
, Kapil Arya

Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.

2015-07-26 Thread Kapil Arya
, Kapil Arya

Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

2015-07-26 Thread Kapil Arya
://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya

Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.

2015-07-26 Thread Kapil Arya
a44b6e887c37e55213db068a95ab3e73a033e1ea src/tests/containerizer/isolator_tests.cpp 59f08c0c175ea800ba23d85666d20b6a7b6d07d6 Diff: https://reviews.apache.org/r/36831/diff/ Testing --- make check. Thanks, Kapil Arya

Re: Review Request 36574: Added a helper testing functions for Labels.

2015-07-21 Thread Kapil Arya
/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901 Diff: https://reviews.apache.org/r/36574/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 36575: Added Labels to TaskStatus protobuf and expose them via state.json.

2015-07-21 Thread Kapil Arya
, Kapil Arya

Re: Review Request 36585: Exposed docker container IP via state.json

2015-07-21 Thread Kapil Arya
src/tests/docker_containerizer_tests.cpp 6c6f4b7f30cec9b5bba77234b714e96289c82b43 Diff: https://reviews.apache.org/r/36585/diff/ Testing --- sudo make check Thanks, Kapil Arya

Re: Review Request 36580: Added TaskStatus label decorator hook for Slave

2015-07-21 Thread Kapil Arya
/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4 src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db Diff: https://reviews.apache.org/r/36580/diff/ Testing --- make check with a new hook test. Thanks, Kapil

Re: Review Request 36669: Fixed the order of expected value in EXPECT_EQ.

2015-07-21 Thread Kapil Arya
330a95b9a19353029f5b8215d5df735818626218 Diff: https://reviews.apache.org/r/36669/diff/ Testing --- make check Thanks, Kapil Arya

Review Request 36669: Fixed the order of expected value in EXPECT_EQ.

2015-07-21 Thread Kapil Arya
://reviews.apache.org/r/36669/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

2015-07-24 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36763/#review92933 --- Ship it! Ship It! - Kapil Arya On July 24, 2015, 1:26 p.m., Jie

Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.

2015-07-24 Thread Kapil Arya
8aaf88c3ea8362950e363d15cbe2b598a12f12d6 src/tests/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5 Diff: https://reviews.apache.org/r/36799/diff/ Testing --- make check Thanks, Kapil Arya

Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

2015-07-24 Thread Kapil Arya
check with an added test. Thanks, Kapil Arya

Re: Review Request 36754: Updated Isolator::prepare to return ContainerPrepareInfo.

2015-07-24 Thread Kapil Arya
/r/36754/diff/ Testing --- make check with an added test (in the followup review). Thanks, Kapil Arya

  1   2   3   4   5   6   7   8   >