---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29947/#review83786
---
On May 13, 2015, 4:36 p.m., Kapil Arya wrote:
---
This is an automatically generated e
for the hook to
complete without worrying about the master/slave/framework shutting down in
the meantime.
Kapil Arya wrote:
I haven't considered the explicit message. I will try to find a prior
example and adjust accordingly.
Since we have already decoupled shutdown with successful
, 2015, 4:36 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29947/
---
(Updated May 13, 2015, 4:36 p.m
98d859f3db6013a2e155d838f590a0cde6dc5ed5
src/tests/hook_tests.cpp a65c0ab7c41ec3b7964f9d572381fa3e61746dc3
Diff: https://reviews.apache.org/r/29947/diff/
Testing
---
make check
Thanks,
Kapil Arya
by __linux__.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/#review88442
---
On June 22, 2015, 1:56 p.m., Kapil Arya wrote
---
make check
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35774/#review88990
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:26 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35775/#review88991
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35131/#review88980
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:26 a.m
this header here? There is no other change in the file.
src/slave/state.hpp (lines 130 - 131)
https://reviews.apache.org/r/34260/#comment141580
I think this will fit on one line :-).
- Kapil Arya
On June 23, 2015, 4:26 a.m., Till Toenshoff wrote
/35766/?
- Kapil Arya
On June 22, 2015, 10:39 p.m., Roger Ignazio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35763
(lines 40 - 52)
https://reviews.apache.org/r/34256/#comment141577
It probably applies to the Class itself, but should we also be testing for
repeated middle slashes like /a//b/c//d/? Or is it beyond the scope of Path
class?
- Kapil Arya
On June 23, 2015, 4:26 a.m., Till Toenshoff wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34259/#review88981
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 4:26 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88972
---
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 3:17 a.m
Diff: https://reviews.apache.org/r/35756/diff/
Testing
---
make check.
Thanks,
Kapil Arya
---
On June 23, 2015, 5:47 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35756/
---
(Updated June 23, 2015, 5
, the LDFLAGS options
isn't needed.
Thanks,
Kapil Arya
the differentiation between
`#include stout/os.hpp` and `#include os.hpp`?
- Kapil Arya
On June 25, 2015, 5:58 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35917/#review89476
---
Ship it!
Ship It!
- Kapil Arya
On June 26, 2015, 3:47 a.m
563e9c529444b3e980db6d04173f0d016a737c74
Diff: https://reviews.apache.org/r/35762/diff/
Testing
---
Tested by running configure check with 3.2.25 and 3.2.26.
Thanks,
Kapil Arya
check with 3.2.25 and 3.2.26.
Thanks,
Kapil Arya
://issues.apache.org/jira/browse/MESOS-2917
Repository: mesos
Description
---
The correct libnl required version is = 3.2.26.
Diffs
-
docs/network-monitoring.md ac36ba3aa9afda9231de634157a2c083988e7e22
Diff: https://reviews.apache.org/r/35765/diff/
Testing
---
Thanks,
Kapil Arya
/diff/
Testing
---
make check
Thanks,
Kapil Arya
8c102fb7d1f79ee768cb06de3a976ea12f958712
src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1
Diff: https://reviews.apache.org/r/35586/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35585/#review88902
---
On June 22, 2015, 10:48 p.m., Kapil Arya wrote:
---
This is an automatically generated e
Thanks,
Kapil Arya
-
configure.ac 563e9c529444b3e980db6d04173f0d016a737c74
Diff: https://reviews.apache.org/r/35762/diff/
Testing
---
Tested by running configure check with 3.2.25 and 3.2.26.
Thanks,
Kapil Arya
check
Thanks,
Kapil Arya
://reviews.apache.org/r/35766/diff/
Testing
---
Tested with:
```
../configure --with-network-isolator --with-libnl=/usr/local
LDFLAGS=-L/usr/local/lib64
```
On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options
isn't needed.
Thanks,
Kapil Arya
8c102fb7d1f79ee768cb06de3a976ea12f958712
src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1
src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d
Diff: https://reviews.apache.org/r/35586/diff/
Testing
---
make check
Thanks,
Kapil Arya
)
Failed to synchronize with slave (it's probably exited)
Failed to synchronize with slave (it's probably exited)
thinkpad:/home/kapil/mesos/netns/build-port-mapping #
```
Thanks,
Kapil Arya
options
isn't needed.
Thanks,
Kapil Arya
```
On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options
isn't needed.
Thanks,
Kapil Arya
Diff: https://reviews.apache.org/r/30339/diff/
Testing
---
make check
Thanks,
Kapil Arya
Diff: https://reviews.apache.org/r/35586/diff/
Testing
---
make check
Thanks,
Kapil Arya
3ffde6d6b2faeb5a8a40eb27c3b0a2b7f9ecd2b1
Diff: https://reviews.apache.org/r/30339/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/#review86436
---
On June 15, 2015, 5:22 p.m., Kapil Arya wrote
/30339/diff/
Testing
---
make check
Thanks,
Kapil Arya
271cb03770cd08406054dfce35d0821475e49b05
src/tests/hook_tests.cpp 3ffde6d6b2faeb5a8a40eb27c3b0a2b7f9ecd2b1
Diff: https://reviews.apache.org/r/30339/diff/
Testing
---
make check
Thanks,
Kapil Arya
3ffde6d6b2faeb5a8a40eb27c3b0a2b7f9ecd2b1
Diff: https://reviews.apache.org/r/30339/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/#review86091
---
On June 1, 2015, 5:46 p.m., Kapil Arya wrote:
---
This is an automatically generated
On July 1, 2015, 11:45 a.m., Till Toenshoff wrote:
When trying to apply locally, I get:
```
$ ./support/apply-review.sh 36071
2015-07-01 17:43:28 URL:https://reviews.apache.org/r/36071/diff/raw/
[1338/1338] - 36071.patch [1]
36071.patch:15: new blank line at EOF.
+
error:
/35855/#comment142943
Nice catch. Seems like you've caught as potential segfault (here and below)
:-).
- Kapil Arya
On July 1, 2015, 1:24 a.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
:-).
- Kapil Arya
On June 30, 2015, 9:52 p.m., Isabel Jimenez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36037
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35974/#review89632
---
Ship it!
Ship It!
- Kapil Arya
On June 27, 2015, 3:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36200/#review90490
---
Ship it!
Ship It!
- Kapil Arya
On July 6, 2015, 9:38 a.m
://reviews.apache.org/r/36078/#comment142933
May be I am missing something here, but shouldn't we avoid changing the
numbered tags for the message fields?
This would mean that we should introduce Subscribe as:
`optional Subscribe subscribe = 10'`.
- Kapil Arya
On July 1, 2015, 1
/scheduler/scheduler.proto
https://reviews.apache.org/r/36078/#comment142935
How are we going to allow backwards compatibility. Shouldn't we just mark
framework_info as optional and keep setting it for older Masters?
- Kapil Arya
On July 1, 2015, 1:23 a.m., Vinod Kone wrote
Diff: https://reviews.apache.org/r/37007/diff/
Testing
---
make check.
Thanks,
Kapil Arya
and taskId.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37007/#review93827
---
On Aug. 1, 2015, 12:24 a.m., Kapil Arya wrote
)
https://reviews.apache.org/r/37669/#comment151333
s/version4/version5
- Kapil Arya
On Aug. 22, 2015, 2:10 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669
17)
https://reviews.apache.org/r/37669/#comment151331
Since we are using just `std::min`, can't we simple use an `if` or `?:` to
avoid including this file. There were some concerns previously about the build
speed, etc.
- Kapil Arya
On Aug. 22, 2015, 2:10 a.m., haosdent huang wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026/#review89819
---
Ship it!
Ship It!
- Kapil Arya
On June 29, 2015, 7:03 p.m
/r/36021/diff/
Testing
---
Thanks,
Kapil Arya
/#comment142611
s/that //
or
s/that the/ that of the/
- Kapil Arya
On June 29, 2015, 6:56 p.m., Brendan Chang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36026
` declaration inside the `if`
block as well.
- Kapil Arya
On July 27, 2015, 9:25 p.m., Neil Conway wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867
://reviews.apache.org/r/32587/diff/
Testing
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
(updated)
---
make check.
Thanks,
Kapil Arya
f3b731542f9db4f966970ecb2bb96eb828350dea
Diff: https://reviews.apache.org/r/32587/diff/
Testing (updated)
---
make check
Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with
0.23.0 and the current master to verify compatibility checks.
Thanks,
Kapil Arya
://reviews.apache.org/r/32587/diff/
Testing
---
make check
Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with
0.23.0 and the current master to verify compatibility checks.
Thanks,
Kapil Arya
51a4db17d13dd8dbff6a5eb2ceabee269275f6f6
src/tests/containerizer/port_mapping_tests.cpp
778dc8cdfee1fd4098a6332b9219764527cd7b59
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
51a4db17d13dd8dbff6a5eb2ceabee269275f6f6
src/tests/containerizer/port_mapping_tests.cpp
778dc8cdfee1fd4098a6332b9219764527cd7b59
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
, 2015, 5:45 a.m.)
Review request for mesos, Bernd Mathiske, Kapil Arya, Marco Massenzio, and
Sebastien Pahl.
Bugs: MESOS-2337
https://issues.apache.org/jira/browse/MESOS-2337
Repository: mesos
Description
---
Let __init__.py getting installed to
$PREFIX/lib/pythonX.Y
/
Testing
---
make check with a couple of added checks that verify that the executor_id is
set in the incoming TaskStatus in Master as well as Scheduler.
Thanks,
Kapil Arya
} file be
placed inside `include/mesos/master/` instead since the authorizer is only for
the master. Does it make sense to do that? If it does, then should we also move
src/authorize inside src/master?
- Kapil Arya
On Aug. 3, 2015, 5:47 a.m., Alexander Rojas wrote
f3b731542f9db4f966970ecb2bb96eb828350dea
Diff: https://reviews.apache.org/r/32587/diff/
Testing
---
make check
Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with
0.23.0 and the current master to verify compatibility checks.
Thanks,
Kapil Arya
f3b731542f9db4f966970ecb2bb96eb828350dea
Diff: https://reviews.apache.org/r/32587/diff/
Testing
---
make check
Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with
0.23.0 and the current master to verify compatibility checks.
Thanks,
Kapil Arya
/32587/#review93560
---
On July 30, 2015, 12:18 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32587
8153ce4826f94d5771c93d37c59fdc4991352e66
src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2
src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4
Diff: https://reviews.apache.org/r/37228/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/tests/scheduler_tests.cpp 98fc70bf43ba99b54064a236795c7e1269004b71
Diff: https://reviews.apache.org/r/37053/diff/
Testing
---
make check with a couple of added checks that verify that the executor_id is
set in the incoming TaskStatus in Master as well as Scheduler.
Thanks,
Kapil Arya
f181b1b23cec57a9cce6311127f733f17fbd87e4
Diff: https://reviews.apache.org/r/37228/diff/
Testing
---
make check.
Thanks,
Kapil Arya
` here as well?
- Kapil Arya
On Aug. 7, 2015, 11:08 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819
/#comment150215
Indent by four spaces.
- Kapil Arya
On Aug. 13, 2015, 3:50 p.m., James DeFelice wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95325
---
Ship it!
Ship It!
- Kapil Arya
On Aug. 13, 2015, 4:20 p.m
59f08c0c175ea800ba23d85666d20b6a7b6d07d6
src/tests/containerizer/port_mapping_tests.cpp
45ef97a4822edacd2c2964e63ec624fe4190b3b9
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
,
Kapil Arya
Diff: https://reviews.apache.org/r/36755/diff/
Testing
---
make check with an added test.
Thanks,
Kapil Arya
59f08c0c175ea800ba23d85666d20b6a7b6d07d6
src/tests/containerizer/port_mapping_tests.cpp
45ef97a4822edacd2c2964e63ec624fe4190b3b9
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
labels? You can find the example in MasterTest.TaskLabels test in
master_tests.cpp.
- Kapil Arya
On July 27, 2015, 9:25 p.m., Neil Conway wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
.
Diffs
-
src/slave/containerizer/mesos/containerizer.cpp
609620c4322e41562597ee682b311cd320bca6d2
src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db
Diff: https://reviews.apache.org/r/36755/diff/
Testing
---
make check with an added test.
Thanks,
Kapil Arya
with an added test (in the followup review).
Thanks,
Kapil Arya
/containerizer.cpp
609620c4322e41562597ee682b311cd320bca6d2
src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db
src/tests/isolator.hpp fd6aec74edf49153d31b559d56e8e06c15836f68
Diff: https://reviews.apache.org/r/36718/diff/
Testing
---
make check
Thanks,
Kapil Arya
,
Kapil Arya
,
Kapil Arya
://reviews.apache.org/r/36755/diff/
Testing
---
make check with an added test.
Thanks,
Kapil Arya
a44b6e887c37e55213db068a95ab3e73a033e1ea
src/tests/containerizer/isolator_tests.cpp
59f08c0c175ea800ba23d85666d20b6a7b6d07d6
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
Diff: https://reviews.apache.org/r/36574/diff/
Testing
---
make check
Thanks,
Kapil Arya
,
Kapil Arya
src/tests/docker_containerizer_tests.cpp
6c6f4b7f30cec9b5bba77234b714e96289c82b43
Diff: https://reviews.apache.org/r/36585/diff/
Testing
---
sudo make check
Thanks,
Kapil Arya
/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf
src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
Diff: https://reviews.apache.org/r/36580/diff/
Testing
---
make check with a new hook test.
Thanks,
Kapil
330a95b9a19353029f5b8215d5df735818626218
Diff: https://reviews.apache.org/r/36669/diff/
Testing
---
make check
Thanks,
Kapil Arya
://reviews.apache.org/r/36669/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92933
---
Ship it!
Ship It!
- Kapil Arya
On July 24, 2015, 1:26 p.m., Jie
8aaf88c3ea8362950e363d15cbe2b598a12f12d6
src/tests/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5
Diff: https://reviews.apache.org/r/36799/diff/
Testing
---
make check
Thanks,
Kapil Arya
check with an added test.
Thanks,
Kapil Arya
/r/36754/diff/
Testing
---
make check with an added test (in the followup review).
Thanks,
Kapil Arya
790e392645dd62e74b03ff0771f6bf0e9efeb622
src/slave/containerizer/mesos/containerizer.cpp
609620c4322e41562597ee682b311cd320bca6d2
Diff: https://reviews.apache.org/r/36718/diff/
Testing
---
make check
Thanks,
Kapil Arya
8a4e2c2ecddf268e319b6d33da497fafa9f2fc61
src/tests/mesos.hpp f14b8f721e057efbd93dd38263c22b4b4e3881da
src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218
Diff: https://reviews.apache.org/r/36667/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
See summary
Diffs
-
src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61
src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218
Diff: https://reviews.apache.org/r/36668/diff/
Testing
---
make check
Thanks,
Kapil Arya
of TaskInfo/TaskStatus
Labels.
2. There can be multiple hooks for label decoration, so we can't simply
return on `result.isSome()`. We need to accumulate all of those.
- Kapil Arya
On July 21, 2015, 12:46 p.m., Kapil Arya wrote
1 - 100 of 759 matches
Mail list logo
