Re: Review Request 47973: Updated gc to prevent early exit in case of error.

. Tested with option --gtest_also_run_disabled_tests. Thanks, Megha Sharma

Re: Review Request 47972: Updated rmdir to optionally continue deletion on error.

://reviews.apache.org/r/47972/diff/ Testing --- make check. Tested with option --gtest_also_run_disabled_tests. Thanks, Megha Sharma

Re: Review Request 47972: Updated rmdir to optionally continue deletion on error.

eviews.apache.org/r/47972/#review136482 ------- On June 8, 2016, 8:42 p.m., Megha Sharma wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/#review136592 --- On June 8, 2016, 4:57 p.m., Megha Sharma wrote: > > -

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- make check. Thanks, Megha Sharma

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

eedb8ca713d7f5195055bb6417f03ab70731af97 src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 Diff: https://reviews.apache.org/r/47973/diff/ Testing (updated) --- make check. Tested with option --gtest_also_run_disabled_tests. Thanks, Megha Sharma

Re: Review Request 47972: Updated rmdir to continue deletion on error.

check. Tested with option --gtest_also_run_disabled_tests. Thanks, Megha Sharma

Review Request 47973: Updated gc to prevent early exit in case of error.

://reviews.apache.org/r/47973/diff/ Testing --- make check. Thanks, Megha Sharma

Review Request 47972: Updated rmdir to continue deletion on error.

/rmdir.hpp 772b86dd111d28aefbeeba5f829ffa377fd12efb 3rdparty/stout/tests/os/rmdir_tests.cpp a11bfc9f9e6cbb05f3e9ce0ea48297b8f88fe53f Diff: https://reviews.apache.org/r/47972/diff/ Testing --- make check. Thanks, Megha Sharma

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--gtest_also_run_disabled_tests. Thanks, Megha Sharma

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- make check. Tested with option --gtest_also_run_disabled_tests. Thanks, Megha Sharma

Re: Review Request 47972: Updated rmdir to continue deletion on error.

check. Tested with option --gtest_also_run_disabled_tests. Thanks, Megha Sharma

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

-offered to frameworks. Diffs (updated) - src/slave/gc.cpp eedb8ca713d7f5195055bb6417f03ab70731af97 src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 Diff: https://reviews.apache.org/r/47973/diff/ Testing (updated) --- Testing done with 'make check'. Thanks, Megha

Re: Review Request 47972: Updated rmdir to continue deletion on error.

) --- testing done with 'make check'. Thanks, Megha Sharma

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

-offered to frameworks. Diffs (updated) - src/slave/gc.cpp eedb8ca713d7f5195055bb6417f03ab70731af97 src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 Diff: https://reviews.apache.org/r/47973/diff/ Testing --- Testing done with 'make check'. Thanks, Megha Sharma

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- testing done with 'make check'. Thanks, Megha Sharma

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

eedb8ca713d7f5195055bb6417f03ab70731af97 src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 Diff: https://reviews.apache.org/r/47973/diff/ Testing --- make check. Tested with option --gtest_also_run_disabled_tests. Thanks, Megha Sharma

Re: Review Request 47972: Updated rmdir to continue deletion on error.

/stout/tests/os/rmdir_tests.cpp a11bfc9f9e6cbb05f3e9ce0ea48297b8f88fe53f Diff: https://reviews.apache.org/r/47972/diff/ Testing --- make check. Tested with option --gtest_also_run_disabled_tests. Thanks, Megha Sharma

Re: Review Request 50000: Added test to simulate slow/unresponsive fetch.

/tests/slave_tests.cpp 60f9e1644efaeba893f4ff38b6d5a07087d1a355 Diff: https://reviews.apache.org/r/5/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 50000: Added test to simulate slow/unresponsive fetch.

/tests/slave_tests.cpp 60f9e1644efaeba893f4ff38b6d5a07087d1a355 Diff: https://reviews.apache.org/r/5/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

, Megha Sharma

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

on the existence of the file. Diffs (updated) - src/tests/gc_tests.cpp d6335dc711f0697a0728a912e713cf1ed783c146 Diff: https://reviews.apache.org/r/49520/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

on the existence of the file. Diffs - src/tests/gc_tests.cpp d6335dc711f0697a0728a912e713cf1ed783c146 Diff: https://reviews.apache.org/r/49520/diff/ Testing (updated) --- make check on mac os and linux Thanks, Megha Sharma

Review Request 49520: Fixed the flaky BusyMountPoint test.

- src/tests/gc_tests.cpp 2e23f04ea908aadcefb21e11203b95b94ec3c60b Diff: https://reviews.apache.org/r/49520/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

on the existence of the file. Diffs (updated) - src/tests/gc_tests.cpp 2e23f04ea908aadcefb21e11203b95b94ec3c60b Diff: https://reviews.apache.org/r/49520/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

on the existence of the file. Diffs (updated) - src/tests/gc_tests.cpp 2e23f04ea908aadcefb21e11203b95b94ec3c60b Diff: https://reviews.apache.org/r/49520/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 50000: Added test to simulate slow/unresponsive fetch.

/tests/slave_tests.cpp 30ca3da6ca2f1e068bb3f8a6abc7efeebd5bfe8c Diff: https://reviews.apache.org/r/5/diff/ Testing (updated) --- Testing done with make check on linux Thanks, Megha Sharma

Review Request 56895: Allow agents to recover slave state post a reboot.

f8e7cdd4df0a3c5d62d89edd11844527084f2baa src/tests/slave_recovery_tests.cpp 946a7bc4b78f56244633a0b2acb59381e3dbe7e7 Diff: https://reviews.apache.org/r/56895/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

, Megha Sharma

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

) --- make check Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review150485 --- On Sept. 28, 2016, 5:10 p.m., Megha Sharma wrote: > > ---

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

and macos Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Review Request 52058: Fixed fetcher to not call chown on sandbox again.

4d3fc521bf8a7c438c48e31c549f108ac3602b3f src/tests/containerizer/mesos_containerizer_tests.cpp 96e24500a12825161553eb050da389088b122695 Diff: https://reviews.apache.org/r/52058/diff/ Testing --- make check on linux Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

; There isn't always a stdout/stderr file in the sandbox, as this depends > > on the ContainerLogger module. Would non-recursively chown-ing the sandbox > > directory work as well? (This is already done when the agent first creates > > the sandbox.) > > Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

, Megha Sharma

Re: Review Request 53036: Allow agents to recover slave state post a reboot.

/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3 Diff: https://reviews.apache.org/r/53036/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

) - src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc Diff: https://reviews.apache.org/r/52828/diff/ Testing --- Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc Diff: https://reviews.apache.org/r/52828/diff/ Testing (updated) --- make check on macOs and linux Thanks, Megha Sharma

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

Thanks, Megha Sharma

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

) - src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc Diff: https://reviews.apache.org/r/52828/diff/ Testing --- make check on macOs and linux Thanks, Megha Sharma

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

since we are chowning so needs a real user. Replaced it with "nobody". - Megha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52828/#review152606 ----

Re: Review Request 55362: Support asynchronous fetching of URIs.

(updated) - src/launcher/fetcher.cpp 4456c28139966e42859cc6d2c79a1d90e83fb22f Diff: https://reviews.apache.org/r/55362/diff/ Testing --- make check on macOS. Thanks, Megha Sharma

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

/56895/diff/3/ Changes: https://reviews.apache.org/r/56895/diff/2-3/ Testing --- make check Thanks, Megha Sharma

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

here. - Megha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review169215 --- On March 16, 2017, 6:25 p.m., Meg

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

53f33a2b0411c8158326074ce043c7b1dbeef5b4 Diff: https://reviews.apache.org/r/56895/diff/4/ Changes: https://reviews.apache.org/r/56895/diff/3-4/ Testing --- make check Thanks, Megha Sharma

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review180202 --- On July 10, 2017, 11:15 p.m., Megha Sharma wrote: > > -

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

/diff/14-15/ Testing --- make check done together with 60104 and 60103 Thanks, Megha Sharma

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

/diff/13-14/ Testing --- make check done together with 60104 and 60103 Thanks, Megha Sharma

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

/diff/16-17/ Testing --- make check done together with 60104 and 60103 Thanks, Megha Sharma

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

g/r/56895/#review180319 --- On July 13, 2017, 4:22 a.m., Megha Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac Diff: https://reviews.apache.org/r/60925/diff/2/ Changes: https://reviews.apache.org/r/60925/diff/1-2/ Testing --- Thanks, Megha Sharma

Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac Diff: https://reviews.apache.org/r/60925/diff/1/ Testing --- Thanks, Megha Sharma

Re: Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

1b3f2d2d2e630478a8d577eaa6474e3aedc3cb89 docs/upgrades.md dda55f90e2716e805fb145a369fe248cc178f5ac Diff: https://reviews.apache.org/r/60925/diff/2/ Testing --- Testing done, renders correctly. Thanks, Megha Sharma

Review Request 60925: Updated CHANGELOG for changed semantic of recovery.

--- Thanks, Megha Sharma

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

/diff/15-16/ Testing --- make check done together with 60104 and 60103 Thanks, Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

- Megha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178830 --- On June 29, 2017, 11:35 p.m., Megha Sharma wrote: >

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

/slave.cpp f808458849bb9667a91abe18868751d377d36e0c Diff: https://reviews.apache.org/r/60105/diff/9/ Changes: https://reviews.apache.org/r/60105/diff/8-9/ Testing --- make check done together with 60104 and 56895 Thanks, Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

/slave.cpp f808458849bb9667a91abe18868751d377d36e0c Diff: https://reviews.apache.org/r/60105/diff/10/ Changes: https://reviews.apache.org/r/60105/diff/9-10/ Testing --- make check done together with 60104 and 56895 Thanks, Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

eviews.apache.org/r/60105/#review178830 --- On June 29, 2017, 11:35 p.m., Megha Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60105/ > ---

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

/diff/12-13/ Testing --- make check done together with 60104 and 60103 Thanks, Megha Sharma

Re: Review Request 58898: Send task kill for non-Partition Aware frameworks.

d to the users so there is no difference in how these tasks are presented before and after this patch. I will post the patch soon but do let me know what do you think about the approach. - Megha --- This is an au

Re: Review Request 58898: Do not kill non partition aware tasks.

, Megha Sharma

Re: Review Request 58898: Do not kill non partition aware tasks.

hich they have already > received a TASK_LOST. This hopefully won't break any frameworks since it > could have happened in the past with non-strict registry as well and > frameworks should be resilient enough to handle this scenario. > > Let me know if I have missed anything

Re: Review Request 58898: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58898/#review174194 ------- On Aug. 6, 2017, 4:35 a.m., Megha Sharma wrote: > > ---

Re: Review Request 61473: Do not kill non partition aware tasks.

/partition_tests.cpp 62a84f797201ccd18b71490949e3130d2b9c3668 Diff: https://reviews.apache.org/r/61473/diff/2/ Changes: https://reviews.apache.org/r/61473/diff/1-2/ Testing --- make check Thanks, Megha Sharma

Re: Review Request 61473: Do not kill non partition aware tasks.

/partition_tests.cpp 62a84f797201ccd18b71490949e3130d2b9c3668 Diff: https://reviews.apache.org/r/61473/diff/3/ Changes: https://reviews.apache.org/r/61473/diff/2-3/ Testing --- make check Thanks, Megha Sharma

Review Request 61473: Do not kill non partition aware tasks.

62a84f797201ccd18b71490949e3130d2b9c3668 Diff: https://reviews.apache.org/r/61473/diff/1/ Testing --- Thanks, Megha Sharma

Re: Review Request 61473: Do not kill non partition aware tasks.

62a84f797201ccd18b71490949e3130d2b9c3668 Diff: https://reviews.apache.org/r/61473/diff/1/ Testing (updated) --- make check Thanks, Megha Sharma

Re: Review Request 58898: Do not kill non partition aware tasks.

hich they have already > received a TASK_LOST. This hopefully won't break any frameworks since it > could have happened in the past with non-strict registry as well and > frameworks should be resilient enough to handle this scenario. > > Let me know if I have missed anything

Re: Review Request 61473: Do not kill non partition aware tasks.

to handle this scenario. Let me know if I have missed anything - Megha Sharma On Aug. 7, 2017, 6:23 p.m., Megha Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 58898: Send task kill for non-Partition Aware frameworks.

Thanks, Megha Sharma

Re: Review Request 58898: Send task kill for non-Partition Aware frameworks.

ing. Personally, I am in favor of approach 1 as it seems less catastrophic for the frameworks. What do you think? - Megha ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58898/#review174194 ---

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

38502584186793686f78ff5f4e03f36a3bf7ad1c Diff: https://reviews.apache.org/r/56895/diff/7/ Changes: https://reviews.apache.org/r/56895/diff/6-7/ Testing --- make check Thanks, Megha Sharma

Re: Review Request 56895: Allow agents to recover slave state post a reboot.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/#review175852 --- On June 9, 2017, 4:27 a.m., Megha Sharma wrote: > >

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

review for slave recovery improvements after this change is in. - Megha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178388 -------

Re: Review Request 60104: Added rebooted flag to State.

://reviews.apache.org/r/60104/diff/5-6/ Testing (updated) --- Latest make check results pending. Thanks, Megha Sharma

Re: Review Request 60104: Added rebooted flag to State.

tps://reviews.apache.org/r/60104/#comment252712> If this line is moved to 60105 then this patch will be independently mergeable. - Megha Sharma On June 21, 2017, 11:32 p.m., Megha Sharma wrote: > > --- > This is an automatica

Re: Review Request 60105: Added helper method recoverSlaveState.

> > > > > https://github.com/apache/mesos/blob/3bea3fcb4eef00ce469ba4f27fcfd2d3eec05aea/src/slave/paths.cpp#L621-L622 Good Point, removed - Megha --- This is an automatically generated e-mail. To reply, visit: https:/

Re: Review Request 60105: Added helper method recoverSlaveState.

/slave/slave.cpp f808458849bb9667a91abe18868751d377d36e0c Diff: https://reviews.apache.org/r/60105/diff/4/ Changes: https://reviews.apache.org/r/60105/diff/3-4/ Testing --- Thanks, Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

pending. Thanks, Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

f808458849bb9667a91abe18868751d377d36e0c Diff: https://reviews.apache.org/r/60105/diff/5/ Testing (updated) --- make check done together with 60104 and 56895 Thanks, Megha Sharma

Re: Review Request 60104: Added rebooted flag to State.

src/slave/state.hpp 537358cb54393dd02b655050c26504808a1505ad src/slave/state.cpp 5dd8b1cc29cf1809e948015e146691596a8202b8 Diff: https://reviews.apache.org/r/60104/diff/6/ Testing (updated) --- make check done together with 60105 and 56895 Thanks, Megha Sharma

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

/56895/diff/9-10/ Testing (updated) --- make check done together with 60104 and 60103 Thanks, Megha Sharma

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

/diff/11-12/ Testing --- make check done together with 60104 and 60103 Thanks, Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

eviews.apache.org/r/60105/#review178750 --- On June 23, 2017, 9:30 p.m., Megha Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60105/ > ---

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

``` > > > > What do you think? Feel free to improve on it. +1, good and concise explanation about the changed behavior. - Megha --- This is an automatically generated e-mail. To reply, visit: https://reviews.a

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

/slave.cpp f808458849bb9667a91abe18868751d377d36e0c Diff: https://reviews.apache.org/r/60105/diff/8/ Changes: https://reviews.apache.org/r/60105/diff/7-8/ Testing --- make check done together with 60104 and 56895 Thanks, Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

/slave.cpp f808458849bb9667a91abe18868751d377d36e0c Diff: https://reviews.apache.org/r/60105/diff/6/ Changes: https://reviews.apache.org/r/60105/diff/5-6/ Testing --- make check done together with 60104 and 56895 Thanks, Megha Sharma

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

sion. - Megha --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60105/#review178388 --- On June 22, 2017, 11:38 p.m., Meg

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

nce we > > are donig refactor here, we should probably address this (in a separate > > preceding review perhaps) > > Megha Sharma wrote: > I strongly agree we should defer doing this work until we start to > recover the frameworks. I was thinking of doing this may be as another review

Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.

/slave.cpp f808458849bb9667a91abe18868751d377d36e0c Diff: https://reviews.apache.org/r/60105/diff/7/ Changes: https://reviews.apache.org/r/60105/diff/6-7/ Testing --- make check done together with 60104 and 56895 Thanks, Megha Sharma

  1   2   >