Review Request 37562: The revocable resource information also are missed for slave node in monitoring doc , fix it in this patch.

2015-08-17 Thread Yong Qiao Wang
/ Testing --- Thanks, Yong Qiao Wang

Review Request 37518: Add the revocable metrics information in monitoring doc

2015-08-17 Thread Yong Qiao Wang
the revocable metrics information in monitoring doc Diffs - docs/monitoring.md d80f9362b33fec307eaaf93398631e6b2d02678f Diff: https://reviews.apache.org/r/37518/diff/ Testing --- Thanks, Yong Qiao Wang

Re: Review Request 37518: Add the revocable metrics information in monitoring doc

2015-08-17 Thread Yong Qiao Wang
/ Testing --- Thanks, Yong Qiao Wang

Re: Review Request 37179: Enhance the bootstrap script

2015-08-06 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37179/#review94385 --- Ship it! Ship It! - Yong Qiao Wang On Aug. 6, 2015, 9:28 a.m

Review Request 37208: Fix the spell error in help message of slave component.

2015-08-07 Thread Yong Qiao Wang
://issues.apache.org/jira/browse/MESOS-3228 Repository: mesos Description --- Fix the spell error in help message of slave component. Diffs - src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e Diff: https://reviews.apache.org/r/37208/diff/ Testing --- Thanks, Yong Qiao

Review Request 39754: Set the UUID of the expected ACK.

2015-10-29 Thread Yong Qiao Wang
://issues.apache.org/jira/browse/MESOS-2864 Repository: mesos Description --- Set the UUID of the expected ACK. Diffs - src/master/master.cpp 9f4586e668a2141f4937497d42853fbdea7751a5 Diff: https://reviews.apache.org/r/39754/diff/ Testing --- Thanks, Yong Qiao Wang

Re: Review Request 39754: Set the UUID of the expected ACK.

2015-10-29 Thread Yong Qiao Wang
) --- Make & Make check succesfully! Thanks, Yong Qiao Wang

Re: Review Request 39754: Set the UUID of the expected ACK.

2015-10-29 Thread Yong Qiao Wang
thanks! - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39754/#review104449 --- On 十月 29, 2015, 12:25 p.m.,

Review Request 39516: Slave should accept PingSlaveMessage but not "PING" message.

2015-10-21 Thread Yong Qiao Wang
src/slave/slave.cpp 652697688fd9e9a6d064ef01fb032393412307b3 Diff: https://reviews.apache.org/r/39516/diff/ Testing --- Make Successfully; Make check Successfully; Thanks, Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-10-15 Thread Yong Qiao Wang
://reviews.apache.org/r/38051/diff/ Testing --- UT: 1. Write a test for this change. 2. make successfully! 3. make check successfully! 4. Run test framework successfully! Thanks, Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-10-15 Thread Yong Qiao Wang
://reviews.apache.org/r/38051/diff/ Testing --- UT: 1. Write a test for this change. 2. make successfully! 3. make check successfully! 4. Run test framework successfully! Thanks, Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-10-15 Thread Yong Qiao Wang
.apache.org/r/38051/#review102731 --- On 十月 16, 2015, 2:36 a.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-17 Thread Yong Qiao Wang
://reviews.apache.org/r/40424/diff/ Testing --- Test results: $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Review Request 37784: Remove the redundant check in HierarchicalDRFAlocator.

2015-08-25 Thread Yong Qiao Wang
, Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-05 Thread Yong Qiao Wang
ted the changes by your usful comments. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review97790 ------

Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
://reviews.apache.org/r/38145/diff/ Testing --- Thanks, Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-05 Thread Yong Qiao Wang
) --- UT: 1. make successfully! 2. make check successfully! 3. Run test framework successfully! Thanks, Yong Qiao Wang

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
oad_5min": 0.26, "system/mem_free_bytes": 1120411648, "system/mem_total_bytes": 5071130624 } Thanks, Yong Qiao Wang

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
l update the order in the updated code diff. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97857 --- On 九月 5,

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
n": 0.57, "system/load_1min": 0, "system/load_5min": 0.26, "system/mem_free_bytes": 1120411648, "system/mem_total_bytes": 5071130624 } Thanks, Yong Qiao Wang

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
of you. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97867 --- On 九月 5, 2015, 11:41 p.m.,

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

2015-09-08 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review98142 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:33 p.m

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-08 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review98143 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

2015-09-08 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/#review98144 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-03 Thread Yong Qiao Wang
8050/diff/ Testing --- Test2: Start master and slave to debug the PingSlaveMessage. Passed! Test1: Run make check successfully! Thanks, Yong Qiao Wang

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-03 Thread Yong Qiao Wang
ests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c Diff: https://reviews.apache.org/r/38050/diff/ Testing (updated) --- Test2: Start master and slave to debug the PingSlaveMessage. Passed! Test1: Run make check successfully! Thanks, Yong Qiao Wang

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-03 Thread Yong Qiao Wang
e_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c Diff: https://reviews.apache.org/r/38050/diff/ Testing --- Test2: Start master and slave to debug the PingSlaveMessage. Passed! Test1: Run make check successfully! Thanks, Yong Qiao Wang

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-03 Thread Yong Qiao Wang
ted e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97641 --- On 九月 3, 2015, 7:46 a.m., Yong Qiao Wang wrote: > > --- > This is an

Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-02 Thread Yong Qiao Wang
, Yong Qiao Wang

Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-02 Thread Yong Qiao Wang
rc/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 src/slave/slave.hpp 09172f7ed547049b3bd169b3db9be94e14f6bc39 src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 Diff: https://reviews.apache.org/r/38050/diff/ Testing ------- Thanks, Yong Qiao Wang

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-02 Thread Yong Qiao Wang
g/r/38050/#review97434 --- On 九月 2, 2015, 2:16 p.m., Yong Qiao Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-02 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97452 --- Ship it! Ship It! - Yong Qiao Wang On 八月 30, 2015, 8:45 a.m

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-02 Thread Yong Qiao Wang
2b5382c src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c Diff: https://reviews.apache.org/r/38050/diff/ Testing ------- Thanks, Yong Qiao Wang

Re: Review Request 38050: Master should send PingSlaveMessage instead of "PING"; Slave should accept PingSlaveMessage but not "PING" message;

2015-09-03 Thread Yong Qiao Wang
lly! Thanks, Yong Qiao Wang

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

2015-09-10 Thread Yong Qiao Wang
251/#comment154867> If the frameworkInfo.id()and framework->pid do not changed when reregister, then it does not need to call slave to update framework pid. This "return" can gurad this, so this return does not be removed. - Yong Qiao Wang On Sept. 10, 2015, 10:12 a.m.

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

2015-09-09 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review98186 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-09-09 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review98187 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-15 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99153 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 15, 2015, 11 p.m

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-15 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review99152 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 6, 2015, 2:40 a.m

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-18 Thread Yong Qiao Wang
--- UT: 1. make successfully! 2. make check successfully! 3. Run test framework successfully! Thanks, Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-18 Thread Yong Qiao Wang
Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review99453 --- On Sept. 18, 2015, 7:15 a.m., Yong Qiao W

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-21 Thread Yong Qiao Wang
> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? > > Yong Qiao Wang wrote: > I find the code changes in this patch does not be tested with an > end-to-end case except to check the error log messages of master, so my test > stra

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-24 Thread Yong Qiao Wang
://reviews.apache.org/r/38051/diff/ Testing (updated) --- UT: 1. Write a test for this change. 2. make successfully! 3. make check successfully! 4. Run test framework successfully! Thanks, Yong Qiao Wang

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-24 Thread Yong Qiao Wang
> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote: > > Can you write a test for this? > > Yong Qiao Wang wrote: > I find the code changes in this patch does not be tested with an > end-to-end case except to check the error log messages of master, so my test > stra

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-24 Thread Yong Qiao Wang
: https://reviews.apache.org/r/38051/diff/ Testing --- UT: 1. make successfully! 2. make check successfully! 3. Run test framework successfully! Thanks, Yong Qiao Wang

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Yong Qiao Wang
tps://reviews.apache.org/r/41075/#comment168754> When allocator initialize, their should be no active frameworks in mesos, can we consider to remove this parmeter from initialize()? and can initialize role-related information in addFramework(). - Yong Qiao Wang On Dec. 8, 2015, 5:41 a.m., Neil

Re: Review Request 41075: Added support for implicit roles.

2015-12-07 Thread Yong Qiao Wang
> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > I have talked with our shepherd Adam B yesterday, and we all agree to improve /roles endpoint to update/remove/list active roles, and Implicit Roles will focus on removing the static role list(specified by --roles flag

Re: Review Request 41075: Added support for implicit roles.

2015-12-08 Thread Yong Qiao Wang
luster operator to remove this quota, I think it is does not make sence and have a bad user experience, because role is implicitly removed when the last framework gone without notify the clsuter admin. - Yong Qiao Wang On Dec. 8, 2015, 8:33 a.m., Neil Conway

Re: Review Request 41075: Added support for implicit roles.

2015-12-08 Thread Yong Qiao Wang
> On Dec. 8, 2015, 7:02 a.m., Yong Qiao Wang wrote: > > > > Yong Qiao Wang wrote: > I have talked with our shepherd Adam B yesterday, and we all agree to > improve /roles endpoint to update/remove/list active roles, and Implicit > Roles will focus on remov

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-07 Thread Yong Qiao Wang
. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-07 Thread Yong Qiao Wang
; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Yong Qiao Wang
c7670525765491fe931a4ee38446fa7e9d79af42 Diff: https://reviews.apache.org/r/40469/diff/ Testing --- Make check successfully. Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-07 Thread Yong Qiao Wang
. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-12-07 Thread Yong Qiao Wang
c7670525765491fe931a4ee38446fa7e9d79af42 Diff: https://reviews.apache.org/r/40469/diff/ Testing --- Make check successfully. Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-07 Thread Yong Qiao Wang
. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40995: Added test cases for role behavior.

2015-12-07 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review109278 --- Ship it! Ship It! - Yong Qiao Wang On Dec. 7, 2015, 9:22 p.m

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-12-10 Thread Yong Qiao Wang
define proto message in registry.proto which only contians the metadata should be persisted. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review109704 -----

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-24 Thread Yong Qiao Wang
--- 1. Make Check successfully; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-24 Thread Yong Qiao Wang
ot;infos":{"name":"cc","weight":1.0}}]} $ curl http://127.0.0.1:5050/roles/aa {"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type ":"SCALAR"}]}]} $ curl http://127.0.0.1:5050/roles/dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-26 Thread Yong Qiao Wang
--- 1. Make Check successfully; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-26 Thread Yong Qiao Wang
$ curl http://127.0.0.1:5050/roles/aa {"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type ":"SCALAR"}]}]} $ curl http://127.0.0.1:5050/roles/dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-26 Thread Yong Qiao Wang
;role1\",\"weight\":2}" -X POST http://127.0.0.1:5050/roles Failed to validate set role request string: ('role={"name":"role1","weight":2}')': This role already exist! $ curl -X GET http://127.0.0.1:5050/roles/role1 {"status":[{"infos":{"name":"role1","weight":2.0}}]} Thanks, Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-25 Thread Yong Qiao Wang
$ curl http://127.0.0.1:5050/roles/aa {"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type ":"SCALAR"}]}]} $ curl http://127.0.0.1:5050/roles/dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-25 Thread Yong Qiao Wang
--- 1. Make Check successfully; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-25 Thread Yong Qiao Wang
--- 1. Make Check successfully; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-25 Thread Yong Qiao Wang
ing: ('role={"name":"role1","weight":2}')': This role already exist! $ curl -X GET http://127.0.0.1:5050/roles/role1 {"status":[{"infos":{"name":"role1","weight":2.0}}]} Thanks, Yong Qiao Wang

Re: Review Request 40697: Enhance endpoint /roles for adding a new role

2015-11-25 Thread Yong Qiao Wang
",\"weight\":2}" -X POST http://127.0.0.1:5050/roles Failed to validate set role request string: ('role={"name":"role1","weight":2}')': This role already exist! $ curl -X GET http://127.0.0.1:5050/roles/role1 {"status":[{"infos":{"name":"role1","weight":2.0}}]} Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-25 Thread Yong Qiao Wang
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review107903 --- On Nov. 25, 2015, 8:38 a.m., Yong Qiao Wang wrote: > > -

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-29 Thread Yong Qiao Wang
--- 1. Make Check successfully; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-29 Thread Yong Qiao Wang
; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-29 Thread Yong Qiao Wang
ight":1.0}}]} $ curl http://127.0.0.1:5050/roles/aa {"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type ":"SCALAR"}]}]} $ curl http://127.0.0.1:5050/roles/dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-29 Thread Yong Qiao Wang
; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-18 Thread Yong Qiao Wang
e":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-18 Thread Yong Qiao Wang
roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-18 Thread Yong Qiao Wang
64ccf4164197e59d93d739fa2afbdee2cc2a1d23 src/master/allocator/mesos/hierarchical.cpp f2e3b639f210eb06c70584ee7294609d9fd978ad src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 Diff: https://reviews.apache.org/r/40469/diff/ Testing --- Thanks, Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-18 Thread Yong Qiao Wang
Diff: https://reviews.apache.org/r/40469/diff/ Testing (updated) --- Make check successfully. Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-19 Thread Yong Qiao Wang
/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40469: Update Allocator interface to support dynamic roles

2015-11-19 Thread Yong Qiao Wang
e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 Diff: https://reviews.apache.org/r/40469/diff/ Testing --- Make check successfully. Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-19 Thread Yong Qiao Wang
/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-23 Thread Yong Qiao Wang
1c4f1406f5d917f5d655a7d61d311365f8999ce0 Diff: https://reviews.apache.org/r/40424/diff/ Testing --- Test results: $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

2015-11-23 Thread Yong Qiao Wang
. - Yong Qiao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107709 --- On Nov. 24, 2015, 5:17 a.m., Yong

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-23 Thread Yong Qiao Wang
uot;:0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} $ curl http://127.0.0.1:5050/roles?roleName=aa {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} $ curl http://127.0.0.1:5050/roles?roleName=dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

2015-11-23 Thread Yong Qiao Wang
ot;frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} $ curl http://127.0.0.1:5050/roles?roleName=aa {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} $ curl http://127.0.0.1:5050/roles?roleName=dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-23 Thread Yong Qiao Wang
uot;:0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} $ curl http://127.0.0.1:5050/roles?roleName=aa {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} $ curl http://127.0.0.1:5050/roles?roleName=dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang

Re: Review Request 40431: Move RoleInfo message out of allocator.proto

2015-11-23 Thread Yong Qiao Wang
--- 1. Make Check successfully; 2. $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-23 Thread Yong Qiao Wang
uot;:0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} $ curl http://127.0.0.1:5050/roles?roleName=aa {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} $ curl http://127.0.0.1:5050/roles?roleName=dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang

Re: Review Request 40424: Enhance the existing HTTP endpoint /roles

2015-11-23 Thread Yong Qiao Wang
1c4f1406f5d917f5d655a7d61d311365f8999ce0 Diff: https://reviews.apache.org/r/40424/diff/ Testing --- Test results: $ curl http://9.110.48.168:5050/roles {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} Thanks, Yong Qiao Wang

Re: Review Request 40424: [WIP] ]Enhance the existing HTTP endpoint /roles

2015-11-24 Thread Yong Qiao Wang
ight":1.0}}]} $ curl http://127.0.0.1:5050/roles/aa {"status":[{"framework_id":[{"value":"f1e1af59-9468-4ff0-8fb4-96825d86b6d7-0305"}],"infos":{"name":"bb","weight":1.0},"resource s":[{"name":"cpus","role":"bb","scalar":{"value":5.0},"type":"SCALAR"},{"name":"mem","role":"bb","scalar":{"value":640.0},"type ":"SCALAR"}]}]} $ curl http://127.0.0.1:5050/roles/dd The specified role [dd] does not exist! Thanks, Yong Qiao Wang