Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review90769 --- Patch looks great! Reviews applied: [35986] All tests passed. - M

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 7:07 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 6:33 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 6:26 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

> On July 7, 2015, 1:30 a.m., Adam B wrote: > > src/common/attributes.cpp, lines 150-152 > > > > > > There's a subtle difference in behavior between strings::tokenize and > > strings::split. For tokenize, "Empty token

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review90741 --- Ship it! Looks great! Fix the log message and I'll commit it. src

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 5:55 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/ --- (Updated July 7, 2015, 5:46 p.m.) Review request for mesos, Adam B and Isabel J

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review90623 --- Very good, but there are some subtleties that we should not ignore r

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review89695 --- Ship it! Ship It! - Isabel Jimenez On June 28, 2015, 1:49 p.m.,

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review89676 --- Patch looks great! Reviews applied: [35986] All tests passed. - M