Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
On July 16, 2015, 7:41 p.m., Joerg Schad wrote: src/launcher/fetcher.cpp, line 134 https://reviews.apache.org/r/36547/diff/3/?file=1013405#file1013405line134 I assume those are spaces? Could you please doublecheck? These are spaces. It's probably like this to indicate that the

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/ --- (Updated July 17, 2015, 10:32 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
On July 17, 2015, 4:59 a.m., Adam B wrote: src/launcher/fetcher.cpp, lines 127-128 https://reviews.apache.org/r/36547/diff/3/?file=1013405#file1013405line127 Why not just check for any 2xx code then? Aren't they all successful in one way or another? HTTP can return 206, which

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/ --- (Updated July 17, 2015, 10:56 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review92046 --- src/launcher/fetcher.cpp (line 126)

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/ --- (Updated July 17, 2015, 10:40 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review92042 --- Ship it! Ship It! - Joerg Schad On July 17, 2015, 8:40 a.m.,

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review92045 --- Ship it! Ship It! - Joerg Schad On July 17, 2015, 8:56 a.m.,

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/ --- (Updated July 17, 2015, 11:05 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review92048 --- Ship it! Ship It! - Joerg Schad On July 17, 2015, 9:05 a.m.,

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review92051 --- Patch looks great! Reviews applied: [36547] All tests passed. -

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review92052 --- Ship it! Ship It! - Bernd Mathiske On July 17, 2015, 2:05 a.m.,

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91909 --- Patch looks great! Reviews applied: [36547] All tests passed. -

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91913 --- Ship it! src/launcher/fetcher.cpp (line 134)

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Joerg Schad
On July 16, 2015, 2:37 p.m., Joerg Schad wrote: src/launcher/fetcher.cpp, line 128 https://reviews.apache.org/r/36547/diff/1/?file=1013402#file1013402line128 indentation +2 spaces (https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Conditionals) see line 61 int he

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/ --- (Updated July 16, 2015, 2:48 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91885 --- src/launcher/fetcher.cpp (line 123)

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91891 --- src/launcher/fetcher.cpp (line 135)

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91892 --- Patch looks great! Reviews applied: [36547] All tests passed. -

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review91904 --- Ship it! Ship It! - Bernd Mathiske On July 16, 2015, 9:55 a.m.,

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/ --- (Updated July 16, 2015, 6:55 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36547: Fixed fetcher failing for FTP URIs.

2015-07-16 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36547/#review92015 --- src/launcher/fetcher.cpp (lines 127 - 128)