Re: Review Request 36807: Adding a test for MasterInfo

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---

(Updated July 29, 2015, 9:05 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-2736
https://issues.apache.org/jira/browse/MESOS-2736


Repository: mesos


Description
---

We want to test that when the master gets initialized, the
MasterInfo that it creates (and gets ultimately serialized to
ZooKeeper) has the correct information in its Address field.

Currently, the test hangs when run in after another
MasterZooKeeperTest, due to some issues around the recovery.

Jira: MESOS-2736


Diffs (updated)
-

  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 

Diff: https://reviews.apache.org/r/36807/diff/


Testing
---

make check
(after @vinodkone fix all tests pass)


Thanks,

Marco Massenzio

Re: Review Request 36807: Adding a test for MasterInfo

[Marco Massenzio]

> On July 29, 2015, 8:55 p.m., Vinod Kone wrote:
> > forgot to rebase?

dang! one sec...


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93515
---


On July 29, 2015, 8:54 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36807/
> ---
> 
> (Updated July 29, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We want to test that when the master gets initialized, the
> MasterInfo that it creates (and gets ultimately serialized to
> ZooKeeper) has the correct information in its Address field.
> 
> Currently, the test hangs when run in after another
> MasterZooKeeperTest, due to some issues around the recovery.
> 
> Jira: MESOS-2736
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 7a316bc10575325ffe732fcc87d72d15a4fc5eaf 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
>   src/tests/mesos.hpp 0bbfb1188350ab1fc09cb3d098234347f6dc9203 
> 
> Diff: https://reviews.apache.org/r/36807/diff/
> 
> 
> Testing
> ---
> 
> make check
> (after @vinodkone fix all tests pass)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36807: Adding a test for MasterInfo

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93515
---


forgot to rebase?

- Vinod Kone


On July 29, 2015, 8:54 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36807/
> ---
> 
> (Updated July 29, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We want to test that when the master gets initialized, the
> MasterInfo that it creates (and gets ultimately serialized to
> ZooKeeper) has the correct information in its Address field.
> 
> Currently, the test hangs when run in after another
> MasterZooKeeperTest, due to some issues around the recovery.
> 
> Jira: MESOS-2736
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 7a316bc10575325ffe732fcc87d72d15a4fc5eaf 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
>   src/tests/mesos.hpp 0bbfb1188350ab1fc09cb3d098234347f6dc9203 
> 
> Diff: https://reviews.apache.org/r/36807/diff/
> 
> 
> Testing
> ---
> 
> make check
> (after @vinodkone fix all tests pass)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36807: Adding a test for MasterInfo

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---

(Updated July 29, 2015, 8:54 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-2736
https://issues.apache.org/jira/browse/MESOS-2736


Repository: mesos


Description
---

We want to test that when the master gets initialized, the
MasterInfo that it creates (and gets ultimately serialized to
ZooKeeper) has the correct information in its Address field.

Currently, the test hangs when run in after another
MasterZooKeeperTest, due to some issues around the recovery.

Jira: MESOS-2736


Diffs (updated)
-

  3rdparty/libprocess/src/http.cpp 4dcbd74b894b483c4d166c23fac55ac8dba75166 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
7a316bc10575325ffe732fcc87d72d15a4fc5eaf 
  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
  src/tests/mesos.hpp 0bbfb1188350ab1fc09cb3d098234347f6dc9203 

Diff: https://reviews.apache.org/r/36807/diff/


Testing
---

make check
(after @vinodkone fix all tests pass)


Thanks,

Marco Massenzio

Re: Review Request 36807: Adding a test for MasterInfo

[Marco Massenzio]

> On July 29, 2015, 8 p.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp, line 2170
> > 
> >
> > new line.
> 
> Marco Massenzio wrote:
> would you like me to push another revision or will you do this yourself 
> when committing?
> I'm easy either way, thanks!

actually, never mind - takes me a minute... will post shortly.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93505
---


On July 29, 2015, 5:19 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36807/
> ---
> 
> (Updated July 29, 2015, 5:19 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We want to test that when the master gets initialized, the
> MasterInfo that it creates (and gets ultimately serialized to
> ZooKeeper) has the correct information in its Address field.
> 
> Currently, the test hangs when run in after another
> MasterZooKeeperTest, due to some issues around the recovery.
> 
> Jira: MESOS-2736
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36807/diff/
> 
> 
> Testing
> ---
> 
> make check
> (after @vinodkone fix all tests pass)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36807: Adding a test for MasterInfo

[Marco Massenzio]

> On July 29, 2015, 8 p.m., Vinod Kone wrote:
> > src/tests/master_tests.cpp, line 2170
> > 
> >
> > new line.

would you like me to push another revision or will you do this yourself when 
committing?
I'm easy either way, thanks!


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93505
---


On July 29, 2015, 5:19 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36807/
> ---
> 
> (Updated July 29, 2015, 5:19 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We want to test that when the master gets initialized, the
> MasterInfo that it creates (and gets ultimately serialized to
> ZooKeeper) has the correct information in its Address field.
> 
> Currently, the test hangs when run in after another
> MasterZooKeeperTest, due to some issues around the recovery.
> 
> Jira: MESOS-2736
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36807/diff/
> 
> 
> Testing
> ---
> 
> make check
> (after @vinodkone fix all tests pass)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36807: Adding a test for MasterInfo

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93505
---

Ship it!



src/tests/master_tests.cpp (line 2170)


new line.


- Vinod Kone


On July 29, 2015, 5:19 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36807/
> ---
> 
> (Updated July 29, 2015, 5:19 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We want to test that when the master gets initialized, the
> MasterInfo that it creates (and gets ultimately serialized to
> ZooKeeper) has the correct information in its Address field.
> 
> Currently, the test hangs when run in after another
> MasterZooKeeperTest, due to some issues around the recovery.
> 
> Jira: MESOS-2736
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36807/diff/
> 
> 
> Testing
> ---
> 
> make check
> (after @vinodkone fix all tests pass)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36807: Adding a test for MasterInfo

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---

(Updated July 29, 2015, 5:19 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Anand's comments


Bugs: MESOS-2736
https://issues.apache.org/jira/browse/MESOS-2736


Repository: mesos


Description
---

We want to test that when the master gets initialized, the
MasterInfo that it creates (and gets ultimately serialized to
ZooKeeper) has the correct information in its Address field.

Currently, the test hangs when run in after another
MasterZooKeeperTest, due to some issues around the recovery.

Jira: MESOS-2736


Diffs (updated)
-

  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 

Diff: https://reviews.apache.org/r/36807/diff/


Testing
---

make check
(after @vinodkone fix all tests pass)


Thanks,

Marco Massenzio

Re: Review Request 36807: Adding a test for MasterInfo

[Marco Massenzio]

> On July 29, 2015, 3:12 a.m., Anand Mazumdar wrote:
> > src/tests/master_tests.cpp, line 2145
> > 
> >
> > Can just use auto here ? It's quite self-explanatory.
> > 
> > auto master = master_.get();

why not indeed.


> On July 29, 2015, 3:12 a.m., Anand Mazumdar wrote:
> > src/tests/master_tests.cpp, line 2167
> > 
> >
> > Nit:
> > 
> > s/Protect from flaky failures on those hosts/Protect from failures on 
> > hosts

LoL - did I just invent a new oxymoron?
Thanks for catching it!

(on second thought, it'd be more of a tautology... or a children's book 
character: Mr. Fox Flaky Failures :)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93385
---


On July 29, 2015, 1:01 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36807/
> ---
> 
> (Updated July 29, 2015, 1:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We want to test that when the master gets initialized, the
> MasterInfo that it creates (and gets ultimately serialized to
> ZooKeeper) has the correct information in its Address field.
> 
> Currently, the test hangs when run in after another
> MasterZooKeeperTest, due to some issues around the recovery.
> 
> Jira: MESOS-2736
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36807/diff/
> 
> 
> Testing
> ---
> 
> make check
> (after @vinodkone fix all tests pass)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36807: Adding a test for MasterInfo

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/#review93385
---


LGTM minus some nit comments.


src/tests/master_tests.cpp (line 2134)


Micro nit: Can we rename the test:
s/MasterInfo/MasterInfoAddress

MasterInfo seems too general/non-intuitive to me.



src/tests/master_tests.cpp (line 2136)


I am assuming that Vinod pushed in a fix for them. Can we remove the TODO 
now ?



src/tests/master_tests.cpp (line 2145)


Can just use auto here ? It's quite self-explanatory.

auto master = master_.get();



src/tests/master_tests.cpp (line 2167)


Nit:

s/Protect from flaky failures on those hosts/Protect from failures on hosts


- Anand Mazumdar


On July 29, 2015, 1:01 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36807/
> ---
> 
> (Updated July 29, 2015, 1:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
> https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We want to test that when the master gets initialized, the
> MasterInfo that it creates (and gets ultimately serialized to
> ZooKeeper) has the correct information in its Address field.
> 
> Currently, the test hangs when run in after another
> MasterZooKeeperTest, due to some issues around the recovery.
> 
> Jira: MESOS-2736
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 
> 
> Diff: https://reviews.apache.org/r/36807/diff/
> 
> 
> Testing
> ---
> 
> make check
> (after @vinodkone fix all tests pass)
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 36807: Adding a test for MasterInfo

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36807/
---

(Updated July 29, 2015, 1:01 a.m.)


Review request for mesos and Vinod Kone.


Summary (updated)
-

Adding a test for MasterInfo


Bugs: MESOS-2736
https://issues.apache.org/jira/browse/MESOS-2736


Repository: mesos


Description
---

We want to test that when the master gets initialized, the
MasterInfo that it creates (and gets ultimately serialized to
ZooKeeper) has the correct information in its Address field.

Currently, the test hangs when run in after another
MasterZooKeeperTest, due to some issues around the recovery.

Jira: MESOS-2736


Diffs
-

  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 

Diff: https://reviews.apache.org/r/36807/diff/


Testing (updated)
---

make check
(after @vinodkone fix all tests pass)


Thanks,

Marco Massenzio