Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-08-11 Thread Niklas Nielsen
> On July 27, 2015, 11:36 p.m., Adam B wrote: > > Great first patch. Thanks for updating FrameworkInfo on reregistration with > > the master too! > > A handful of nits in my first pass. I'll take another look once you've > > simplified the tests with Kapil's suggestions. > > Niklas Nielsen wro

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-08-04 Thread Neil Conway
Hi folks, Thanks for the great feedback! I addressed almost all of these issues, but had a few things left to wrap up before uploading a new patch -- I'm traveling at the moment, but I should have a new patch by tomorrow. Neil On Mon, Aug 3, 2015 at 8:45 PM Adam B wrote: > This is an automatical

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-08-03 Thread Adam B
> On July 27, 2015, 11:36 p.m., Adam B wrote: > > Great first patch. Thanks for updating FrameworkInfo on reregistration with > > the master too! > > A handful of nits in my first pass. I'll take another look once you've > > simplified the tests with Kapil's suggestions. > > Niklas Nielsen wro

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-08-03 Thread Niklas Nielsen
> On July 27, 2015, 11:36 p.m., Adam B wrote: > > Great first patch. Thanks for updating FrameworkInfo on reregistration with > > the master too! > > A handful of nits in my first pass. I'll take another look once you've > > simplified the tests with Kapil's suggestions. Any updates here? :)

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-28 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36867/#review93294 --- src/master/http.cpp (line 242)

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36867/#review93242 --- Great first patch. Thanks for updating FrameworkInfo on reregistrati

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36867/#review93225 --- Ni src/tests/fault_tolerance_tests.cpp (lines 1841 - 1844)

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36867/#review93224 --- Patch looks great! Reviews applied: [36867] All tests passed. - M

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36867/ --- (Updated July 28, 2015, 1:25 a.m.) Review request for mesos, Adam B, Connor Doy

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36867/ --- (Updated July 28, 2015, 1:25 a.m.) Review request for mesos, Adam B, Connor Doy

Re: Review Request 36867: Add "labels" to FrameworkInfo.

2015-07-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36867/#review93207 --- Bad patch! Reviews applied: [36867] Failed command: ./support/appl