Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review148876 --- Closing this review as Benjamin has followed up with separate revi

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Nov. 9, 2015, 8:17 p.m.) Review request for mesos, Ben Mahler, Gilbert

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Nov. 5, 2015, 7:32 p.m.) Review request for mesos, Ben Mahler, Gilbert

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Nov. 5, 2015, 4:04 p.m.) Review request for mesos, Ben Mahler, Gilbert

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Nov. 1, 2015, 3:38 p.m.) Review request for mesos, Ben Mahler, Gilbert

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 23, 2015, 4:56 p.m.) Review request for mesos, Ben Mahler, Gilber

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 16, 2015, 1:45 a.m.) Review request for mesos, Ben Mahler, Gilber

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 15, 2015, 9:24 p.m.) Review request for mesos, Ben Mahler, Gilber

Re: Review Request 38747: Adding digest utilities

> On Oct. 13, 2015, 12:54 a.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 71 > > > > > > I imagine `fn` is expensive, after all, it's cryptography. :) > > > > Serially doi

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 13, 2015, 7:21 p.m.) Review request for mesos, Ben Mahler, Gilber

Re: Review Request 38747: Adding digest utilities

> On Oct. 13, 2015, 12:54 a.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/include/process/digest.hpp, lines 85-120 > > > > > > These templates (here and below) have different levels of > > specializations, traits,

Re: Review Request 38747: Adding digest utilities

> On Oct. 1, 2015, 11:23 a.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review but > > didn't look at the review closely. I also have a ticket > > https://issues.apache.org/jira

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review102302 --- 3rdparty/libprocess/include/process/digest.hpp (line 39)

Re: Review Request 38747: Adding digest utilities

> On Oct. 12, 2015, 7:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 61 > > > > > > Consider using `boost::shared_array data` (see io.cpp). Since c++11 standard way is to use s

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 12, 2015, 9:14 p.m.) Review request for mesos, Ben Mahler, Gilber

Re: Review Request 38747: Adding digest utilities

> On Oct. 1, 2015, 6:23 p.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review but > > didn't look at the review closely. I also have a ticket > > https://issues.apache.org/jira/

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101451 --- Incomplete review on v13. Continuing on the latest version. 3rdpa

Re: Review Request 38747: Adding digest utilities

> On Oct. 1, 2015, 11:23 a.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review but > > didn't look at the review closely. I also have a ticket > > https://issues.apache.org/jira

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 8, 2015, 2:37 a.m.) Review request for mesos, Ben Mahler, Gilbert

Re: Review Request 38747: Adding digest utilities

> On Oct. 1, 2015, 6:23 p.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review but > > didn't look at the review closely. I also have a ticket > > https://issues.apache.org/jira/

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101257 --- Sorry I haven't chimed in earlier. I made one comment earlier with

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 30, 2015, 8:11 p.m.) Review request for mesos, Ben Mahler, Gilbe

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 30, 2015, 6:50 p.m.) Review request for mesos, Ben Mahler, Gilbe

Re: Review Request 38747: Adding digest utilities

> On Sept. 29, 2015, 9:35 p.m., Ben Mahler wrote: > > Tim, could you also get a libprocess maintainer to review this? > > Timothy Chen wrote: > Volunteered you :) I chatted with Yan, he'll be helping review this. - Ben --- This is

Re: Review Request 38747: Adding digest utilities

> On Sept. 29, 2015, 9:17 p.m., Timothy Chen wrote: > > 3rdparty/libprocess/src/tests/digest_tests.cpp, line 58 > > > > > > What's the motivation behind having both simple and dynamic > > verification? "Simple" giv

Re: Review Request 38747: Adding digest utilities

> On Sept. 29, 2015, 9:35 p.m., Ben Mahler wrote: > > Tim, could you also get a libprocess maintainer to review this? Volunteered you :) - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101026 --- Tim, could you also get a libprocess maintainer to review this? -

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101018 --- 3rdparty/libprocess/src/tests/digest_tests.cpp (line 58)

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 29, 2015, 6:41 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 29, 2015, 6:30 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 29, 2015, 12:19 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

> On Sept. 28, 2015, 6:32 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 222 > > > > > > Why do we initialize this to `{0}`? > > Jojy Varghese wrote: > initialization of auto v

Re: Review Request 38747: Adding digest utilities

> On Sept. 28, 2015, 7:17 p.m., Jiang Yan Xu wrote: > > High-level comments: > > > > - This implementation relies on USE_SSL_SOCKET which is tied to > > `--enable_ssl`. Conceptually the two should be decoupled. Ian Downes has an > > implementation which uses the system commands that are widely

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 28, 2015, 10:14 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

> On Sept. 28, 2015, 6:32 p.m., Neil Conway wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 191 > > > > > > I believe this leaks "fd". good catch. > On Sept. 28, 2015, 6:32 p.m., Neil Conway wrote:

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100850 --- High-level comments: - This implementation relies on USE_SSL_SOCKE

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100839 --- 3rdparty/libprocess/include/process/digest.hpp (lines 210 - 226) <

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100835 --- 3rdparty/libprocess/include/process/digest.hpp (line 191)

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100686 --- Patch looks great! Reviews applied: [38443, 38579, 38580, 38747]

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 8:33 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 6:33 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100619 --- Bad patch! Reviews applied: [38443, 38579] Failed command: ./supp

Re: Review Request 38747: Adding digest utilities

> On Sept. 25, 2015, 6:24 a.m., Alex Clemmer wrote: > > Hey, it doesn't look like `src/tests/digest_tests.cpp` is being added to > > the `CMakeLists.txt` file in `3rdparty/libprocess/src/tests`. Is that > > correct? If not, could we please add it there as well? > > > > (I have forgotten to add

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 4:45 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 3:23 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

> On Sept. 25, 2015, 6:24 a.m., Alex Clemmer wrote: > > Hey, it doesn't look like `src/tests/digest_tests.cpp` is being added to > > the `CMakeLists.txt` file in `3rdparty/libprocess/src/tests`. Is that > > correct? If not, could we please add it there as well? > > > > (I have forgotten to add

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100539 --- Hey, it doesn't look like `src/tests/digest_tests.cpp` is being add

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 5:46 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Sept. 25, 2015, 5:43 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100530 --- Bad patch! Reviews applied: [38443, 38579, 38580, 38747] Failed c