Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

2015-09-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38754/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

2015-09-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38754/#review100614 --- Ship it! 3rdparty/CMakeLists.txt (lines 25 - 26)

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

2015-09-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38754/#review100631 --- 3rdparty/CMakeLists.txt (line 37)

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 5:12 p.m., Joseph Wu wrote: > > 3rdparty/CMakeLists.txt, lines 25-26 > > > > > > Do you have plans to combine this with the similar lines in > > `3rdparty/libprocess/3rdparty/CMakeLists.txt`? >

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

2015-09-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38754/ --- (Updated Sept. 25, 2015, 10:22 p.m.) Review request for mesos, Artem

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 5:49 p.m., Artem Harutyunyan wrote: > > 3rdparty/CMakeLists.txt, line 37 > > > > > > 80+ characters. We decided that the precedent was to keep it on one line even though it looks way better