Re: Review Request 38963: Added initial draft of networking user-doc.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/
---

(Updated Oct. 5, 2015, 4:44 p.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Bugs: MESOS-3561
https://issues.apache.org/jira/browse/MESOS-3561


Repository: mesos


Description
---

Added initial draft of networking user-doc.


Diffs (updated)
-

  docs/home.md 86320f6 
  docs/images/networking-architecture.png PRE-CREATION 
  docs/networking-for-mesos-managed-containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/38963/diff/


Testing
---

Markdown rendering at 
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking-for-mesos-managed-containers.md


Thanks,

Kapil Arya

Re: Review Request 38963: Added initial draft of networking user-doc.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/
---

(Updated Oct. 5, 2015, 3:55 p.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Bugs: MESOS-3561
https://issues.apache.org/jira/browse/MESOS-3561


Repository: mesos


Description
---

Added initial draft of networking user-doc.


Diffs
-

  docs/home.md f8c2b62 
  docs/images/networking-architecture.png PRE-CREATION 
  docs/networking-for-mesos-managed-containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/38963/diff/


Testing (updated)
---

Markdown rendering at 
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking-for-mesos-managed-containers.md


Thanks,

Kapil Arya

Re: Review Request 38963: Added initial draft of networking user-doc.

[Kapil Arya]

> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, lines 95-96
> > 
> >
> > (And makes it to the scheduler :) Is that worth mentioning here?

It's mentioned in the next bullet point :).


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 102
> > 
> >
> > Would it make sense to enumerate failure modes here? (If the scheduler 
> > fails, if the master fails, ...)

It's a implementation specific concern. Not sure if/how we should capture it.


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 113
> > 
> >
> > Let's ask the community; but I'd assume that we would avoid references 
> > to repos which are not hosted by github.com/apache/mesos or 
> > github.com/mesos - maybe it is fine, but let's make sure

Will send an email shortly.


> On Oct. 5, 2015, 12:15 p.m., Niklas Nielsen wrote:
> > docs/networking.md, line 165
> > 
> >
> > Are those hard tabs?

Nope, just spaces.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101375
---


On Oct. 5, 2015, 3:52 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38963/
> ---
> 
> (Updated Oct. 5, 2015, 3:52 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3561
> https://issues.apache.org/jira/browse/MESOS-3561
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added initial draft of networking user-doc.
> 
> 
> Diffs
> -
> 
>   docs/home.md f8c2b62 
>   docs/images/networking-architecture.png PRE-CREATION 
>   docs/networking-for-mesos-managed-containers.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38963/diff/
> 
> 
> Testing
> ---
> 
> Markdown rendering at 
> https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38963: Added initial draft of networking user-doc.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/
---

(Updated Oct. 5, 2015, 3:52 p.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Changes
---

Addressed Nik's comments.


Bugs: MESOS-3561
https://issues.apache.org/jira/browse/MESOS-3561


Repository: mesos


Description
---

Added initial draft of networking user-doc.


Diffs (updated)
-

  docs/home.md f8c2b62 
  docs/images/networking-architecture.png PRE-CREATION 
  docs/networking-for-mesos-managed-containers.md PRE-CREATION 

Diff: https://reviews.apache.org/r/38963/diff/


Testing
---

Markdown rendering at 
https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md


Thanks,

Kapil Arya

Re: Review Request 38963: Added initial draft of networking user-doc.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101375
---



docs/networking.md (line 16)


s/networking support/networking support in Mesos/



docs/networking.md (line 18)


s/in version 0.25.0/in version 0.25.0 to .../



docs/networking.md (line 19)


backwards compatible? Opt in?



docs/networking.md (line 22)


s/briefly //



docs/networking.md (line 23)


s/ip/IP/



docs/networking.md (line 34)


s/basis/manner/



docs/networking.md (line 35)


s/handled/handle/



docs/networking.md (line 43)


I like this!



docs/networking.md (line 69)


s/contianer/container/



docs/networking.md (line 70)


s/ip/IP/



docs/networking.md (lines 95 - 96)


(And makes it to the scheduler :) Is that worth mentioning here?



docs/networking.md (line 102)


Would it make sense to enumerate failure modes here? (If the scheduler 
fails, if the master fails, ...)



docs/networking.md (line 113)


Let's ask the community; but I'd assume that we would avoid references to 
repos which are not hosted by github.com/apache/mesos or github.com/mesos - 
maybe it is fine, but let's make sure



docs/networking.md (line 146)


But must be supported by that given net module provider, right?



docs/networking.md (line 165)


Are those hard tabs?



docs/networking.md (line 222)


s/Note!/NOTE:/
See some of the other user docs for the format.



docs/networking.md (line 228)


s/many //



docs/networking.md (line 247)


Kill double spaces :)



docs/networking.md (line 251)


NOTE:



docs/networking.md (line 253)


s/sets /sets it's/?



docs/networking.md (line 260)


s/fulfil/fulfill/


- Niklas Nielsen


On Oct. 2, 2015, 11:08 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38963/
> ---
> 
> (Updated Oct. 2, 2015, 11:08 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3561
> https://issues.apache.org/jira/browse/MESOS-3561
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added initial draft of networking user-doc.
> 
> 
> Diffs
> -
> 
>   docs/images/networking-architecture.png PRE-CREATION 
>   docs/networking.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38963/diff/
> 
> 
> Testing
> ---
> 
> Markdown rendering at 
> https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38963: Added initial draft of networking user-doc.

[Niklas Nielsen]

> On Oct. 2, 2015, 11:31 a.m., Joseph Wu wrote:
> > A few things you're missing (haven't read the doc yet):
> > 
> > * A link to this from `home.md`.
> > * You need to generate this diff manually (via `git diff --binary`) and 
> > post it.  The image won't be included otherwise.  (ReviewBot is going to 
> > say "bad patch" soon.)
> > * Make sure you render this using 
> > https://github.com/mesosphere/mesos-website-container  (Note that the image 
> > will *not* show up, until https://issues.apache.org/jira/browse/MESOS-3183 
> > is resolved).

+1 :) Thanks Joseph


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101347
---


On Oct. 2, 2015, 11:08 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38963/
> ---
> 
> (Updated Oct. 2, 2015, 11:08 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3561
> https://issues.apache.org/jira/browse/MESOS-3561
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added initial draft of networking user-doc.
> 
> 
> Diffs
> -
> 
>   docs/images/networking-architecture.png PRE-CREATION 
>   docs/networking.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38963/diff/
> 
> 
> Testing
> ---
> 
> Markdown rendering at 
> https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38963: Added initial draft of networking user-doc.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101354
---


Bad patch!

Reviews applied: [38963]

Failed command: ./support/apply-review.sh -n -r 38963

Error:
 2015-10-02 19:19:14 URL:https://reviews.apache.org/r/38963/diff/raw/ 
[10822/10822] -> "38963.patch" [1]
error: missing binary patch data for 'docs/images/networking-architecture.png'
error: binary patch does not apply to 'docs/images/networking-architecture.png'
error: docs/images/networking-architecture.png: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 2, 2015, 6:08 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38963/
> ---
> 
> (Updated Oct. 2, 2015, 6:08 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3561
> https://issues.apache.org/jira/browse/MESOS-3561
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added initial draft of networking user-doc.
> 
> 
> Diffs
> -
> 
>   docs/images/networking-architecture.png PRE-CREATION 
>   docs/networking.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38963/diff/
> 
> 
> Testing
> ---
> 
> Markdown rendering at 
> https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 38963: Added initial draft of networking user-doc.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38963/#review101347
---


A few things you're missing (haven't read the doc yet):

* A link to this from `home.md`.
* You need to generate this diff manually (via `git diff --binary`) and post 
it.  The image won't be included otherwise.  (ReviewBot is going to say "bad 
patch" soon.)
* Make sure you render this using 
https://github.com/mesosphere/mesos-website-container  (Note that the image 
will *not* show up, until https://issues.apache.org/jira/browse/MESOS-3183 is 
resolved).

- Joseph Wu


On Oct. 2, 2015, 11:08 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38963/
> ---
> 
> (Updated Oct. 2, 2015, 11:08 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3561
> https://issues.apache.org/jira/browse/MESOS-3561
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added initial draft of networking user-doc.
> 
> 
> Diffs
> -
> 
>   docs/images/networking-architecture.png PRE-CREATION 
>   docs/networking.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38963/diff/
> 
> 
> Testing
> ---
> 
> Markdown rendering at 
> https://github.com/karya0/mesos/blob/net-user-doc/docs/networking.md
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>