Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

2015-11-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/#review108010 --- Ship it! src/Makefile.am (line 1740)

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

2015-11-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/ --- (Updated Nov. 23, 2015, 5:10 p.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

2015-11-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/ --- (Updated Nov. 14, 2015, 3:11 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

2015-11-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/ --- (Updated Nov. 14, 2015, 3:04 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

2015-11-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/ --- (Updated Nov. 5, 2015, 12:56 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

2015-11-04 Thread Neil Conway
> On Nov. 5, 2015, 12:08 a.m., Ben Mahler wrote: > > src/tests/mesos.cpp, line 447 > > > > > > We tend to avoid abbreviations (like ctor, dtor): > > > > ``` > > ? mesos git:(master) ? grep -R destructor

Re: Review Request 39946: Moved definition of ctors and dtors for mock classes out of header file.

2015-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39946/#review105181 --- src/tests/mesos.cpp (line 447)