Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-19 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/
---

(Updated Nov. 19, 2015, 6:05 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

rebased.


Repository: mesos


Description
---

By piping stderr to logs, it would be easier to  debug problems with untar.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
78129a8d306f77403cd99357a1d2a65dc3e65c7b 

Diff: https://reviews.apache.org/r/40285/diff/


Testing
---

make check;


Thanks,

Jojy Varghese

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review107142
---


Bad patch!

Reviews applied: [40284, 40285]

Failed command: ./support/apply-review.sh -n -r 40285

Error:
 2015-11-19 07:11:14 URL:https://reviews.apache.org/r/40285/diff/raw/ 
[3128/3128] -> "40285.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/provisioner/docker/puller.cpp:18
error: src/slave/containerizer/mesos/provisioner/docker/puller.cpp: patch does 
not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 17, 2015, 6:57 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> ---
> 
> (Updated Nov. 17, 2015, 6:57 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> By piping stderr to logs, it would be easier to  debug problems with untar.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 13f5e2877f4d7951e79ba07073a42848217604b3 
> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> ---
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-18 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review107106
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 17, 2015, 6:57 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> ---
> 
> (Updated Nov. 17, 2015, 6:57 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> By piping stderr to logs, it would be easier to  debug problems with untar.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 13f5e2877f4d7951e79ba07073a42848217604b3 
> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> ---
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/
---

(Updated Nov. 17, 2015, 6:57 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

better logs.


Repository: mesos


Description
---

By piping stderr to logs, it would be easier to  debug problems with untar.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
13f5e2877f4d7951e79ba07073a42848217604b3 

Diff: https://reviews.apache.org/r/40285/diff/


Testing
---

make check;


Thanks,

Jojy Varghese

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese 


> On Nov. 17, 2015, 4:49 a.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 107
> > 
> >
> > You should also include or at least log why we couldn't io::read right?

I didnt add that in the error message because the untar error message will then 
have io::read context. Maybe i can log it?


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review106794
---


On Nov. 17, 2015, 6:41 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> ---
> 
> (Updated Nov. 17, 2015, 6:41 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> By piping stderr to logs, it would be easier to  debug problems with untar.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 13f5e2877f4d7951e79ba07073a42848217604b3 
> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> ---
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/
---

(Updated Nov. 17, 2015, 6:41 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

fixed isReady


Repository: mesos


Description
---

By piping stderr to logs, it would be easier to  debug problems with untar.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
13f5e2877f4d7951e79ba07073a42848217604b3 

Diff: https://reviews.apache.org/r/40285/diff/


Testing
---

make check;


Thanks,

Jojy Varghese

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/
---

(Updated Nov. 17, 2015, 6:10 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

review.


Repository: mesos


Description
---

By piping stderr to logs, it would be easier to  debug problems with untar.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
13f5e2877f4d7951e79ba07073a42848217604b3 

Diff: https://reviews.apache.org/r/40285/diff/


Testing
---

make check;


Thanks,

Jojy Varghese

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review106794
---



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 91)


Since you're not really changing the return type you should use onAny here, 
other wise the .then won't be called too if .status() failed.



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 94)


You need to return after fail, same other places too.



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 107)


You should also include or at least log why we couldn't io::read right?


- Timothy Chen


On Nov. 17, 2015, 4:43 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> ---
> 
> (Updated Nov. 17, 2015, 4:43 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> By piping stderr to logs, it would be easier to  debug problems with untar.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 13f5e2877f4d7951e79ba07073a42848217604b3 
> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> ---
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/
---

(Updated Nov. 17, 2015, 4:43 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

further fix on self review.


Repository: mesos


Description
---

By piping stderr to logs, it would be easier to  debug problems with untar.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
13f5e2877f4d7951e79ba07073a42848217604b3 

Diff: https://reviews.apache.org/r/40285/diff/


Testing
---

make check;


Thanks,

Jojy Varghese

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/
---

(Updated Nov. 17, 2015, 2:52 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

Changed solution to promise based one.


Repository: mesos


Description
---

By piping stderr to logs, it would be easier to  debug problems with untar.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
13f5e2877f4d7951e79ba07073a42848217604b3 

Diff: https://reviews.apache.org/r/40285/diff/


Testing
---

make check;


Thanks,

Jojy Varghese

Re: Review Request 40285: Changed untar process to pipe STDERR.

2015-11-16 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/
---

(Updated Nov. 17, 2015, 1:22 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

fixed issues based on review comments.


Summary (updated)
-

Changed untar process to pipe STDERR.


Repository: mesos


Description (updated)
---

By piping stderr to logs, it would be easier to  debug problems with untar.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
13f5e2877f4d7951e79ba07073a42848217604b3 

Diff: https://reviews.apache.org/r/40285/diff/


Testing
---

make check;


Thanks,

Jojy Varghese