> On Nov. 17, 2015, 4:49 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 107 > > <https://reviews.apache.org/r/40285/diff/5/?file=1127825#file1127825line107> > > > > You should also include or at least log why we couldn't io::read right?
I didnt add that in the error message because the untar error message will then have io::read context. Maybe i can log it? - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40285/#review106794 ----------------------------------------------------------- On Nov. 17, 2015, 6:41 a.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40285/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 6:41 a.m.) > > > Review request for mesos and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > By piping stderr to logs, it would be easier to debug problems with untar. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > 13f5e2877f4d7951e79ba07073a42848217604b3 > > Diff: https://reviews.apache.org/r/40285/diff/ > > > Testing > ------- > > make check; > > > Thanks, > > Jojy Varghese > >
