-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40285/#review106794
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 91)
<https://reviews.apache.org/r/40285/#comment165570>

    Since you're not really changing the return type you should use onAny here, 
other wise the .then won't be called too if .status() failed.



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 94)
<https://reviews.apache.org/r/40285/#comment165568>

    You need to return after fail, same other places too.



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 107)
<https://reviews.apache.org/r/40285/#comment165569>

    You should also include or at least log why we couldn't io::read right?


- Timothy Chen


On Nov. 17, 2015, 4:43 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40285/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 4:43 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By piping stderr to logs, it would be easier to  debug problems with untar.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 13f5e2877f4d7951e79ba07073a42848217604b3 
> 
> Diff: https://reviews.apache.org/r/40285/diff/
> 
> 
> Testing
> -------
> 
> make check;
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to