Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-14 Thread Jie Yu
> On Dec. 4, 2015, 10:51 a.m., Bernd Mathiske wrote: > > src/hdfs/hdfs.cpp, line 143 > > > > > > Maybe we can get some extra info about what subprocess failed to be > > reaped by capturing some values from above in

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/#review108960 --- Ship it! src/hdfs/hdfs.cpp (line 143)

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/#review108902 --- Ship it! i'm assuming there are already tests that verify this

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/ --- (Updated Dec. 4, 2015, 12:09 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/ --- (Updated Dec. 4, 2015, 12:20 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-03 Thread Jie Yu
> On Dec. 3, 2015, 10:42 p.m., Vinod Kone wrote: > > i'm assuming there are already tests that verify this change? just checked. Not every function. I'll add tests in the subsequent reviews. - Jie --- This is an automatically generated

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-03 Thread Jie Yu
> On Dec. 1, 2015, 10:40 a.m., Bernd Mathiske wrote: > > src/hdfs/hdfs.cpp, line 100 > > > > > > This block seems to be reusable in a lot of situations. Any chance we > > could abstract it and make it part of class

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/ --- (Updated Dec. 4, 2015, 12:45 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/#review108465 --- Patch looks great! Reviews applied: [40250, 40251, 40252, 40274,

Re: Review Request 40806: Made HDFS::exists asynchronous.

2015-12-01 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/#review108475 --- src/hdfs/hdfs.cpp (line 82)