Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 22, 2015, 7:48 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, lines 357-359 > > > > > > Have you considered making this static? > > What about building it up from the true and false

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111638 --- Ship it! src/master/quota_handler.cpp (lines 332 - 334)

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/ --- (Updated Dec. 22, 2015, 6:09 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 22, 2015, 5:47 p.m., Anand Mazumdar wrote: > > src/master/quota_handler.cpp, line 30 > > > > > > Remove this. This must have crept in due to handling multiple `force` > > field values ? You're right and th

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111624 --- Ship it! LGTM ! src/master/quota_handler.cpp (line 30)

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/ --- (Updated Dec. 22, 2015, 11:02 a.m.) Review request for mesos, Anand Mazumdar, B

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote: > > src/master/quota_handler.cpp, line 353 > > > > > > hmmm .. Should we return a `BadRequest` for all other non-allowed > > values of `force` other then `true`

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote: > > src/master/quota_handler.cpp, line 353 > > > > > > hmmm .. Should we return a `BadRequest` for all other non-allowed > > values of `force` other then `true`

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 21, 2015, 10:03 p.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, lines 358-359 > > > > > > What will happen if end user input TRUE, True, FALSE, False? Shall we > > document those keyword in quot

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111543 --- src/master/quota_handler.cpp (lines 333 - 334)

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote: > > src/master/quota_handler.cpp, line 353 > > > > > > hmmm .. Should we return a `BadRequest` for all other non-allowed > > values of `force` other then `true`

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote: > > src/master/quota_handler.cpp, line 299 > > > > > > hmm, why don't we do a `using google::protobuf::RepeatedPtrField` and > > get rid of all this jaggedness

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/ --- (Updated Dec. 21, 2015, 1:27 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 41514: Accepted a single JSON object for quota set request.

> On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote: > > LGTM.. Just some nits around: > > > > - using `const` for test strings. > > - reducing jaggedness for some blocks. > > > > Also, a query regarding just accepting `true/false` as `force` field values. Good points, thanks for the review,

Re: Review Request 41514: Accepted a single JSON object for quota set request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111086 --- LGTM.. Just some nits around: - using `const` for test strings. -