Re: Review Request 41657: Added user facing documentation for containerizers.

[Jie Yu]

> On Jan. 6, 2016, 11:10 p.m., Jie Yu wrote:
> > docs/containerizer.md, lines 53-54
> > 
> >
> > What does that mean? An agent is either running on Linux or running on 
> > OSX, how is that possible?
> 
> Jojy Varghese wrote:
> What i meant was that this feature will allow a `task` (say command) to 
> be run on OSX(by using mesos containerizer + posix isolators) or Linux (using 
> mesos containerizer or docker containerizer).

I removed it since it's quite confusing.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review113148
---


On Jan. 6, 2016, 11:33 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Jan. 6, 2016, 11:33 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/
---

(Updated Jan. 6, 2016, 11:33 p.m.)


Review request for mesos, Jie Yu and Joerg Schad.


Changes
---

review changes @jie.


Repository: mesos


Description
---

This documentation is intended for users trying to get an overview of
containerizer technology. It also provides the criteria for selecting a
particular type of containerizer.


Diffs (updated)
-

  docs/containerizer.md PRE-CREATION 
  docs/home.md d929838206817a6c49cc2343b4de82fa085da682 

Diff: https://reviews.apache.org/r/41657/diff/


Testing
---

mesos website docker.


Thanks,

Jojy Varghese

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

> On Jan. 6, 2016, 11:10 p.m., Jie Yu wrote:
> > docs/containerizer.md, lines 53-54
> > 
> >
> > What does that mean? An agent is either running on Linux or running on 
> > OSX, how is that possible?

What i meant was that this feature will allow a `task` (say command) to be run 
on OSX(by using mesos containerizer + posix isolators) or Linux (using mesos 
containerizer or docker containerizer).


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review113148
---


On Dec. 29, 2015, 4:36 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 29, 2015, 4:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review113148
---

Ship it!


This is great! Thanks Jojy!


docs/containerizer.md (lines 23 - 24)


I wouldn't claim it 'the best'. Maybe one of the best is more appropriate 
if you really want to say it.



docs/containerizer.md (lines 53 - 54)


What does that mean? An agent is either running on Linux or running on OSX, 
how is that possible?



docs/containerizer.md (line 66)


I won't mentionen the name 'isolators' as it's confusing with our isolators 
in Mesos containerizer.



docs/containerizer.md (line 75)


Mention that this is the native Mesos container solution.

s/isolators/pluggable isolators/



docs/containerizer.md (line 82)


e.g. cgroups/namespaces

s/Use fine grined/Want fine grined/



docs/containerizer.md (line 83)


s/Use/Want/



docs/containerizer.md (lines 84 - 85)


s/filesystem/storage/disk/



docs/containerizer.md (line 86)


I would combine this with the first bullet:

```
Allow Mesos to control the task's runtime environment without depending on 
other container technologies (e.g., docker).
```


- Jie Yu


On Dec. 29, 2015, 4:36 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 29, 2015, 4:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review112197
---


Patch looks great!

Reviews applied: [41656, 41657]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 29, 2015, 4:36 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 29, 2015, 4:36 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/
---

(Updated Dec. 29, 2015, 4:36 p.m.)


Review request for mesos, Jie Yu and Joerg Schad.


Changes
---

review addressed.


Repository: mesos


Description
---

This documentation is intended for users trying to get an overview of
containerizer technology. It also provides the criteria for selecting a
particular type of containerizer.


Diffs (updated)
-

  docs/containerizer.md PRE-CREATION 
  docs/home.md d929838206817a6c49cc2343b4de82fa085da682 

Diff: https://reviews.apache.org/r/41657/diff/


Testing
---

mesos website docker.


Thanks,

Jojy Varghese

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

> On Dec. 29, 2015, 9:46 a.m., Joerg Schad wrote:
> > docs/containerizer.md, line 74
> > 
> >
> > Do we have more documentation on this array of isolators?

Not at present. There is a ticket for that task (in the same epic) and I might 
work on that next.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review112139
---


On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 28, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

> On Dec. 29, 2015, 9:46 a.m., Joerg Schad wrote:
> > docs/containerizer.md, line 9
> > 
> >
> > I thought about this a little more (not this is not an issue just an 
> > idea so feel free to ignore), maybe it makes sense to focus on the 
> > Motivation (instead of defining what containerizers are)
> > 
> > How do you feel about the following.
> > 
> > # Motivation
> > 
> > As Mesos is able of running a large number of tasks it needs to ensure 
> > the following:
> > 
> > * Isolate tasks 
> > * .
> > * 
> > * ..
> > 
> > In order to achieve this Mesos run tasks in 'containers' which in turn 
> > can be controlled by different containerizers.

Not sure if the motivation of containers/containerizer is the scale of tasks.


> On Dec. 29, 2015, 9:46 a.m., Joerg Schad wrote:
> > docs/containerizer.md, line 12
> > 
> >
> > s/a task/ tasks?

"A container" isolates "a task" from the rest of tasks.


> On Dec. 29, 2015, 9:46 a.m., Joerg Schad wrote:
> > docs/containerizer.md, line 16
> > 
> >
> > with same environment you mean the tasks environment (e.g., provided by 
> > the docker container), which can then be run across different environments 
> > (e.g., dev, production, testing)?
> > 
> > In that case the term 'same environment' seems a little misleading.

This was inspired from Docker's website which says ```This guarantees that it 
will always run the same, regardless of the environment it is running in```


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review112139
---


On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 28, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review112139
---

Ship it!



docs/containerizer.md (line 9)


I thought about this a little more (not this is not an issue just an idea 
so feel free to ignore), maybe it makes sense to focus on the Motivation 
(instead of defining what containerizers are)

How do you feel about the following.

# Motivation

As Mesos is able of running a large number of tasks it needs to ensure the 
following:

* Isolate tasks 
* .
* 
* ..

In order to achieve this Mesos run tasks in 'containers' which in turn can 
be controlled by different containerizers.



docs/containerizer.md (line 12)


s/a task/ tasks?



docs/containerizer.md (line 16)


with same environment you mean the tasks environment (e.g., provided by the 
docker container), which can then be run across different environments (e.g., 
dev, production, testing)?

In that case the term 'same environment' seems a little misleading.



docs/containerizer.md (line 18)


Does this make more sense in the section below where you talk about 
different containerizer?



docs/containerizer.md (line 70)


For more details see ?



docs/containerizer.md (line 74)


Do we have more documentation on this array of isolators?


- Joerg Schad


On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 28, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review112068
---


Patch looks great!

Reviews applied: [41656, 41657]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 28, 2015, 8:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 28, 2015, 8:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md d929838206817a6c49cc2343b4de82fa085da682 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/
---

(Updated Dec. 28, 2015, 8:23 p.m.)


Review request for mesos, Jie Yu and Joerg Schad.


Changes
---

rebased with master.


Repository: mesos


Description
---

This documentation is intended for users trying to get an overview of
containerizer technology. It also provides the criteria for selecting a
particular type of containerizer.


Diffs (updated)
-

  docs/containerizer.md PRE-CREATION 
  docs/home.md d929838206817a6c49cc2343b4de82fa085da682 

Diff: https://reviews.apache.org/r/41657/diff/


Testing
---

mesos website docker.


Thanks,

Jojy Varghese

Re: Review Request 41657: Added user facing documentation for containerizers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review112060
---


Bad patch!

Reviews applied: [41656]

Failed command: ./support/apply-review.sh -n -r 41656

Error:
 2015-12-28 20:00:51 URL:https://reviews.apache.org/r/41656/diff/raw/ 
[2380/2380] -> "41656.patch" [1]
error: patch failed: docs/home.md:15
error: docs/home.md: patch does not apply

- Mesos ReviewBot


On Dec. 28, 2015, 7:49 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 28, 2015, 7:49 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/
---

(Updated Dec. 28, 2015, 7:49 p.m.)


Review request for mesos, Jie Yu and Joerg Schad.


Changes
---

review(joerg) addressed.


Repository: mesos


Description
---

This documentation is intended for users trying to get an overview of
containerizer technology. It also provides the criteria for selecting a
particular type of containerizer.


Diffs (updated)
-

  docs/containerizer.md PRE-CREATION 
  docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 

Diff: https://reviews.apache.org/r/41657/diff/


Testing
---

mesos website docker.


Thanks,

Jojy Varghese

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

> On Dec. 27, 2015, 2:39 p.m., Joerg Schad wrote:
> > docs/containerizer.md, line 30
> > 
> >
> > container technologies? Maybe something like: Mesos currently supports 
> > the following containerizer?

Since this document is user facing ,for someone who is trying to undertand how 
mesos and containers play together. The intended audience most likely would be 
familiar with words like "containers" but not with "containerizers"(which is a 
mesos terminology). So the intent here is to use words that the intended 
audience of this document is familiar with. Maybe its conveying wrong 
information? Would love to get ur feedback.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111927
---


On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

> On Dec. 27, 2015, 2:39 p.m., Joerg Schad wrote:
> > docs/containerizer.md, line 26
> > 
> >
> > What do you mean by "own native container technology"? Isn't that 
> > highly platform dependent?

Not sure what you mean. Here is my intent:

'Mesos containerizer' is Mesos's native container technology in terms of:
- Provides isolation between tasks
- Controls resources for tasks

It achieves these in Posix and linux platforms. Some platforms provide more 
control (linux) than others but the intent of the component is to  'contain' 
tasks.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111927
---


On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

> On Dec. 28, 2015, 12:33 a.m., Qian Zhang wrote:
> > docs/containerizer.md, line 13
> > 
> >
> > Isolate task or executor or both? For task, I think it is up to 
> > executor for how to launch it.

Here the bullet points are for  what 'containers' are for (not containerizer).


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111947
---


On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111947
---



docs/containerizer.md (line 13)


Isolate task or executor or both? For task, I think it is up to executor 
for how to launch it.


- Qian Zhang


On Dec. 23, 2015, 6:27 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 23, 2015, 6:27 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111927
---



docs/containerizer.md (line 5)


Any reason for two blank lines?



docs/containerizer.md (line 19)


Should we mention the default value?



docs/containerizer.md (line 26)


What do you mean by "own native container technology"? Isn't that highly 
platform dependent?



docs/containerizer.md (line 30)


container technologies? Maybe something like: Mesos currently supports the 
following containerizer?



docs/containerizer.md (line 33)


Add Links to docs (maybe also/instead from sections below)?



docs/containerizer.md (lines 37 - 38)


Should this section maybe be after we introduce the other containerizer (I 
assume you went for alphabetical order)? Feel free to ignore if you disagree ...


- Joerg Schad


On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111688
---


Patch looks great!

Reviews applied: [41656, 41657]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 10:27 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/
---

(Updated Dec. 22, 2015, 10:27 p.m.)


Review request for mesos, Jie Yu and Joerg Schad.


Changes
---

review addressed.


Repository: mesos


Description
---

This documentation is intended for users trying to get an overview of
containerizer technology. It also provides the criteria for selecting a
particular type of containerizer.


Diffs (updated)
-

  docs/containerizer.md PRE-CREATION 
  docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 

Diff: https://reviews.apache.org/r/41657/diff/


Testing
---

mesos website docker.


Thanks,

Jojy Varghese

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

> On Dec. 22, 2015, 9:42 p.m., Joseph Wu wrote:
> > docs/containerizer.md, line 53
> > 
> >
> > Maybe: s/OSX/POSIX/

If we have to say linux, then I would think we should use an operating system 
like osx/bsd. posix is an API standard.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111665
---


On Dec. 22, 2015, 7:35 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 7:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Jojy Varghese]

> On Dec. 22, 2015, 9:42 p.m., Joseph Wu wrote:
> > docs/containerizer.md, lines 13-15
> > 
> >
> > I feel like these three points say the same thing.  Maybe you can 
> > condense them down to two points.
> > 
> > Wording suggestion: 
> > 
> > * Isolate a task from other running tasks by restricting the resources 
> > the task can access.
> > * Programmatically control a task's resource usage.

Thanks for the suggestions Joseph. I feel that restricting resources and 
isolation are separate concerns. For example in Linux, isolation is achieved 
via namespaces and resource restriction is achieved through cgroups. Today 
network namespace does not have ability to restrict bandwidth usage.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111665
---


On Dec. 22, 2015, 7:35 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 7:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111665
---


Looks good.  Just a few suggestions:


docs/containerizer.md (lines 13 - 15)


I feel like these three points say the same thing.  Maybe you can condense 
them down to two points.

Wording suggestion: 

* Isolate a task from other running tasks by restricting the resources the 
task can access.
* Programmatically control a task's resource usage.



docs/containerizer.md (lines 19 - 20)


Suggestion: The user can specify what types of containerizer to use via the 
`--containerizers` agent flag.



docs/containerizer.md (line 25)


You can also say that Docker is a "first-class citizen" of Mesos.



docs/containerizer.md (line 53)


Maybe: s/OSX/POSIX/



docs/containerizer.md (line 61)


Mis-matched closing parentheses.


- Joseph Wu


On Dec. 22, 2015, 11:35 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 11:35 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 41657: Added user facing documentation for containerizers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41657/#review111662
---


Patch looks great!

Reviews applied: [41656, 41657]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 22, 2015, 7:35 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41657/
> ---
> 
> (Updated Dec. 22, 2015, 7:35 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This documentation is intended for users trying to get an overview of
> containerizer technology. It also provides the criteria for selecting a
> particular type of containerizer.
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md PRE-CREATION 
>   docs/home.md 51c19bb9d0d74698fcdda6197d32ed8f4a57d7c9 
> 
> Diff: https://reviews.apache.org/r/41657/diff/
> 
> 
> Testing
> ---
> 
> mesos website docker.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>