Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-05-13 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review133171
---


Fix it, then Ship it!




I'll fix outstanding issues for you and commit shortly.


src/tests/hierarchical_allocator_tests.cpp (line 199)


Do we really need to distinguish between empty capabilities and not set 
capabilities? There is no difference in protobufs, right? Let's remove 
`Option<>` then.



src/tests/hierarchical_allocator_tests.cpp (line 208)


I know what you try to say, but `type` is confusing. The best option is 
`capabilityType`, but if want something shorter, I'd suggest we go for 
`capability`. Moreover, imagine the future when we have more fields in 
`Capability` proto.



src/tests/hierarchical_allocator_tests.cpp (lines 1202 - 1203)


Why do we need to define var that is used once in the immediate proximity 
of definition?


- Alexander Rukletsov


On May 6, 2016, 8:04 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated May 6, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Artem 
> Harutyunyan, Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 53a759ce0ebea87cc564a22cb2d34e54870f782b 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-05-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 五月 6, 2016, 8:04 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
53a759ce0ebea87cc564a22cb2d34e54870f782b 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-05-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review132000
---



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 3:35 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated May 6, 2016, 3:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 53a759ce0ebea87cc564a22cb2d34e54870f782b 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-05-05 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 五月 6, 2016, 3:35 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
53a759ce0ebea87cc564a22cb2d34e54870f782b 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-05-05 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review131846
---




src/tests/hierarchical_allocator_tests.cpp (lines 197 - 199)


`FrameworkInfo.capabilities` is a repeated field. This means we plan to add 
more capabilities in the future. For now, we use only revocable resources in 
this fixture, but this may change. Could you please update the signature to 
take a vector or a list of capabilities?

I can imagine that in the future we may want to pull out all these helpers 
and consolidate them.


- Alexander Rukletsov


On April 29, 2016, 9:56 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated April 29, 2016, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 53a759ce0ebea87cc564a22cb2d34e54870f782b 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-04-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review131104
---



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 29, 2016, 9:56 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated April 29, 2016, 9:56 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 53a759ce0ebea87cc564a22cb2d34e54870f782b 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-04-29 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 四月 29, 2016, 9:56 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Changes
---

Rebase


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
53a759ce0ebea87cc564a22cb2d34e54870f782b 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-03-19 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 三月 17, 2016, 1:12 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-03-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review123995
---



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 17, 2016, 1:12 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated March 17, 2016, 1:12 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 459e02576f6d05abbbcc83ae5cabac5c66e93f05 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-03-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review123361
---



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 14, 2016, 4:03 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated March 14, 2016, 4:03 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 459e02576f6d05abbbcc83ae5cabac5c66e93f05 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-03-13 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 三月 14, 2016, 4:03 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-03-11 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 三月 11, 2016, 9:10 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
459e02576f6d05abbbcc83ae5cabac5c66e93f05 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-02-28 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review121206
---



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 7:04 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated Feb. 29, 2016, 7:04 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-02-28 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 二月 29, 2016, 7:04 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Changes
---

Rebase


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description (updated)
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
5f771f02db9bd098f3cd36730cd84bf2f5e87a33 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-01-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review115258
---

Ship it!


Test cleanup, LGTM!

- Joseph Wu


On Jan. 16, 2016, 6:24 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated Jan. 16, 2016, 6:24 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
> https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The function of `createFrameworkInfo` was updated by enabling
> caller can set a bool parameter to create a framework which can
> use revocable resources.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9362dd306497ba01e0f387c3862456cdcac6f863 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-01-16 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 一月 17, 2016, 2:24 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Summary (updated)
-

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Bugs: MESOS-4145
https://issues.apache.org/jira/browse/MESOS-4145


Repository: mesos


Description
---

The function of `createFrameworkInfo` was updated by enabling
caller can set a bool parameter to create a framework which can
use revocable resources.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
9362dd306497ba01e0f387c3862456cdcac6f863 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated createFrameworkInfo for hierarchical_allocator_tests.cpp.

2016-01-16 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review114891
---



src/tests/hierarchical_allocator_tests.cpp (line 201)


Should be "bool", not "const bool&".


- Neil Conway


On Jan. 16, 2016, 5 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated Jan. 16, 2016, 5 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
> https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The function of `createFrameworkInfo` was updated by enabling
> caller can set a bool parameter to create a framework which can
> use revocable resources.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 9362dd306497ba01e0f387c3862456cdcac6f863 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>