Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-04-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review128423 --- Fix it, then Ship it! I'll fix the last nit and commit shortly.

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-04-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review127991 --- Patch looks great! Reviews applied: [43321] Passed command: expo

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-04-09 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/ --- (Updated April 9, 2016, 9:17 a.m.) Review request for mesos and Alexander Rukle

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review127796 --- Could you please rebase it? - Alexander Rukletsov On March 30,

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review121186 --- Patch looks great! Reviews applied: [43321] Passed command: expo

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-28 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/ --- (Updated Feb. 29, 2016, 3:11 a.m.) Review request for mesos and Alexander Rukle

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review119040 --- Patch looks great! Reviews applied: [43321] Passed command: expo

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/ --- (Updated Feb. 12, 2016, 1:48 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Shuai Lin
> On Feb. 12, 2016, 1:36 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 896 > > > > > > s/dispatch/dispatched > > > > s/recoverResources/`recoverResources` - `the dispatch event` is used l

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review119006 --- Fix it, then Ship it! Ship It! src/tests/scheduler_tests.cpp

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Shuai Lin
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processe

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-12 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/ --- (Updated Feb. 12, 2016, 12:15 p.m.) Review request for mesos and Alexander Rukl

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review118861 --- src/tests/scheduler_tests.cpp (line 836)

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-11 Thread Guangya Liu
> On 二月 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processed

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-10 Thread Shuai Lin
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processe

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-10 Thread Guangya Liu
> On 二月 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processed

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread Shuai Lin
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processe

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread Guangya Liu
> On 二月 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processed

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread Shuai Lin
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 850 > > > > > > Does this still needed? > > haosdent huang wrote: > I think still need, we don't sure what would happend i

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread Shuai Lin
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processe

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread haosdent huang
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 850 > > > > > > Does this still needed? > > haosdent huang wrote: > I think still need, we don't sure what would happend i

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread Guangya Liu
> On 二月 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 850 > > > > > > Does this still needed? > > haosdent huang wrote: > I think still need, we don't sure what would happend in

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread haosdent huang
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and processe

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review118391 --- src/tests/scheduler_tests.cpp (line 839)

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review118203 --- Ship it! Ship It! - haosdent huang On Feb. 8, 2016, 4:20 a.m

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review118202 --- Patch looks great! Reviews applied: [43321] Passed command: expo