Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122693 --- src/tests/hierarchical_allocator_tests.cpp (lines 236 - 239)

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 9, 2016, 3:17 a.m.) Review request for mesos, Adam B and

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
> On March 8, 2016, 11:20 p.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 233 > > > > > > `getAllocations` is too general a name for what this function actually > > does. More like

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122622 --- src/tests/hierarchical_allocator_tests.cpp (line 233)

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122520 --- Patch looks great! Reviews applied: [43824] Passed command:

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 8, 2016, 12:10 p.m.) Review request for mesos, Adam B and

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122494 --- Fix it, then Ship it! Just a bunch a grammar fixes. Otherwise

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
> On March 3, 2016, 1:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2607-2609 > > > > > > I'm an ESL, but having both "per weight" and "by weight" sounds a bit > >

Re: Review Request 43824: Addressed comments of 41672.

2016-03-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122327 --- Patch looks great! Reviews applied: [43824] Passed command:

Re: Review Request 43824: Addressed comments of 41672.

2016-03-07 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 7, 2016, 1:55 p.m.) Review request for mesos, Adam B and

Re: Review Request 43824: Addressed comments of 41672.

2016-03-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122293 --- src/tests/hierarchical_allocator_tests.cpp (line 2445)

Re: Review Request 43824: Addressed comments of 41672.

2016-03-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122292 --- Patch looks great! Reviews applied: [43824] Passed command:

Re: Review Request 43824: Addressed comments of 41672.

2016-03-07 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 7, 2016, 11:31 a.m.) Review request for mesos, Adam B and

Re: Review Request 43824: Addressed comments of 41672.

2016-03-07 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122280 --- Fix it, then Ship it!

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 3, 2016, 2:05 p.m.) Review request for mesos, Adam B and

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Alexander Rukletsov
> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2635-2640 > > > > > > Does it fit one line? I know we are a bit inconsistent about it, but > > let's

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 3, 2016, 1:28 p.m.) Review request for mesos, Adam B and

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Yongqiao Wang
> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2607-2609 > > > > > > I'm an ESL, but having both "per weight" and "by weight" sounds a bit > >

Re: Review Request 43824: Addressed comments of 41672.

2016-03-03 Thread Alexander Rukletsov
> On March 3, 2016, 9:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2759-2770 > > > > > > Let me clarify what I meant in r/41672/. I would like to avoid the > >

Re: Review Request 43824: Addressed comments of 41672.

2016-02-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review121402 --- Patch looks great! Reviews applied: [43824] Passed command:

Re: Review Request 43824: Addressed comments of 41672.

2016-02-29 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 1, 2016, 6:42 a.m.) Review request for mesos, Adam B and

Re: Review Request 43824: Addressed comments of 41672.

2016-02-29 Thread Yongqiao Wang
> On Feb. 28, 2016, 9:39 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2658-2661 > > > > > > Can you say 100% and 0% instead of 1 and 0? And how is framework1's > > "share" '6'? Is that

Re: Review Request 43824: Addressed comments of 41672.

2016-02-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review121132 --- Thanks for following up with this. AlexR is on vacation now, so

Re: Review Request 43824: Addressed comments of 41672.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review120150 --- Patch looks great! Reviews applied: [43824] Passed command: