Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 18, 2016, 5:28 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review124151 --- Needs more const references, but otherwise in nearly-shippable sha

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 17, 2016, 7:39 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 17, 2016, 10:38 p.m., Joerg Schad wrote: > > src/authentication/http/basic_authenticator_factory.cpp, line 67 > > > > > > We do nor add additional information to the error is that a concious > > choice? If

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 18, 2016, 8:55 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 87-91 > > > > > > Is it ok to specify a realm but no credentials? Does that just mean > > that nobody c

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review124111 --- Fix it, then Ship it! src/authentication/http/basic_authentica

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 18, 2016, 1:55 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 87-91 > > > > > > Is it ok to specify a realm but no credentials? Does that just mean > > that nobody c

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review124384 --- Ship it! Ship It! - Adam B On March 18, 2016, 10:28 a.m., Gr

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 14, 2016, 9:38 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 63-64 > > > > > > Seems like you're changing the meaning of the parameters in > > `BasicAuthenticatorFa

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 18, 2016, 8:55 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 87-91 > > > > > > Is it ok to specify a realm but no credentials? Does that just mean > > that nobody c

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 18, 2016, 12:20 a.m.) Review request for mesos, Adam B, Alexande

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 14, 2016, 10 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 14, 2016, 9:58 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 14, 2016, 9:38 a.m., Adam B wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 63-64 > > > > > > Seems like you're changing the meaning of the parameters in > > `BasicAuthenticatorFa

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 14, 2016, 6:01 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review123389 --- src/authentication/http/basic_authenticator_factory.cpp (lines 63

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 14, 2016, 4:02 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 11, 2016, 2:52 p.m., Alexander Rojas wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 70-71 > > > > > > Wouldn't it be better to just get a `Credentials` object? > > > > Or

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review123144 --- src/authentication/http/basic_authenticator_factory.cpp (lines 70

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

> On March 11, 2016, 5:23 a.m., Alexander Rojas wrote: > > src/authentication/http/basic_authenticator_factory.cpp, lines 58-60 > > > > > > This is exactly the reason why I didn't do it this way, since now we > > can

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 11, 2016, 9:39 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review123102 --- src/authentication/http/basic_authenticator_factory.cpp (lines 58

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 10, 2016, 10:58 p.m.) Review request for mesos, Adam B, Alexande