Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 17, 2016, 8:34 p.m., Michael Park wrote: > > support/clang-format, line 3 > > > > > > Can we uncomment this? Our style by definition is > > > > > The Mesos codebase follows the Google C++ Style Guid

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 17, 2016, 4:09 p.m., Michael Park wrote: > > The patch looks good to me. Would you like to send an announcement email to > > the dev list about this upgrade? I can do it if you'd rather not. > > Yong Tang wrote: > Hi Michael, Thanks a lot for the help! I will send out the email t

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 17, 2016, 4:09 p.m., Michael Park wrote: > > The patch looks good to me. Would you like to send an announcement email to > > the dev list about this upgrade? I can do it if you'd rather not. Hi Michael, Thanks a lot for the help! I will send out the email to the dev list shortly.

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124090 --- Fix it, then Ship it! support/clang-format (line 3)

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 17, 2016, 8:34 p.m., Michael Park wrote: > > support/clang-format, line 3 > > > > > > Can we uncomment this? Our style by definition is > > > > > The Mesos codebase follows the Google C++ Style Guid

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 15, 2016, 9:24 p.m., Michael Park wrote: > > support/clang-format, lines 101-107 > > > > > > We can help out a little more here: > > > > The following code orders the headers: > > (1) C standa

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- (Updated March 17, 2016, 9:08 p.m.) Review request for mesos and Michael Park.

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review124038 --- Ship it! The patch looks good to me. Would you like to send an

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123836 --- Patch looks great! Reviews applied: [44758] Passed command: expo

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 15, 2016, 9:24 p.m., Michael Park wrote: > > support/clang-format, lines 101-107 > > > > > > We can help out a little more here: > > > > The following code orders the headers: > > (1) C standa

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- (Updated March 16, 2016, 1:37 a.m.) Review request for mesos and Michael Park.

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123734 --- Fix it, then Ship it! support/clang-format (lines 24 - 35)

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123349 --- Patch looks great! Reviews applied: [44758] Passed command: expo

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 13, 2016, 6:47 p.m., Benjamin Bannier wrote: > > support/clang-format, line 2 > > > > > > It would be great if you could use this opportunity and explicitly > > expand the values of the `Google` style we do

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- (Updated March 14, 2016, 1:09 a.m.) Review request for mesos and Michael Park.

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123323 --- support/clang-format (line 2)

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123296 --- Patch looks great! Reviews applied: [44758] Passed command: expo