Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

2016-05-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review132180 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/wind

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

2016-04-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review130277 --- Patch looks great! Reviews applied: [46009, 46010, 43985, 46447,

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

2016-04-23 Thread Alex Clemmer
> On April 22, 2016, 9:20 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/windows/winsock.hpp, lines 56-68 > > > > > > Why not use the `Once` pattern used for initialization in the rest of >

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

2016-04-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/ --- (Updated April 23, 2016, 9:50 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

2016-04-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review130185 --- 3rdparty/libprocess/include/process/windows/winsock.hpp (line 28)

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

2016-04-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46344/#review129435 --- Bad patch! Reviews applied: [46344, 46341, 46340, 46193, 46192, 4