Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/#review132180
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/windows/winsock.hpp (line 40)


Capture by reference, just don't store it by reference.


- Joris Van Remoortere


On April 23, 2016, 9:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46344/
> ---
> 
> (Updated April 23, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46344/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/#review130277
---



Patch looks great!

Reviews applied: [46009, 46010, 43985, 46447, 46285, 46293, 46013, 46014, 
46015, 46191, 46192, 46193, 46340, 46341, 46344]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 23, 2016, 9:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46344/
> ---
> 
> (Updated April 23, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46344/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Alex Clemmer]

> On April 22, 2016, 9:20 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/windows/winsock.hpp, lines 56-68
> > 
> >
> > Why not use the `Once` pattern used for initialization in the rest of 
> > the code base.
> > Take a look at `process.cpp`

I don't know what you had in mind, so I just `Once`'d the `initialize` 
function, and just made the destructor stupider (_i.e._, we no longer check 
that cleanup was successful).


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/#review130185
---


On April 23, 2016, 9:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46344/
> ---
> 
> (Updated April 23, 2016, 9:50 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46344/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/
---

(Updated April 23, 2016, 9:50 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-3656
https://issues.apache.org/jira/browse/MESOS-3656


Repository: mesos


Description
---

Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.


Diffs (updated)
-

  3rdparty/libprocess/include/Makefile.am 
47f5347988a61140c87bcd329e25d5a4d52e17a0 
  3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46344/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/#review130185
---




3rdparty/libprocess/include/process/windows/winsock.hpp (line 28)


brace on new line.



3rdparty/libprocess/include/process/windows/winsock.hpp (line 31)


no need for space between `{ }`



3rdparty/libprocess/include/process/windows/winsock.hpp (line 38)


can you put the initialization on a new line:
```
Class(
arg1,
arg2)
  : arg1(arg1)
{
}
```
brace on new line.



3rdparty/libprocess/include/process/windows/winsock.hpp (line 44)


brace on new line.



3rdparty/libprocess/include/process/windows/winsock.hpp (lines 49 - 51)


members below functions.



3rdparty/libprocess/include/process/windows/winsock.hpp (line 51)


holding a reference to a lambda like this that is not executed immediately 
is extremely dangerous.
Please take this by value.



3rdparty/libprocess/include/process/windows/winsock.hpp (line 56)


brace on new line.



3rdparty/libprocess/include/process/windows/winsock.hpp (lines 56 - 68)


Why not use the `Once` pattern used for initialization in the rest of the 
code base.
Take a look at `process.cpp`



3rdparty/libprocess/include/process/windows/winsock.hpp (line 74)


brace on new line.


- Joris Van Remoortere


On April 18, 2016, 7:21 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46344/
> ---
> 
> (Updated April 18, 2016, 7:21 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46344/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 46344: Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46344/#review129435
---



Bad patch!

Reviews applied: [46344, 46341, 46340, 46193, 46192, 46191, 46015, 46014, 
46013, 46012, 46293, 46285, 43985, 46010, 46009]

Failed command: ./support/apply-review.sh -n -r 46285

Error:
2016-04-18 21:08:15 URL:https://reviews.apache.org/r/46285/diff/raw/ 
[2127/2127] -> "46285.patch" [1]
error: patch failed: 3rdparty/libprocess/src/poll_socket.cpp:132
error: 3rdparty/libprocess/src/poll_socket.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12597/console

- Mesos ReviewBot


On April 18, 2016, 7:21 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46344/
> ---
> 
> (Updated April 18, 2016, 7:21 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-3656
> https://issues.apache.org/jira/browse/MESOS-3656
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: Created Winsock class to handle WSAStartup/WSACleanup.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> 47f5347988a61140c87bcd329e25d5a4d52e17a0 
>   3rdparty/libprocess/include/process/windows/winsock.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46344/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>