Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/ --- (Updated May 11, 2016, 5 p.m.) Review request for mesos, Alex Naparu, Daniel Pr

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-11 Thread Alex Clemmer
> On May 11, 2016, 9:11 a.m., Michael Park wrote: > > 3rdparty/libprocess/include/Makefile.am, line 48 > > > > > > This should be `process/posix/subprocess.hpp` Huh. I wonder how this happened. - Alex ---

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-11 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/#review132625 --- Fix it, then Ship it! 3rdparty/libprocess/include/Makefile.am

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/#review132242 --- Ship it! Ship It! - Michael Park On May 5, 2016, 3:35 p.m.,

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-05 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/ --- (Updated May 5, 2016, 3:35 p.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-05 Thread Alex Clemmer
> On April 27, 2016, 8:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 13-42 > > > > > > It seems like most of these are no longer necessary. Can we prune this > > a little bit, please?

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-05 Thread Alex Clemmer
> On April 27, 2016, 8:55 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 44-46 > > > > > > Doesn't look like we need these anymore. Update: We do need them in the new changeset. > On Ap

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-05-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/ --- (Updated May 3, 2016, 5:44 a.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-04-27 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/#review130841 --- 3rdparty/libprocess/src/subprocess.cpp (lines 13 - 42)

Re: Review Request 46423: Windows: Forked `subprocess.cpp`.

2016-04-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/ --- (Updated April 23, 2016, 11:40 p.m.) Review request for mesos, Alex Naparu, Dan