Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

> On Oct. 18, 2016, 11:22 a.m., Michael Park wrote:
> > I'll just make the adjustments below when I commit it. Please let me know 
> > if you're against any of them.

Thanks for the careful review. Your suggested adjustments are needed, +1.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review153055
---


On Oct. 18, 2016, 10:39 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> ---
> 
> (Updated Oct. 18, 2016, 10:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 94ac463110d7b83ee633fe32a6b66b0a8e181ba2 
>   src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
>   src/docker/executor.hpp 495fad5b1afbea829e7b87103d68dfa672a458cf 
>   src/examples/balloon_framework.cpp 50add6a16297383beefd312de212381b8f14fa8a 
>   src/examples/disk_full_framework.cpp 
> 78f13d34f183628372f925f450f76f250a5d81d1 
>   src/examples/dynamic_reservation_framework.cpp 
> c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
>   src/examples/load_generator_framework.cpp 
> 81c8c237dedd27615fe34ad629978a7359ee1efd 
>   src/examples/long_lived_framework.cpp 
> bfb253efbe80f52147123abdd804877c175e6f5e 
>   src/examples/no_executor_framework.cpp 
> 466854263cab96e764a3aedca5e59e54bdc6f500 
>   src/examples/persistent_volume_framework.cpp 
> a2a6944a8eed4fd72cc22e0628e38ac7f1a6260b 
>   src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
>   src/examples/test_http_framework.cpp 
> d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
>   src/launcher/executor.cpp dec1e07f8f55019b74bbc911a588083160202989 
>   src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
>   src/master/main.cpp 9d2fd92dbc2fc5af166edec907adbdb541eb0dd3 
>   src/slave/container_loggers/lib_logrotate.hpp 
> f91db3edc3d0cc93fedda906d175cbcca0c00c12 
>   src/slave/container_loggers/logrotate.hpp 
> f906a167f8897385af5f54e1e77cb790121a 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> c87e6715a3f00a6ed2f6da03bd7492f9e77ffc21 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 20fb6ab35ffa85917c6705d79f22f0d54a416353 
>   src/slave/containerizer/mesos/launch.cpp 
> 8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 
>   src/slave/containerizer/mesos/mount.cpp 
> 4b90666d9c75dadd70e6b690ca17fc5699825442 
>   src/slave/main.cpp 219914d594ace009201d9caf8209ca3dd4eaa1a5 
>   src/tests/active_user_test_helper.cpp 
> 80bd0acff47689be95a42bad3cb867e0faa68554 
>   src/tests/containerizer/capabilities_test_helper.cpp 
> 2d7be6ddaf4a5e687e928e4651df68ea9b234202 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> ---
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review153055
---


Fix it, then Ship it!




I'll just make the adjustments below when I commit it. Please let me know if 
you're against any of them.


src/examples/test_http_framework.cpp (lines 385 - 386)


`&::Flags::role` seems unnecessary. Let's just do `::role`



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1583 - 1586)


Seems like you missed this one.
I'll commit this as:
```
add(::hostname, "hostname", "Hostname of the container");
```



src/slave/main.cpp (lines 102 - 135)


Similar to above. `&::Flags::ip` seems unnecessary. Let's just do 
`::ip`


- Michael Park


On Oct. 18, 2016, 8:39 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> ---
> 
> (Updated Oct. 18, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 94ac463110d7b83ee633fe32a6b66b0a8e181ba2 
>   src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
>   src/docker/executor.hpp 495fad5b1afbea829e7b87103d68dfa672a458cf 
>   src/examples/balloon_framework.cpp 50add6a16297383beefd312de212381b8f14fa8a 
>   src/examples/disk_full_framework.cpp 
> 78f13d34f183628372f925f450f76f250a5d81d1 
>   src/examples/dynamic_reservation_framework.cpp 
> c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
>   src/examples/load_generator_framework.cpp 
> 81c8c237dedd27615fe34ad629978a7359ee1efd 
>   src/examples/long_lived_framework.cpp 
> bfb253efbe80f52147123abdd804877c175e6f5e 
>   src/examples/no_executor_framework.cpp 
> 466854263cab96e764a3aedca5e59e54bdc6f500 
>   src/examples/persistent_volume_framework.cpp 
> a2a6944a8eed4fd72cc22e0628e38ac7f1a6260b 
>   src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
>   src/examples/test_http_framework.cpp 
> d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
>   src/launcher/executor.cpp dec1e07f8f55019b74bbc911a588083160202989 
>   src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
>   src/master/main.cpp 9d2fd92dbc2fc5af166edec907adbdb541eb0dd3 
>   src/slave/container_loggers/lib_logrotate.hpp 
> f91db3edc3d0cc93fedda906d175cbcca0c00c12 
>   src/slave/container_loggers/logrotate.hpp 
> f906a167f8897385af5f54e1e77cb790121a 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> c87e6715a3f00a6ed2f6da03bd7492f9e77ffc21 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 20fb6ab35ffa85917c6705d79f22f0d54a416353 
>   src/slave/containerizer/mesos/launch.cpp 
> 8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 
>   src/slave/containerizer/mesos/mount.cpp 
> 4b90666d9c75dadd70e6b690ca17fc5699825442 
>   src/slave/main.cpp 219914d594ace009201d9caf8209ca3dd4eaa1a5 
>   src/tests/active_user_test_helper.cpp 
> 80bd0acff47689be95a42bad3cb867e0faa68554 
>   src/tests/containerizer/capabilities_test_helper.cpp 
> 2d7be6ddaf4a5e687e928e4651df68ea9b234202 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> ---
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

> On Oct. 18, 2016, 9:54 a.m., Michael Park wrote:
> > src/local/main.cpp, lines 48-63
> > 
> >
> > Is there a reason why we don't just add this directly to `local::Flags`?

`local::Flags` is used in some other places as well. Adding `port` or `ip` 
flags to it would surface these flags for all users, and I believe this is not 
what we want. Dropping this issue.


> On Oct. 18, 2016, 9:54 a.m., Michael Park wrote:
> > src/master/main.cpp, lines 123-208
> > 
> >
> > Similar to above, why don't we just add these to `master::Flags`?

`master::Flags` is also reused in many places. Dropping this issue.


> On Oct. 18, 2016, 9:54 a.m., Michael Park wrote:
> > src/slave/main.cpp, lines 97-151
> > 
> >
> > One more. Can we just add these to `slave::Flags`?

`slave::Flags` is also reused in many places. Dropping this issue.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review153049
---


On Oct. 18, 2016, 10:39 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> ---
> 
> (Updated Oct. 18, 2016, 10:39 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 94ac463110d7b83ee633fe32a6b66b0a8e181ba2 
>   src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
>   src/docker/executor.hpp 495fad5b1afbea829e7b87103d68dfa672a458cf 
>   src/examples/balloon_framework.cpp 50add6a16297383beefd312de212381b8f14fa8a 
>   src/examples/disk_full_framework.cpp 
> 78f13d34f183628372f925f450f76f250a5d81d1 
>   src/examples/dynamic_reservation_framework.cpp 
> c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
>   src/examples/load_generator_framework.cpp 
> 81c8c237dedd27615fe34ad629978a7359ee1efd 
>   src/examples/long_lived_framework.cpp 
> bfb253efbe80f52147123abdd804877c175e6f5e 
>   src/examples/no_executor_framework.cpp 
> 466854263cab96e764a3aedca5e59e54bdc6f500 
>   src/examples/persistent_volume_framework.cpp 
> a2a6944a8eed4fd72cc22e0628e38ac7f1a6260b 
>   src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
>   src/examples/test_http_framework.cpp 
> d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
>   src/launcher/executor.cpp dec1e07f8f55019b74bbc911a588083160202989 
>   src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
>   src/master/main.cpp 9d2fd92dbc2fc5af166edec907adbdb541eb0dd3 
>   src/slave/container_loggers/lib_logrotate.hpp 
> f91db3edc3d0cc93fedda906d175cbcca0c00c12 
>   src/slave/container_loggers/logrotate.hpp 
> f906a167f8897385af5f54e1e77cb790121a 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> c87e6715a3f00a6ed2f6da03bd7492f9e77ffc21 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 20fb6ab35ffa85917c6705d79f22f0d54a416353 
>   src/slave/containerizer/mesos/launch.cpp 
> 8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 
>   src/slave/containerizer/mesos/mount.cpp 
> 4b90666d9c75dadd70e6b690ca17fc5699825442 
>   src/slave/main.cpp 219914d594ace009201d9caf8209ca3dd4eaa1a5 
>   src/tests/active_user_test_helper.cpp 
> 80bd0acff47689be95a42bad3cb867e0faa68554 
>   src/tests/containerizer/capabilities_test_helper.cpp 
> 2d7be6ddaf4a5e687e928e4651df68ea9b234202 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> ---
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated Oct. 18, 2016, 10:39 a.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
---

Addressed mpark's comments.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 94ac463110d7b83ee633fe32a6b66b0a8e181ba2 
  src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
  src/docker/executor.hpp 495fad5b1afbea829e7b87103d68dfa672a458cf 
  src/examples/balloon_framework.cpp 50add6a16297383beefd312de212381b8f14fa8a 
  src/examples/disk_full_framework.cpp 78f13d34f183628372f925f450f76f250a5d81d1 
  src/examples/dynamic_reservation_framework.cpp 
c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
  src/examples/load_generator_framework.cpp 
81c8c237dedd27615fe34ad629978a7359ee1efd 
  src/examples/long_lived_framework.cpp 
bfb253efbe80f52147123abdd804877c175e6f5e 
  src/examples/no_executor_framework.cpp 
466854263cab96e764a3aedca5e59e54bdc6f500 
  src/examples/persistent_volume_framework.cpp 
a2a6944a8eed4fd72cc22e0628e38ac7f1a6260b 
  src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
  src/examples/test_http_framework.cpp d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
  src/launcher/executor.cpp dec1e07f8f55019b74bbc911a588083160202989 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 9d2fd92dbc2fc5af166edec907adbdb541eb0dd3 
  src/slave/container_loggers/lib_logrotate.hpp 
f91db3edc3d0cc93fedda906d175cbcca0c00c12 
  src/slave/container_loggers/logrotate.hpp 
f906a167f8897385af5f54e1e77cb790121a 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
c87e6715a3f00a6ed2f6da03bd7492f9e77ffc21 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
20fb6ab35ffa85917c6705d79f22f0d54a416353 
  src/slave/containerizer/mesos/launch.cpp 
8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 
  src/slave/containerizer/mesos/mount.cpp 
4b90666d9c75dadd70e6b690ca17fc5699825442 
  src/slave/main.cpp 219914d594ace009201d9caf8209ca3dd4eaa1a5 
  src/tests/active_user_test_helper.cpp 
80bd0acff47689be95a42bad3cb867e0faa68554 
  src/tests/containerizer/capabilities_test_helper.cpp 
2d7be6ddaf4a5e687e928e4651df68ea9b234202 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review153049
---




src/local/main.cpp (lines 48 - 63)


Is there a reason why we don't just add this directly to `local::Flags`?



src/master/main.cpp (lines 123 - 168)


Similar to above, why don't we just add these to `master::Flags`?



src/master/main.cpp (lines 179 - 182)


I'm not sure what this is?



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 1563 - 1590)


In most other places we seem to have opted to not specify the first part. 
e.g.,
```
ActiveUserTestHelper::Flags::Flags()
{
  add(::user,
  "user",
  "The expected user name.");
}
```



src/slave/main.cpp (lines 97 - 151)


One more. Can we just add these to `slave::Flags`?


- Michael Park


On Oct. 17, 2016, 3:24 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> ---
> 
> (Updated Oct. 17, 2016, 3:24 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 94ac463110d7b83ee633fe32a6b66b0a8e181ba2 
>   src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
>   src/docker/executor.hpp 495fad5b1afbea829e7b87103d68dfa672a458cf 
>   src/examples/balloon_framework.cpp 50add6a16297383beefd312de212381b8f14fa8a 
>   src/examples/disk_full_framework.cpp 
> 78f13d34f183628372f925f450f76f250a5d81d1 
>   src/examples/dynamic_reservation_framework.cpp 
> c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
>   src/examples/load_generator_framework.cpp 
> 81c8c237dedd27615fe34ad629978a7359ee1efd 
>   src/examples/long_lived_framework.cpp 
> bfb253efbe80f52147123abdd804877c175e6f5e 
>   src/examples/no_executor_framework.cpp 
> 466854263cab96e764a3aedca5e59e54bdc6f500 
>   src/examples/persistent_volume_framework.cpp 
> a2a6944a8eed4fd72cc22e0628e38ac7f1a6260b 
>   src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
>   src/examples/test_http_framework.cpp 
> d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
>   src/launcher/executor.cpp dec1e07f8f55019b74bbc911a588083160202989 
>   src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
>   src/master/main.cpp 9d2fd92dbc2fc5af166edec907adbdb541eb0dd3 
>   src/slave/container_loggers/lib_logrotate.hpp 
> f91db3edc3d0cc93fedda906d175cbcca0c00c12 
>   src/slave/container_loggers/logrotate.hpp 
> f906a167f8897385af5f54e1e77cb790121a 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 7c35c3056326a8a135e4ad944ac741cda96cab99 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 20fb6ab35ffa85917c6705d79f22f0d54a416353 
>   src/slave/containerizer/mesos/launch.cpp 
> 8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 
>   src/slave/containerizer/mesos/mount.cpp 
> 4b90666d9c75dadd70e6b690ca17fc5699825442 
>   src/slave/main.cpp 219914d594ace009201d9caf8209ca3dd4eaa1a5 
>   src/tests/active_user_test_helper.cpp 
> 80bd0acff47689be95a42bad3cb867e0faa68554 
>   src/tests/containerizer/capabilities_test_helper.cpp 
> 2d7be6ddaf4a5e687e928e4651df68ea9b234202 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> ---
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated Oct. 17, 2016, 5:24 p.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 94ac463110d7b83ee633fe32a6b66b0a8e181ba2 
  src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
  src/docker/executor.hpp 495fad5b1afbea829e7b87103d68dfa672a458cf 
  src/examples/balloon_framework.cpp 50add6a16297383beefd312de212381b8f14fa8a 
  src/examples/disk_full_framework.cpp 78f13d34f183628372f925f450f76f250a5d81d1 
  src/examples/dynamic_reservation_framework.cpp 
c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
  src/examples/load_generator_framework.cpp 
81c8c237dedd27615fe34ad629978a7359ee1efd 
  src/examples/long_lived_framework.cpp 
bfb253efbe80f52147123abdd804877c175e6f5e 
  src/examples/no_executor_framework.cpp 
466854263cab96e764a3aedca5e59e54bdc6f500 
  src/examples/persistent_volume_framework.cpp 
a2a6944a8eed4fd72cc22e0628e38ac7f1a6260b 
  src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
  src/examples/test_http_framework.cpp d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
  src/launcher/executor.cpp dec1e07f8f55019b74bbc911a588083160202989 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 9d2fd92dbc2fc5af166edec907adbdb541eb0dd3 
  src/slave/container_loggers/lib_logrotate.hpp 
f91db3edc3d0cc93fedda906d175cbcca0c00c12 
  src/slave/container_loggers/logrotate.hpp 
f906a167f8897385af5f54e1e77cb790121a 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
7c35c3056326a8a135e4ad944ac741cda96cab99 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
20fb6ab35ffa85917c6705d79f22f0d54a416353 
  src/slave/containerizer/mesos/launch.cpp 
8a30ff8bd6f9263d68a4344b79f2374a2ae53c04 
  src/slave/containerizer/mesos/mount.cpp 
4b90666d9c75dadd70e6b690ca17fc5699825442 
  src/slave/main.cpp 219914d594ace009201d9caf8209ca3dd4eaa1a5 
  src/tests/active_user_test_helper.cpp 
80bd0acff47689be95a42bad3cb867e0faa68554 
  src/tests/containerizer/capabilities_test_helper.cpp 
2d7be6ddaf4a5e687e928e4651df68ea9b234202 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated Oct. 6, 2016, 4:59 p.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp fcf627b0dcbedd01700cc8c9acadf7ba0dae4faa 
  src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
  src/docker/executor.hpp a49ec1b4045116741af6af08578791fb0440ad8f 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/disk_full_framework.cpp 1221f83d495f7c1ee1bcbcfe067e303db0a921eb 
  src/examples/dynamic_reservation_framework.cpp 
c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
3cc7cf0c4c97d90f2e70800d7a8d4ca64c2150d1 
  src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
  src/examples/test_http_framework.cpp d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
  src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e 
  src/slave/container_loggers/lib_logrotate.hpp 
a8653d716a898f03cce83f7b88b666dc46c0ea90 
  src/slave/container_loggers/logrotate.hpp 
f906a167f8897385af5f54e1e77cb790121a 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
d530a364567ae1fbfdcde921eb109acda6667c39 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
20fb6ab35ffa85917c6705d79f22f0d54a416353 
  src/slave/containerizer/mesos/launch.cpp 
7dd10d5030260fbfdf7396a7c05a52b7c3d983e8 
  src/slave/containerizer/mesos/mount.cpp 
4b90666d9c75dadd70e6b690ca17fc5699825442 
  src/slave/main.cpp 949a738ab3e44d8efc878e59c482a750ab41d1e4 
  src/tests/active_user_test_helper.cpp 
80bd0acff47689be95a42bad3cb867e0faa68554 
  src/tests/containerizer/capabilities_test_helper.cpp 
2d7be6ddaf4a5e687e928e4651df68ea9b234202 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

> On May 11, 2016, 11:27 p.m., Vinod Kone wrote:
> > src/master/main.cpp, line 131
> > 
> >
> > If `add` should be only called by derived classes, should `add` method 
> > be protected instead of public?
> 
> Benjamin Bannier wrote:
> I am not sure `add` should only be called from derived classes, and since 
> we force callers to pass in a member variable pointer these usages appear 
> fine to me. Since most (all?) calls to `add` are from classes derived from 
> `FlagsBase` making it `protected` instead of `public` would be possible, but 
> I wouldn't be sure why that would be needed. It might also potentially make 
> some valid use cases impossible.

Dropping this thightening up the interfacce of `FlagsBase` is out of scope for 
this changeset.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review132750
---


On Sept. 29, 2016, 2:55 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> ---
> 
> (Updated Sept. 29, 2016, 2:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Michael Park.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp fcf627b0dcbedd01700cc8c9acadf7ba0dae4faa 
>   src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
>   src/docker/executor.hpp a49ec1b4045116741af6af08578791fb0440ad8f 
>   src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
>   src/examples/disk_full_framework.cpp 
> 1221f83d495f7c1ee1bcbcfe067e303db0a921eb 
>   src/examples/dynamic_reservation_framework.cpp 
> c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
>   src/examples/load_generator_framework.cpp 
> 5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
>   src/examples/long_lived_framework.cpp 
> 7c57eb5e4a34208504475013690ae8e3cae74155 
>   src/examples/no_executor_framework.cpp 
> 57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
>   src/examples/persistent_volume_framework.cpp 
> 3cc7cf0c4c97d90f2e70800d7a8d4ca64c2150d1 
>   src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
>   src/examples/test_http_framework.cpp 
> d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
>   src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 
>   src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
>   src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e 
>   src/slave/container_loggers/lib_logrotate.hpp 
> a8653d716a898f03cce83f7b88b666dc46c0ea90 
>   src/slave/container_loggers/logrotate.hpp 
> f906a167f8897385af5f54e1e77cb790121a 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 1ee56cfa77a6b82f43882ab40d991c1937b5bd63 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 01355a15a4586c4afd052251548872a6f071b42d 
>   src/slave/containerizer/mesos/launch.cpp 
> 7cc0c3f46fe1a5883b7ccd474595b8be412b355c 
>   src/slave/containerizer/mesos/mount.cpp 
> dbd7853a43ee1402f2f91d933a657010efdd76b0 
>   src/slave/main.cpp 949a738ab3e44d8efc878e59c482a750ab41d1e4 
>   src/tests/active_user_test_helper.cpp 
> 80bd0acff47689be95a42bad3cb867e0faa68554 
>   src/tests/containerizer/capabilities_test_helper.cpp 
> 2d7be6ddaf4a5e687e928e4651df68ea9b234202 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> ---
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated Sept. 29, 2016, 2:55 p.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp fcf627b0dcbedd01700cc8c9acadf7ba0dae4faa 
  src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
  src/docker/executor.hpp a49ec1b4045116741af6af08578791fb0440ad8f 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/disk_full_framework.cpp 1221f83d495f7c1ee1bcbcfe067e303db0a921eb 
  src/examples/dynamic_reservation_framework.cpp 
c9a68637ea2dfbb0a9367f14358b5e5de46f3331 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
3cc7cf0c4c97d90f2e70800d7a8d4ca64c2150d1 
  src/examples/test_framework.cpp a9106404bd5f63ac7b3f76c7368dcf5b02128a9d 
  src/examples/test_http_framework.cpp d6e248cd1e7776b5e63764f1d1740d3e29dcfaa4 
  src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e 
  src/slave/container_loggers/lib_logrotate.hpp 
a8653d716a898f03cce83f7b88b666dc46c0ea90 
  src/slave/container_loggers/logrotate.hpp 
f906a167f8897385af5f54e1e77cb790121a 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
1ee56cfa77a6b82f43882ab40d991c1937b5bd63 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
01355a15a4586c4afd052251548872a6f071b42d 
  src/slave/containerizer/mesos/launch.cpp 
7cc0c3f46fe1a5883b7ccd474595b8be412b355c 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp 949a738ab3e44d8efc878e59c482a750ab41d1e4 
  src/tests/active_user_test_helper.cpp 
80bd0acff47689be95a42bad3cb867e0faa68554 
  src/tests/containerizer/capabilities_test_helper.cpp 
2d7be6ddaf4a5e687e928e4651df68ea9b234202 

Diff: https://reviews.apache.org/r/46824/diff/


Testing (updated)
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated Aug. 30, 2016, 4:36 p.m.)


Review request for mesos, Alexander Rukletsov and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 
  src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/disk_full_framework.cpp 1221f83d495f7c1ee1bcbcfe067e303db0a921eb 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
3cc7cf0c4c97d90f2e70800d7a8d4ca64c2150d1 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp 441e86c88b035d9a268b8b51b95da3e1eb842a62 
  src/launcher/executor.cpp 5370634ef9e6f3ac9717fed71f6a77707026a16a 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e 
  src/slave/container_loggers/lib_logrotate.hpp 
f216548ef37f5c2245ef64d21e84e06100e8e5ae 
  src/slave/container_loggers/logrotate.hpp 
96697d46ca71e7f62119f2fe669230cf5a04242f 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
d17a45fe17bb74cbf9ae421dc8a492e5dc5f1a00 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
55a06cfe1edbb7699c04101f78cc4979176e33f6 
  src/slave/containerizer/mesos/launch.cpp 
13b65d82e029650e150eb2bc3647d95af167bd72 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp 8c9d241890ffa85f88096385e07789e6fc945ddb 
  src/tests/active_user_test_helper.cpp 
80bd0acff47689be95a42bad3cb867e0faa68554 
  src/tests/containerizer/capabilities_test_helper.cpp 
f982dbd92a08e3fd2af48e90d98dbbd7e28ca583 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated Aug. 11, 2016, 6:32 p.m.)


Review request for mesos, Alexander Rukletsov, Michael Park, and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 
  src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/disk_full_framework.cpp ad304fee94d443125a0dec2b2820267c69508621 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp 441e86c88b035d9a268b8b51b95da3e1eb842a62 
  src/launcher/executor.cpp 7967684e42c97326770bd83a41c2d4b1338a511f 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e 
  src/slave/container_loggers/lib_logrotate.hpp 
f216548ef37f5c2245ef64d21e84e06100e8e5ae 
  src/slave/container_loggers/logrotate.hpp 
96697d46ca71e7f62119f2fe669230cf5a04242f 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
760d32bf3dc09f3b715b378f5ded41556f15fe41 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
92f3c07e285ad3b8ef26692aa6475d755188b469 
  src/slave/containerizer/mesos/launch.cpp 
2db8db5ac2f4614d406b950a1b4e8098a0d90e7b 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp 8c9d241890ffa85f88096385e07789e6fc945ddb 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

> On May 11, 2016, 11:27 p.m., Vinod Kone wrote:
> > src/local/main.cpp, lines 52-53
> > 
> >
> > why the need for "::" prefix here?

There appears to be no need for it; remove here and elsewhere.


> On May 11, 2016, 11:27 p.m., Vinod Kone wrote:
> > src/master/main.cpp, lines 229-245
> > 
> >
> > where is this code moved from and why?

This seems to have slipped in when rebasing. Thanks for the careful review.


> On May 11, 2016, 11:27 p.m., Vinod Kone wrote:
> > src/master/main.cpp, line 131
> > 
> >
> > If `add` should be only called by derived classes, should `add` method 
> > be protected instead of public?

I am not sure `add` should only be called from derived classes, and since we 
force callers to pass in a member variable pointer these usages appear fine to 
me. Since most (all?) calls to `add` are from classes derived from `FlagsBase` 
making it `protected` instead of `public` would be possible, but I wouldn't be 
sure why that would be needed. It might also potentially make some valid use 
cases impossible.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review132750
---


On July 5, 2016, 10:33 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> ---
> 
> (Updated July 5, 2016, 10:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 18c2e3449bf5e50bea0bbd0a92efa20fc8b9032b 
>   src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 
>   src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
>   src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
>   src/examples/dynamic_reservation_framework.cpp 
> 850bb2a5b243dd5d5a8b6476570b4f943fde6185 
>   src/examples/load_generator_framework.cpp 
> 5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
>   src/examples/long_lived_framework.cpp 
> 7c57eb5e4a34208504475013690ae8e3cae74155 
>   src/examples/no_executor_framework.cpp 
> 57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
>   src/examples/persistent_volume_framework.cpp 
> fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
>   src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
>   src/examples/test_http_framework.cpp 
> cf6baed07c862ccade080618f33cc921fc09415d 
>   src/launcher/executor.cpp 5a5f95f04a6ce096079b67397cb324575409f795 
>   src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
>   src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
>   src/slave/container_loggers/logrotate.hpp 
> 16d92322079a69d8e6bed7830623c62f345cd51c 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 92b33111799cb4e1c8bc2051381e1254d701d95c 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 79ee960aa70f8bd39f9bf639cc54f6395ff21ad5 
>   src/slave/containerizer/mesos/launch.cpp 
> 09733abc9b0ecc599efb114af8231c31c7ec6ffc 
>   src/slave/containerizer/mesos/mount.cpp 
> dbd7853a43ee1402f2f91d933a657010efdd76b0 
>   src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> ---
> 
> Tested on various platforms in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated July 5, 2016, 10:33 a.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Addressed review comments.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 18c2e3449bf5e50bea0bbd0a92efa20fc8b9032b 
  src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp cf6baed07c862ccade080618f33cc921fc09415d 
  src/launcher/executor.cpp 5a5f95f04a6ce096079b67397cb324575409f795 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
92b33111799cb4e1c8bc2051381e1254d701d95c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
79ee960aa70f8bd39f9bf639cc54f6395ff21ad5 
  src/slave/containerizer/mesos/launch.cpp 
09733abc9b0ecc599efb114af8231c31c7ec6ffc 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated July 5, 2016, 9:41 a.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 18c2e3449bf5e50bea0bbd0a92efa20fc8b9032b 
  src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp cf6baed07c862ccade080618f33cc921fc09415d 
  src/launcher/executor.cpp 5a5f95f04a6ce096079b67397cb324575409f795 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
92b33111799cb4e1c8bc2051381e1254d701d95c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
79ee960aa70f8bd39f9bf639cc54f6395ff21ad5 
  src/slave/containerizer/mesos/launch.cpp 
09733abc9b0ecc599efb114af8231c31c7ec6ffc 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated July 5, 2016, 1:13 a.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Fixed missed new uses under Linux.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 18c2e3449bf5e50bea0bbd0a92efa20fc8b9032b 
  src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp cf6baed07c862ccade080618f33cc921fc09415d 
  src/launcher/executor.cpp 5a5f95f04a6ce096079b67397cb324575409f795 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
92b33111799cb4e1c8bc2051381e1254d701d95c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
79ee960aa70f8bd39f9bf639cc54f6395ff21ad5 
  src/slave/containerizer/mesos/launch.cpp 
09733abc9b0ecc599efb114af8231c31c7ec6ffc 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated July 4, 2016, 2:41 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 18c2e3449bf5e50bea0bbd0a92efa20fc8b9032b 
  src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp cf6baed07c862ccade080618f33cc921fc09415d 
  src/launcher/executor.cpp 63010252ffd6b1dfbe3358a1f1f4447967b824d2 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
92b33111799cb4e1c8bc2051381e1254d701d95c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
25d2a57d7a814d735db78bda8c6956199de5c390 
  src/slave/containerizer/mesos/launch.cpp 
83f4d7f28c066a605aa84862eca9fde900ec96c6 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated July 3, 2016, 5:22 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 18c2e3449bf5e50bea0bbd0a92efa20fc8b9032b 
  src/cli/resolve.cpp ac6be05e64c5e66703081068d992ebb0d6ca6c70 
  src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 
  src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/load_generator_framework.cpp 
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c 
  src/examples/long_lived_framework.cpp 
7c57eb5e4a34208504475013690ae8e3cae74155 
  src/examples/no_executor_framework.cpp 
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852 
  src/examples/persistent_volume_framework.cpp 
fe2837cfffb6dd251ccb9c93197f623d0c55fb36 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp cf6baed07c862ccade080618f33cc921fc09415d 
  src/launcher/executor.cpp 63010252ffd6b1dfbe3358a1f1f4447967b824d2 
  src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148 
  src/master/main.cpp 84f3b0723fd3df02386c8072ded3cb42272cd065 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
92b33111799cb4e1c8bc2051381e1254d701d95c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
25d2a57d7a814d735db78bda8c6956199de5c390 
  src/slave/containerizer/mesos/launch.cpp 
83f4d7f28c066a605aa84862eca9fde900ec96c6 
  src/slave/containerizer/mesos/mount.cpp 
dbd7853a43ee1402f2f91d933a657010efdd76b0 
  src/slave/main.cpp a7ed669a0b6861d6ce8546dfafac849044a77eec 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/#review132750
---




src/examples/test_http_framework.cpp (line 381)


2 blank lines.



src/local/main.cpp (lines 52 - 53)


why the need for "::" prefix here?



src/master/main.cpp (line 127)


If `add` should be only called by derived classes, should `add` method be 
protected instead of public?



src/master/main.cpp (lines 207 - 223)


where is this code moved from and why?



src/slave/main.cpp (line 97)


why "::" prefix?


- Vinod Kone


On May 11, 2016, 12:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46824/
> ---
> 
> (Updated May 11, 2016, 12:14 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> While right now we can technically `add` variables to `Flags` classes
> which are not members, the in order to have correct copy semantics for
> `Flags` only member variables should be used.
> 
> Here we changed all instances to a full pointer-to-member syntax in
> the current code.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
>   src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
>   src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/load_generator_framework.cpp 
> b22a09e1749d4b523addacad99858d7b6bde3403 
>   src/examples/long_lived_framework.cpp 
> 1740d7cb747d179d06e75153aa334b29e9cdf3c0 
>   src/examples/no_executor_framework.cpp 
> f578edfd99f3b7adf19cf06eab20696532c7b67d 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
>   src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
>   src/launcher/http_command_executor.cpp 
> c62fe3ee6ae06536cbb89ea208b669790efe4b39 
>   src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
>   src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
>   src/slave/container_loggers/logrotate.hpp 
> 16d92322079a69d8e6bed7830623c62f345cd51c 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> ad792def2bb3a1614d21ca28d858e400d2e3ede1 
>   src/slave/containerizer/mesos/launch.cpp 
> e22106b014c871e2184a15c2ab154a0674874e47 
>   src/slave/containerizer/mesos/mount.cpp 
> bf17b015e45579882fd31248e8609eec6d58a9da 
>   src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
> 
> Diff: https://reviews.apache.org/r/46824/diff/
> 
> 
> Testing
> ---
> 
> Tested on various platforms in internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated May 11, 2016, 2:14 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/http_command_executor.cpp 
c62fe3ee6ae06536cbb89ea208b669790efe4b39 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
ad792def2bb3a1614d21ca28d858e400d2e3ede1 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
---

(Updated April 29, 2016, 1:12 p.m.)


Review request for mesos, Alexander Rukletsov and Vinod Kone.


Changes
---

Fixup.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.

Here we changed all instances to a full pointer-to-member syntax in
the current code.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.hpp 798ca3d4e261854a3b911d59929f2ca2afeb9ac8 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/slave/container_loggers/lib_logrotate.hpp 
8c5602da3e5ff7bcf758da61723b7a0ea00a6a6e 
  src/slave/container_loggers/logrotate.hpp 
16d92322079a69d8e6bed7830623c62f345cd51c 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 
  src/slave/containerizer/mesos/mount.cpp 
bf17b015e45579882fd31248e8609eec6d58a9da 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 

Diff: https://reviews.apache.org/r/46824/diff/


Testing
---

Tested on various platforms in internal CI.


Thanks,

Benjamin Bannier