Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-30 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/#review135595
---


Ship it!




Ship It!

- Joris Van Remoortere


On May 30, 2016, 4:55 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47576/
> ---
> 
> (Updated May 30, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
> MESOS-3681, MESOS-3682, and MESOS-3684
> https://issues.apache.org/jira/browse/MESOS-3617
> https://issues.apache.org/jira/browse/MESOS-3618
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3622
> https://issues.apache.org/jira/browse/MESOS-3623
> https://issues.apache.org/jira/browse/MESOS-3624
> https://issues.apache.org/jira/browse/MESOS-3681
> https://issues.apache.org/jira/browse/MESOS-3682
> https://issues.apache.org/jira/browse/MESOS-3684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Add Windows support to the containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/fetcher.cpp 
> 176d8863d1becd8864218a0012ab45c614f0ad77 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b154587628a5bf4b1366dbd7a281177e6aa6eb57 
>   src/slave/containerizer/mesos/launcher.hpp 
> 5977c30c0aacc569019f7b34bb0c6577823ec887 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
> 
> Diff: https://reviews.apache.org/r/47576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-30 Thread Joris Van Remoortere 


> On May 31, 2016, 5:08 a.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 1233-1239
> > 
> >
> > Do these get stored correctly since `launchFlags.pipe_xxx` is an int?
> > This same problem applies for when we write them.

This seems to be working because the `HANDLE`s have low values in basic 
environments.
We'll need to find a more robust solution to this beyond the MVP.


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/#review135590
---


On May 30, 2016, 4:55 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47576/
> ---
> 
> (Updated May 30, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
> MESOS-3681, MESOS-3682, and MESOS-3684
> https://issues.apache.org/jira/browse/MESOS-3617
> https://issues.apache.org/jira/browse/MESOS-3618
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3622
> https://issues.apache.org/jira/browse/MESOS-3623
> https://issues.apache.org/jira/browse/MESOS-3624
> https://issues.apache.org/jira/browse/MESOS-3681
> https://issues.apache.org/jira/browse/MESOS-3682
> https://issues.apache.org/jira/browse/MESOS-3684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Add Windows support to the containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/fetcher.cpp 
> 176d8863d1becd8864218a0012ab45c614f0ad77 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b154587628a5bf4b1366dbd7a281177e6aa6eb57 
>   src/slave/containerizer/mesos/launcher.hpp 
> 5977c30c0aacc569019f7b34bb0c6577823ec887 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
> 
> Diff: https://reviews.apache.org/r/47576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-30 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/#review135590
---




src/slave/containerizer/mesos/containerizer.cpp (line 1184)


why not `int pipes[2]`?



src/slave/containerizer/mesos/containerizer.cpp (lines 1186 - 1191)


we can just keep the `CHECK_SOME` behavior.



src/slave/containerizer/mesos/containerizer.cpp (lines 1232 - 1238)


Do these get stored correctly since `launchFlags.pipe_xxx` is an int?
This same problem applies for when we write them.


- Joris Van Remoortere


On May 30, 2016, 4:55 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47576/
> ---
> 
> (Updated May 30, 2016, 4:55 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
> MESOS-3681, MESOS-3682, and MESOS-3684
> https://issues.apache.org/jira/browse/MESOS-3617
> https://issues.apache.org/jira/browse/MESOS-3618
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3622
> https://issues.apache.org/jira/browse/MESOS-3623
> https://issues.apache.org/jira/browse/MESOS-3624
> https://issues.apache.org/jira/browse/MESOS-3681
> https://issues.apache.org/jira/browse/MESOS-3682
> https://issues.apache.org/jira/browse/MESOS-3684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Add Windows support to the containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/fetcher.cpp 
> 176d8863d1becd8864218a0012ab45c614f0ad77 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b154587628a5bf4b1366dbd7a281177e6aa6eb57 
>   src/slave/containerizer/mesos/launcher.hpp 
> 5977c30c0aacc569019f7b34bb0c6577823ec887 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
> 
> Diff: https://reviews.apache.org/r/47576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-30 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 30, 2016, 4:55 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/containerizer/mesos/containerizer.cpp 
b154587628a5bf4b1366dbd7a281177e6aa6eb57 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 29, 2016, 5:31 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/containerizer/mesos/containerizer.cpp 
b154587628a5bf4b1366dbd7a281177e6aa6eb57 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 29, 2016, 3:35 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/containerizer/mesos/containerizer.cpp 
b154587628a5bf4b1366dbd7a281177e6aa6eb57 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 29, 2016, 2:30 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/containerizer/mesos/containerizer.cpp 
b154587628a5bf4b1366dbd7a281177e6aa6eb57 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 29, 2016, 2:12 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/containerizer/mesos/containerizer.cpp 
b154587628a5bf4b1366dbd7a281177e6aa6eb57 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 28, 2016, 10:28 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/containerizer/mesos/containerizer.cpp 
b154587628a5bf4b1366dbd7a281177e6aa6eb57 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-28 Thread Alex Clemmer 


> On May 24, 2016, 11:37 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/launcher.hpp, lines 118-119
> > 
> >
> > Is this the only difference?
> > It would be great if we could clearly identify the differences, and 
> > reference a JIRA here to keep track of them.
> 
> Alex Clemmer wrote:
> I'm not sure how to capture this. There are too many differences to name.

I will drop this comment. Feel free to re-open if is not right.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/#review134662
---


On May 28, 2016, 3:17 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47576/
> ---
> 
> (Updated May 28, 2016, 3:17 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
> MESOS-3681, MESOS-3682, and MESOS-3684
> https://issues.apache.org/jira/browse/MESOS-3617
> https://issues.apache.org/jira/browse/MESOS-3618
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3622
> https://issues.apache.org/jira/browse/MESOS-3623
> https://issues.apache.org/jira/browse/MESOS-3624
> https://issues.apache.org/jira/browse/MESOS-3681
> https://issues.apache.org/jira/browse/MESOS-3682
> https://issues.apache.org/jira/browse/MESOS-3684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Add Windows support to the containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/fetcher.cpp 
> 176d8863d1becd8864218a0012ab45c614f0ad77 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b154587628a5bf4b1366dbd7a281177e6aa6eb57 
>   src/slave/containerizer/mesos/launcher.hpp 
> 5977c30c0aacc569019f7b34bb0c6577823ec887 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
> 
> Diff: https://reviews.apache.org/r/47576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-27 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 28, 2016, 3:17 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/containerizer/mesos/containerizer.cpp 
b154587628a5bf4b1366dbd7a281177e6aa6eb57 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-27 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 28, 2016, 2:17 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Changes
---

master rebased


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 52caf9fe34b1a78efbec2a82d03c04a066690fad 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/containerizer/mesos/containerizer.cpp 
b154587628a5bf4b1366dbd7a281177e6aa6eb57 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-26 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 27, 2016, 5:37 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-26 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/
---

(Updated May 26, 2016, 3:02 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
MESOS-3681, MESOS-3682, and MESOS-3684
https://issues.apache.org/jira/browse/MESOS-3617
https://issues.apache.org/jira/browse/MESOS-3618
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3622
https://issues.apache.org/jira/browse/MESOS-3623
https://issues.apache.org/jira/browse/MESOS-3624
https://issues.apache.org/jira/browse/MESOS-3681
https://issues.apache.org/jira/browse/MESOS-3682
https://issues.apache.org/jira/browse/MESOS-3684


Repository: mesos


Description
---

Agent: Add Windows support to the containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/mesos/containerizer.cpp 
75e5a32a3e70ec60a6800e21a621673184ea0956 
  src/slave/containerizer/mesos/launcher.hpp 
5977c30c0aacc569019f7b34bb0c6577823ec887 
  src/slave/containerizer/mesos/launcher.cpp 
a5c8c31b72773d0bd10b9d02675a01f1d641d41c 

Diff: https://reviews.apache.org/r/47576/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-26 Thread Alex Clemmer 


> On May 24, 2016, 11:37 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 286-288
> > 
> >
> > Quick comment saying that the network isolator is currently not 
> > supported on windows.
> > 
> > Can you add (and reference in the comment) a JIRA to update the 
> > autoconf to catch this case during configure?

Why do we need to catch this in the AC builds? Mesos doesn't build on Windows 
in AC.


> On May 24, 2016, 11:37 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/launcher.hpp, lines 118-119
> > 
> >
> > Is this the only difference?
> > It would be great if we could clearly identify the differences, and 
> > reference a JIRA here to keep track of them.

I'm not sure how to capture this. There are too many differences to name.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/#review134662
---


On May 19, 2016, 2:47 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47576/
> ---
> 
> (Updated May 19, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
> MESOS-3681, MESOS-3682, and MESOS-3684
> https://issues.apache.org/jira/browse/MESOS-3617
> https://issues.apache.org/jira/browse/MESOS-3618
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3622
> https://issues.apache.org/jira/browse/MESOS-3623
> https://issues.apache.org/jira/browse/MESOS-3624
> https://issues.apache.org/jira/browse/MESOS-3681
> https://issues.apache.org/jira/browse/MESOS-3682
> https://issues.apache.org/jira/browse/MESOS-3684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Add Windows support to the containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
>   src/slave/containerizer/mesos/launcher.hpp 
> 5977c30c0aacc569019f7b34bb0c6577823ec887 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
> 
> Diff: https://reviews.apache.org/r/47576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-24 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/#review134662
---




src/slave/containerizer/docker.cpp (line 251)


Please us `os::chown` in the comment here to be consistent with your 
previous comments.

Same with the other comments in this review.



src/slave/containerizer/external_containerizer.cpp (lines 641 - 645)


Can we please flip this to have the windows version come second?
Same below.



src/slave/containerizer/mesos/containerizer.cpp (line 59)


Why are we not using quotes like all the other lines?



src/slave/containerizer/mesos/containerizer.cpp (lines 285 - 287)


Quick comment saying that the network isolator is currently not supported 
on windows.

Can you add (and reference in the comment) a JIRA to update the autoconf to 
catch this case during configure?



src/slave/containerizer/mesos/containerizer.cpp (lines 1170 - 1174)


Update once we re-organize to `os::pipe`.



src/slave/containerizer/mesos/launcher.hpp (lines 117 - 118)


need an extra new line



src/slave/containerizer/mesos/launcher.hpp (lines 118 - 119)


Is this the only difference?
It would be great if we could clearly identify the differences, and 
reference a JIRA here to keep track of them.


- Joris Van Remoortere


On May 19, 2016, 2:47 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47576/
> ---
> 
> (Updated May 19, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
> MESOS-3681, MESOS-3682, and MESOS-3684
> https://issues.apache.org/jira/browse/MESOS-3617
> https://issues.apache.org/jira/browse/MESOS-3618
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3622
> https://issues.apache.org/jira/browse/MESOS-3623
> https://issues.apache.org/jira/browse/MESOS-3624
> https://issues.apache.org/jira/browse/MESOS-3681
> https://issues.apache.org/jira/browse/MESOS-3682
> https://issues.apache.org/jira/browse/MESOS-3684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Add Windows support to the containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
>   src/slave/containerizer/mesos/launcher.hpp 
> 5977c30c0aacc569019f7b34bb0c6577823ec887 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
> 
> Diff: https://reviews.apache.org/r/47576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47576: Agent: Add Windows support to the containerizer.

2016-05-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47576/#review133866
---



Bad patch!

Reviews applied: [47576, 47536, 47472, 47471, 47470, 47469, 47468, 47412, 
47411, 47410, 47409, 47404, 47403, 47391, 47390, 47389, 47388, 47387, 47386, 
47169, 47168, 41632, 47054, 47221, 47053, 47052]

Failed command: ./support/apply-review.sh -n -r 47471

Error:
2016-05-19 03:14:04 URL:https://reviews.apache.org/r/47471/diff/raw/ 
[5804/5804] -> "47471.patch" [1]
error: patch failed: src/exec/exec.cpp:595
error: src/exec/exec.cpp: patch does not apply
error: patch failed: src/executor/executor.cpp:154
error: src/executor/executor.cpp: patch does not apply
error: patch failed: src/launcher/fetcher.cpp:443
error: src/launcher/fetcher.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13160/console

- Mesos ReviewBot


On May 19, 2016, 2:47 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47576/
> ---
> 
> (Updated May 19, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3617, MESOS-3618, MESOS-3619, MESOS-3622, MESOS-3623, MESOS-3624, 
> MESOS-3681, MESOS-3682, and MESOS-3684
> https://issues.apache.org/jira/browse/MESOS-3617
> https://issues.apache.org/jira/browse/MESOS-3618
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3622
> https://issues.apache.org/jira/browse/MESOS-3623
> https://issues.apache.org/jira/browse/MESOS-3624
> https://issues.apache.org/jira/browse/MESOS-3681
> https://issues.apache.org/jira/browse/MESOS-3682
> https://issues.apache.org/jira/browse/MESOS-3684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Add Windows support to the containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
>   src/slave/containerizer/external_containerizer.cpp 
> cf4384cce44172a028c890f52f71ceb8ae109383 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
>   src/slave/containerizer/mesos/launcher.hpp 
> 5977c30c0aacc569019f7b34bb0c6577823ec887 
>   src/slave/containerizer/mesos/launcher.cpp 
> a5c8c31b72773d0bd10b9d02675a01f1d641d41c 
> 
> Diff: https://reviews.apache.org/r/47576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>