Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-16 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review149299 --- Ship it! src/common/resources.cpp (line 1099)

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review149040 --- Patch looks great! Reviews applied: [51683] Passed command: expo

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/ --- (Updated 九月 15, 2016, 8:48 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148995 --- Fix it, then Ship it! src/cli/execute.cpp (line 379)

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148926 --- Patch looks great! Reviews applied: [51683] Passed command: expo

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/ --- (Updated 九月 14, 2016, 6:09 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148416 --- Patch looks great! Reviews applied: [51683] Passed command: expo

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/ --- (Updated 九月 11, 2016, 3:04 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-10 Thread Guangya Liu
> On 九月 10, 2016, 7:35 a.m., Jiang Yan Xu wrote: > > src/cli/execute.cpp, line 377 > > > > > > In the places where it's not **obvious** (i.e., the arguments are > > locally defined) that the role/reservation **must

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148302 --- include/mesos/resources.hpp (lines 351 - 352)

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148167 --- Patch looks great! Reviews applied: [51683] Passed command: expo

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/ --- (Updated 九月 8, 2016, 6:31 a.m.) Review request for mesos, Benjamin Mahler and J

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-07 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148109 --- Summarize the behavioral change in the summary? i.e., previously i

Re: Review Request 51683: Avoided resource validation when flatten resources.

2016-09-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148000 --- Patch looks great! Reviews applied: [51683] Passed command: expo