Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

2017-12-04 Thread Joseph Wu
> On Dec. 4, 2017, 1:36 p.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 376 (patched) > > > > > > I cannot see where `BUILD_FLAGS_RAW` is actually set. Is the intention > > of the user

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

2017-12-04 Thread Andrew Schwartzmeyer
> On Dec. 4, 2017, 1:36 p.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 376 (patched) > > > > > > I cannot see where `BUILD_FLAGS_RAW` is actually set. Is the intention > > of the user

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

2017-12-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/#review192768 --- cmake/CompilationConfigure.cmake Lines 376 (patched)

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

2017-12-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/#review192766 --- Ship it! Ship It! - Joseph Wu On Dec. 4, 2017, 1:19 p.m.,

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

2017-12-04 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/ --- (Updated Dec. 4, 2017, 1:19 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

2017-11-06 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63341/ --- (Updated Nov. 6, 2017, 10:34 a.m.) Review request for mesos, Jeff Coffler,