Re: Review Request 63915: Reduced tasks copying during agent reregistration.

2017-12-06 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/ --- (Updated Dec. 6, 2017, 6:31 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

2017-12-06 Thread Michael Park
> On Dec. 4, 2017, 11:37 a.m., Michael Park wrote: > > src/master/master.hpp > > Line 128 (original), 128 (patched) > > > > > > Maybe we can consider making this `vector&&` as discussed in > >

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

2017-12-05 Thread Dmitry Zhuk
> On Dec. 4, 2017, 7:37 p.m., Michael Park wrote: > > src/master/master.hpp > > Line 128 (original), 128 (patched) > > > > > > Maybe we can consider making this `vector&&` as discussed in > >

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

2017-12-04 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review192815 --- FAIL: Failed to apply the dependent review: 63630. Failed

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

2017-12-04 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review192763 --- Ship it! Very happy to see this! Looks good, modulo mpark's

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

2017-12-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review192746 --- Fix it, then Ship it! src/master/master.hpp Line 128

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

2017-11-21 Thread Dmitry Zhuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/ --- (Updated Nov. 21, 2017, 5:53 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

2017-11-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review191369 --- FAIL: mesos-java failed to build. Reviews applied: `['63628',