Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-23 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199862
---




src/master/master.cpp
Lines 6027 (patched)


Note: we'll need to remove this CHECK when Zhitao's changes for grow/shrink 
are merged.


- Greg Mann


On March 22, 2018, 6:26 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated March 22, 2018, 6:26 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f84089e6dcf366716b779f7eff227d1f96d7abda 
>   src/master/master.hpp 7e5d1df1ecb5a0db15782b2480fb7029f8a93ee2 
>   src/master/master.cpp 390fbe9fe71981101ed2bd9a1f1b21b0e3727b7b 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/10/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-22 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
---

(Updated March 22, 2018, 11:26 a.m.)


Review request for mesos, Greg Mann and Zhitao Li.


Changes
---

Rebased.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.


Diffs (updated)
-

  src/master/http.cpp f84089e6dcf366716b779f7eff227d1f96d7abda 
  src/master/master.hpp 7e5d1df1ecb5a0db15782b2480fb7029f8a93ee2 
  src/master/master.cpp 390fbe9fe71981101ed2bd9a1f1b21b0e3727b7b 


Diff: https://reviews.apache.org/r/64618/diff/10/

Changes: https://reviews.apache.org/r/64618/diff/9-10/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-19 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
---

(Updated March 19, 2018, 11:13 a.m.)


Review request for mesos, Greg Mann and Zhitao Li.


Changes
---

Fixed whitespace.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.


Diffs (updated)
-

  src/master/http.cpp 1d7e159e1c3a0ef81e2b3dea67e4eca2dbf03ea2 
  src/master/master.hpp a54b8fab0d80806063045362079fc266afec7ac2 
  src/master/master.cpp aa35abc53bfc34e19d19a93328fb6552b64c05d7 


Diff: https://reviews.apache.org/r/64618/diff/9/

Changes: https://reviews.apache.org/r/64618/diff/8-9/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-19 Thread Gaston Kleiman 


> On March 19, 2018, 9:50 a.m., Zhitao Li wrote:
> > src/master/master.cpp
> > Lines 5934 (patched)
> > 
> >
> > whitespace line after multi-line log
> 
> Gaston Kleiman wrote:
> Do we have an official rule saying that there should be an empty line 
> after a multi-line log message?
> 
> I'm asking because I just looked at `master.cpp` and the style is not 
> consistent.
> 
> Here are multiple examples without an empty line:
> 
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L5763-L5792
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L570-L572
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L599-L602
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L1487-L1489
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L3167-L3186
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L3321-L
> 
> There are also multiple places where a mult-line log message is indeed 
> followed by an empty line. If we want to enforce a rule, then we should 
> probably do a sweep.
> 
> Zhitao Li wrote:
> http://mesos.apache.org/documentation/latest/c++-style-guide/#empty-lines 
> did not list log lines as exception, so we should either relax on the style 
> guide or still stick to it, I guess?
> 
> Totally agreed that we should have a sweep on this.

Did a sweep here: https://reviews.apache.org/r/66142/


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199426
---


On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated March 16, 2018, 12:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/8/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-19 Thread Gaston Kleiman 


> On March 19, 2018, 9:50 a.m., Zhitao Li wrote:
> > src/master/master.cpp
> > Lines 5969 (patched)
> > 
> >
> > whitespace after block
> > 
> > `const UUID& ...`

This one is moved at the end of the function, so it can't be a const ref.


> On March 19, 2018, 9:50 a.m., Zhitao Li wrote:
> > src/master/master.cpp
> > Lines 5972 (patched)
> > 
> >
> > How is this CHECK validated/ensured?

`Framework::operations` and `Framework::operationUUIDs` should be kept in-sync 
by `Framework::addOperation()` and `Framework::removeOperation()`.

I just noticed that `Framework::removeOperation()` doesn't remove the operation 
from `Framework::operationUUIDs`, which is a bug. I'll post a patch fixing this.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199426
---


On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated March 16, 2018, 12:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/8/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-19 Thread Zhitao Li 


> On March 19, 2018, 9:50 a.m., Zhitao Li wrote:
> > src/master/master.cpp
> > Lines 5934 (patched)
> > 
> >
> > whitespace line after multi-line log
> 
> Gaston Kleiman wrote:
> Do we have an official rule saying that there should be an empty line 
> after a multi-line log message?
> 
> I'm asking because I just looked at `master.cpp` and the style is not 
> consistent.
> 
> Here are multiple examples without an empty line:
> 
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L5763-L5792
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L570-L572
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L599-L602
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L1487-L1489
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L3167-L3186
> 
> https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L3321-L
> 
> There are also multiple places where a mult-line log message is indeed 
> followed by an empty line. If we want to enforce a rule, then we should 
> probably do a sweep.

http://mesos.apache.org/documentation/latest/c++-style-guide/#empty-lines did 
not list log lines as exception, so we should either relax on the style guide 
or still stick to it, I guess?

Totally agreed that we should have a sweep on this.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199426
---


On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated March 16, 2018, 12:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/8/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-19 Thread Gaston Kleiman 


> On March 19, 2018, 9:50 a.m., Zhitao Li wrote:
> > src/master/master.cpp
> > Lines 5934 (patched)
> > 
> >
> > whitespace line after multi-line log

Do we have an official rule saying that there should be an empty line after a 
multi-line log message?

I'm asking because I just looked at `master.cpp` and the style is not 
consistent.

Here are multiple examples without an empty line:

https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L5763-L5792
https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L570-L572
https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L599-L602
https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L1487-L1489
https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L3167-L3186
https://github.com/apache/mesos/blob/95bbe784da51b3a7eaeb9127e2541ea0b2af07b5/src/master/master.cpp#L3321-L

There are also multiple places where a mult-line log message is indeed followed 
by an empty line. If we want to enforce a rule, then we should probably do a 
sweep.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199426
---


On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated March 16, 2018, 12:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/8/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-19 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199426
---




src/master/master.cpp
Lines 5934 (patched)


whitespace line after multi-line log



src/master/master.cpp
Lines 5944 (patched)


whitespace line after multi-line log



src/master/master.cpp
Lines 5966 (patched)


whitespace line after multi-line log



src/master/master.cpp
Lines 5969 (patched)


whitespace after block

`const UUID& ...`



src/master/master.cpp
Lines 5972 (patched)


How is this CHECK validated/ensured?



src/master/master.cpp
Lines 5989 (patched)


whitespace line after multi-line log


- Zhitao Li


On March 16, 2018, 12:57 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated March 16, 2018, 12:57 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Zhitao Li.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/8/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-14 Thread Gaston Kleiman 


> On March 13, 2018, 4:19 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 5960 (patched)
> > 
> >
> > Can we move this to?
> > 
> > `std::move(statusUuid.toBytes())`
> > 
> > Looks like `toBytes()` returns a `std::string` and `set_value` has an 
> > overload for rvalue reference, so I think we can avoid a copy here if we 
> > move?
> 
> Gaston Kleiman wrote:
> Since `statusUuid.toBytes()` here is an rvalue, I think that 
> `set_value(std::string&&)` should be automatically used. I updated the patch 
> anyway for the sake of explicitness/readability.

Well.. I just noticed that adding `std::move` breaks the build, so I reverted 
that part. Here's the error that it triggers:

```
master/master.cpp:6006:44: error: moving a temporary object prevents copy 
elision [-Werror,-Wpessimizing-move]
  message.mutable_status_uuid()->set_value(std::move(statusUuid.toBytes()));
   ^
../../src/master/master.cpp:6006:44: note: remove std::move call here
  message.mutable_status_uuid()->set_value(std::move(statusUuid.toBytes()));
   ^~~
```


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199128
---


On March 14, 2018, 4:50 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated March 14, 2018, 4:50 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/8/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-14 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
---

(Updated March 14, 2018, 4:50 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Reverted last revision to fix the build.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.


Diffs (updated)
-

  src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
  src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
  src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 


Diff: https://reviews.apache.org/r/64618/diff/8/

Changes: https://reviews.apache.org/r/64618/diff/7-8/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-14 Thread Gaston Kleiman 


> On March 13, 2018, 4:19 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 5960 (patched)
> > 
> >
> > Can we move this to?
> > 
> > `std::move(statusUuid.toBytes())`
> > 
> > Looks like `toBytes()` returns a `std::string` and `set_value` has an 
> > overload for rvalue reference, so I think we can avoid a copy here if we 
> > move?

Since `statusUuid.toBytes()` here is an rvalue, I think that 
`set_value(std::string&&)` should be automatically used. I updated the patch 
anyway for the sake of explicitness/readability.


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199128
---


On March 14, 2018, 2:01 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated March 14, 2018, 2:01 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/7/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-14 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
---

(Updated March 14, 2018, 2:01 a.m.)


Review request for mesos and Greg Mann.


Changes
---

Addressed Greg's comment.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.


Diffs (updated)
-

  src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
  src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
  src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 


Diff: https://reviews.apache.org/r/64618/diff/7/

Changes: https://reviews.apache.org/r/64618/diff/6-7/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-03-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review199128
---


Fix it, then Ship it!





src/master/master.cpp
Lines 5960 (patched)


Can we move this to?

`std::move(statusUuid.toBytes())`

Looks like `toBytes()` returns a `std::string` and `set_value` has an 
overload for rvalue reference, so I think we can avoid a copy here if we move?


- Greg Mann


On Feb. 1, 2018, 11:52 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated Feb. 1, 2018, 11:52 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp cf03d8bf7df583c849a3b2a326d3772820181b0f 
>   src/master/master.hpp 8bf2c763dafdb7df55c46a56f2ff66f2a951d947 
>   src/master/master.cpp 223ebf29ac4dd1dea9080e4bef4b2d4d064d847f 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/6/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-02-01 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
---

(Updated Feb. 1, 2018, 3:52 p.m.)


Review request for mesos and Greg Mann.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.


Diffs (updated)
-

  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381 


Diff: https://reviews.apache.org/r/64618/diff/5/

Changes: https://reviews.apache.org/r/64618/diff/4-5/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-30 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196535
---



PASS: Mesos patch 64618 was successfully built and tested.

Reviews applied: `['65357', '65358', '65359', '65360', '65361', '65300', 
'65362', '65363', '64618']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618

- Mesos Reviewbot Windows


On Jan. 30, 2018, 9:22 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated Jan. 30, 2018, 9:22 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
>   src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/4/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-30 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
---

(Updated Jan. 30, 2018, 1:22 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Addressed feedback.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.


Diffs (updated)
-

  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 


Diff: https://reviews.apache.org/r/64618/diff/4/

Changes: https://reviews.apache.org/r/64618/diff/3-4/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-30 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196528
---




src/master/master.cpp
Lines 5892-5893 (patched)


Since the UUID is associated with the status, what do you think about the 
following wording:

"Processing ACKNOWLEDGE_OPERATION_STATUS call for status  of 
operation '' etc"



src/master/master.cpp
Lines 5898-5906 (patched)


Hmm... will the operation's list of statuses ever be empty when a valid ACK 
is received?

Also, do we need to update the latest status here? We already do it upon 
receipt of the status update, via `updateOperation()`.

I think the correct logic here might be something like:
```
if (protobuf::isTerminalState(
(*operation->statuses().rbegin()).state())) {
  removeOperation(operation);
}
```



src/master/master.cpp
Lines 5903 (patched)


Rather than just conditionally updating master state if the status UUID is 
correct, should we validate that the UUID in the call is correct, and drop the 
message if not? Seems strange to send an ACK containing an invalid status UUID 
to the agent.


- Greg Mann


On Jan. 26, 2018, 10:09 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated Jan. 26, 2018, 10:09 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
>   src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/3/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-26 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196377
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65357', '65358', '65359', '65360', '65361', '65300', 
'65362', '65363', '64618']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-stdout.log):

```

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (3439 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (3465 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (3568 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (3594 ms total)

[--] Global test environment tear-down
D:\DCOS\mesos\mesos\src\tests\environment.cpp(832): error: Failed
Tests completed with child processes remaining:
-+- 828 008E7AB9E47C
 |-+- 10360 008E7AB9E47C
 | --- 5824 008E7AB9E47C
 |-+- 11000 008E7AB9E47C
 | --- 9868 008E7AB9E47C
 -+- 11328 008E7AB9E47C
   --- 13696 008E7AB9E47C
[==] 849 tests from 85 test cases ran. (361732 ms total)
[  PASSED  ] 849 tests.
[  FAILED  ] 0 tests, listed below:

 0 FAILED TESTS

  YOU HAVE 213 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-stderr.log):

```
I0126 23:48:48.659042  4904 master.cpp:10292] Updating the state of task 
58247121-ef5f-4488-b94a-e20ee1ab773b of framework 
08d9d427-72f2-4b58-8d63-ee25da06a3dc- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0126 23:48:48.659042 10084 slI0126 23:48:47.767930 10840 exec.cpp:162] 
Version: 1.6.0
I0126 23:48:47.793915  6644 exec.cpp:236] Executor registered on agent 
08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0
I0126 23:48:47.796936  7844 executor.cpp:171] Received SUBSCRIBED event
I0126 23:48:47.801934  7844 executor.cpp:175] Subscribed executor on 
build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0126 23:48:47.801934  7844 executor.cpp:171] Received LAUNCH event
I0126 23:48:47.806936  7844 executor.cpp:638] Starting task 
58247121-ef5f-4488-b94a-e20ee1ab773b
I0126 23:48:47.882922  7844 executor.cpp:478] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0126 23:48:48.633067  7844 executor.cpp:651] Forked command at 9200
I0126 23:48:48.661043 13576 exec.cpp:445] Executor asked to shutdown
I0126 23:48:48.661043  7844 executor.cpp:171] Received SHUTDOWN event
I0126 23:48:48.661043  7844 executor.cpp:748] Shutting down
I0126 23:48:48.662041  7844 executor.cpp:863] Sending SIGTERM to process tree 
at pid 9ave.cpp:3479] Shutting down framework 
08d9d427-72f2-4b58-8d63-ee25da06a3dc-
I0126 23:48:48.659042 10084 slave.cpp:6178] Shutting down executor 
'58247121-ef5f-4488-b94a-e20ee1ab773b' of framework 
08d9d427-72f2-4b58-8d63-ee25da06a3dc- at executor(1)@10.3.1.11:65166
I0126 23:48:48.660043 10084 slave.cpp:931] Agent terminating
W0126 23:48:48.660043 10084 slave.cpp:3475] Ignoring shutdown framework 
08d9d427-72f2-4b58-8d63-ee25da06a3dc- because it is terminating
I0126 23:48:48.662041  4904 master.cpp:10391] Removing task 
58247121-ef5f-4488-b94a-e20ee1ab773b with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 08d9d427-72f2-4b58-8d63-ee25da06a3dc- on 
agent 08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 at slave(329)@10.3.1.11:65144 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0126 23:48:48.664042 10084 containerizer.cpp:2338] Destroying container 
ad7fdb26-819f-43f5-9b00-ee9c5daf6159 in RUNNING state
I0126 23:48:48.664042 10084 containerizer.cpp:2952] Transitioning the state of 
container ad7fdb26-819f-43f5-9b00-ee9c5daf6159 from RUNNING to DESTROYING
I0126 23:48:48.664042  4904 master.cpp:1307] Agent 
08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 at slave(329)@10.3.1.11:65144 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0126 23:48:48.664042  4904 master.cpp:3277] Disconnecting agent 
08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 at slave(329)@10.3.1.11:65144 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0126 23:48:48.664042  4904 master.cpp:3296] Deactivating agent 
08d9d427-72f2-4b58-8d63-ee25da06a3dc-S0 at slave(329)@10.3.1.11:65144 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0126 23:48:48.665071 10280

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-26 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196375
---



PASS: Mesos patch 64618 was successfully built and tested.

Reviews applied: `['65357', '65358', '65359', '65360', '65361', '65300', 
'65362', '65363', '64618']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618

- Mesos Reviewbot Windows


On Jan. 26, 2018, 10:09 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated Jan. 26, 2018, 10:09 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
>   src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/3/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-26 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/
---

(Updated Jan. 26, 2018, 2:09 p.m.)


Review request for mesos and Greg Mann.


Bugs: MESOS-8184
https://issues.apache.org/jira/browse/MESOS-8184


Repository: mesos


Description
---

Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.


Diffs (updated)
-

  src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 
  src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 


Diff: https://reviews.apache.org/r/64618/diff/3/

Changes: https://reviews.apache.org/r/64618/diff/2-3/


Testing
---

`make check` on GNU/Linux


Thanks,

Gaston Kleiman

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-25 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196301
---




src/master/master.cpp
Lines 5841-5850 (patched)


As discussed offline, let's leave the validation in the top-level scheduler 
API handler, and increment invalid metrics there.



src/master/master.cpp
Lines 5877-5895 (patched)


Per our offline discussion, consider not incrementing invalid metrics in 
these cases.


- Greg Mann


On Jan. 23, 2018, 10:17 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64618/
> ---
> 
> (Updated Jan. 23, 2018, 10:17 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
> 
> 
> Bugs: MESOS-8184
> https://issues.apache.org/jira/browse/MESOS-8184
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp b97ebae6ebfd8ae0f73e617d0c55e140b9c3fce7 
> 
> 
> Diff: https://reviews.apache.org/r/64618/diff/2/
> 
> 
> Testing
> ---
> 
> `make check` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

2018-01-23 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64618/#review196082
---



FAIL: Mesos tests failed to build.

Reviews applied: `['65300', '64618']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64618/logs/mesos-tests-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1799): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1814): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1818): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(1826): 
warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2363): 
warning C4996: 'strdup': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _strdup. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\server.c(2377): 
warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\seterror.c(189): 
warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(236):
 warning C4996: 'strcpy': This function or variable may be unsafe. Consider 
using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(241):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(253):
 warning C4996: 'strcat': This function or variable may be unsafe. Consider 
using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]
 [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
  
D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3\lib\windlopen.c(278):
 warning C4996: 'stricmp': The POSIX name for this item is deprecated. Instead, 
use the ISO C and C++ conformant name: _stricmp. See online help for details. 
[D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3\src\sasl2-2.1.27rc3-build\libsasl2.vcxproj]