Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- (Updated Feb. 22, 2018, 1:46 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review197942 --- Fix it, then Ship it! src/checks/checker_process.cpp Lines 577

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

> On Feb. 7, 2018, 1:07 p.m., Alexander Rukletsov wrote: > > Is this related to https://issues.apache.org/jira/browse/MESOS-4812 ? > > Akash Gupta wrote: > Yeah, I think it will fix that issue, but I have to confirm it. > > Alexander Rukletsov wrote: > Please do! And if it does fix it,

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- (Updated Feb. 21, 2018, 2:07 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review197820 --- Ship it! Ship It! - Joseph Wu On Feb. 16, 2018, 3:29 p.m., A

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- (Updated Feb. 16, 2018, 11:29 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review197340 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 8, 2018, 9:

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

> On Feb. 7, 2018, 1:07 p.m., Alexander Rukletsov wrote: > > Is this related to https://issues.apache.org/jira/browse/MESOS-4812 ? > > Akash Gupta wrote: > Yeah, I think it will fix that issue, but I have to confirm it. Please do! And if it does fix it, adjust the ticket reference according

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

> On Feb. 2, 2018, 1:43 p.m., Andrew Schwartzmeyer wrote: > > src/checks/checker_process.cpp > > Lines 535-537 (original), 543-547 (patched) > > > > > > Can you explain why this was changed a little more? Maybe an ex

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

> On Feb. 2, 2018, 9:43 p.m., Andrew Schwartzmeyer wrote: > > src/checks/checker_process.cpp > > Line 527 (original), 528-535 (patched) > > > > > > I'm not quite following this. Why do we always push `command.value()

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/ --- (Updated Feb. 8, 2018, 5:50 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

> On Feb. 7, 2018, 1:07 p.m., Alexander Rukletsov wrote: > > Is this related to https://issues.apache.org/jira/browse/MESOS-4812 ? Yeah, I think it will fix that issue, but I have to confirm it. - Akash --- This is an automatically gene

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review196985 --- Is this related to https://issues.apache.org/jira/browse/MESOS-481

Re: Review Request 65419: Fixed quoting issues in docker executor command checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65419/#review196734 --- src/checks/checker_process.cpp Lines 523-525 (original), 523-526