Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196746
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 65437`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65437

Relevant logs:

- 
[apply-review-65437-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65437/logs/apply-review-65437-stdout.log):

```
error: patch failed: docs/configuration/master-and-agent.md:95
error: docs/configuration/master-and-agent.md: patch does not apply
error: docs/fault-domains.md: already exists in index
error: patch failed: docs/home.md:26
error: docs/home.md: patch does not apply
```

- Mesos Reviewbot Windows


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8291
> https://issues.apache.org/jira/browse/MESOS-8291
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Vinod Kone 


> On Feb. 2, 2018, 10:11 p.m., Vinod Kone wrote:
> >

Fixed the issues before committing.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196740
---


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196740
---


Fix it, then Ship it!





docs/fault-domains.md
Line 74 (original), 79 (patched)


s/London/San Francisco/ ?



docs/fault-domains.md
Line 84 (original), 89 (patched)


s/companies/company's/


- Vinod Kone


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Vinod Kone 


> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote:
> > docs/fault-domains.md
> > Lines 63 (patched)
> > 
> >
> > s/The default/By default, the/
> 
> Benno Evers wrote:
> Are you sure about this? It would imply to me as a reader that this 
> behaviour can be changed.

I see. Yea, I'm not very sure then, what you have is probably less confusing.


> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote:
> > docs/fault-domains.md
> > Lines 80 (patched)
> > 
> >
> > Non-region-aware frameworks will only receive offers from the primary 
> > region (region containing masters). They won't get offers from other 
> > regions.
> 
> Benno Evers wrote:
> Does this actually imply that users should upgrade all their frameworks 
> to be partition-aware before configuring masters and agents with fault 
> domains? In this example, it would be quite devastating if two out of three 
> datacenters suddenly went completely unused.

s/primary/local/ in my first comment.

Do you mean REGION aware and not PARTION aware? So, yes, frameworks need to 
register with REGION_AWARE capability if they want remote region offers. The 
rationale was that most frameworks want their workloads in the local region and 
not magically go to remote regions with potentially higher latencies without an 
explicit opt-in. Note that region-aware frameworks should ideally expose the 
remote launching capability to their users too (e.g., via a configuration 
option in the app definition) before they start registering with REGION_AWARE 
capability.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196653
---


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Benno Evers 


> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote:
> > docs/fault-domains.md
> > Lines 63 (patched)
> > 
> >
> > s/The default/By default, the/

Are you sure about this? It would imply to me as a reader that this behaviour 
can be changed.


> On Feb. 1, 2018, 10:18 p.m., Vinod Kone wrote:
> > docs/fault-domains.md
> > Lines 80 (patched)
> > 
> >
> > Non-region-aware frameworks will only receive offers from the primary 
> > region (region containing masters). They won't get offers from other 
> > regions.

Does this actually imply that users should upgrade all their frameworks to be 
partition-aware before configuring masters and agents with fault domains? In 
this example, it would be quite devastating if two out of three datacenters 
suddenly went completely unused.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196653
---


On Feb. 2, 2018, 7:30 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Feb. 2, 2018, 7:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
>   docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/3/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-02-02 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/
---

(Updated Feb. 2, 2018, 7:30 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-8483
https://issues.apache.org/jira/browse/MESOS-8483


Repository: mesos


Description
---

Fault domains are a new feature in 1.5 which did not yet have
a corresponding description in the documentation.


Diffs (updated)
-

  docs/configuration/master-and-agent.md 
f247498ead43a16bbef5afb49d453073dd9ab6ef 
  docs/fault-domains.md PRE-CREATION 
  docs/home.md f5b65cc7895b10181e1b8483e3ee9da596d00fd6 


Diff: https://reviews.apache.org/r/65437/diff/3/

Changes: https://reviews.apache.org/r/65437/diff/2-3/


Testing
---

No.


Thanks,

Benno Evers

Re: Review Request 65437: Added documentation for fault domains.

2018-02-01 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196653
---




docs/configuration/master-and-agent.md
Lines 99 (patched)


Can you also call this out in the home page of documentation 
"http://mesos.apache.org/documentation/latest/";, perhaps in the 
"Administration" section?



docs/fault-domains.md
Lines 15-16 (patched)


How about

"A fault domain is a 2 level hierarchy of regions and zones."



docs/fault-domains.md
Lines 51 (patched)


s/slave/agent/



docs/fault-domains.md
Lines 56 (patched)


s/master,/master/



docs/fault-domains.md
Lines 61 (patched)


This should be:

* All masters must belong to the same "region" to avoid cross-region quorum 
writes. It is recommended to put them in different zones within that region for 
high availability.



docs/fault-domains.md
Lines 63 (patched)


s/The default/By default, the/



docs/fault-domains.md
Lines 71 (patched)


s/connected in a/connected through a/



docs/fault-domains.md
Lines 74-78 (patched)


In this example, "europe", "na" and "asia" would be regions. 

Also, I would not use cross continental regions as an example because we 
haven't tested the latency limits. Lets use "california", "atlanta" and "new 
york" as regions.

Zones would be racks within the data center.

One of these regions should contain all the masters, preferrably spread 
across zones. Putting them across racks gives them enough isolation for faults 
without sacrificing latency for quorum writes.



docs/fault-domains.md
Lines 80 (patched)


Non-region-aware frameworks will only receive offers from the primary 
region (region containing masters). They won't get offers from other regions.



docs/fault-domains.md
Lines 88 (patched)


s/to read the `domain`/to register with `REGION_AWARE` capability/



docs/fault-domains.md
Lines 90-99 (patched)


This example is a bit too complicated. I would say lets use an example of 
one on-prem data center which is extended by a cloud provider hosted remote 
region.


- Vinod Kone


On Jan. 31, 2018, 5:50 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Jan. 31, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/2/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-01-31 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196576
---



PASS: Mesos patch 65437 was successfully built and tested.

Reviews applied: `['65437']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65437

- Mesos Reviewbot Windows


On Jan. 31, 2018, 5:50 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Jan. 31, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/2/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 65437: Added documentation for fault domains.

2018-01-31 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65437/#review196571
---




docs/fault-domains.md
Lines 74 (patched)


This example actually differs from the description in the first section, 
but it seems to me that placing all masters in the same data center somewhat 
defeats the goal of achieving high availability, and  that most people would 
prefer running jobs in a remote data center rather than having the "main" 
datacenter overloaded. But maybe someone with more insight into the design of 
fault domains can comment on this?


- Benno Evers


On Jan. 31, 2018, 5:50 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65437/
> ---
> 
> (Updated Jan. 31, 2018, 5:50 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-8483
> https://issues.apache.org/jira/browse/MESOS-8483
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fault domains are a new feature in 1.5 which did not yet have
> a corresponding description in the documentation.
> 
> 
> Diffs
> -
> 
>   docs/configuration/master-and-agent.md 
> f247498ead43a16bbef5afb49d453073dd9ab6ef 
>   docs/fault-domains.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65437/diff/2/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>