Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-06-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/#review204920 --- Fix it, then Ship it!

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-06-13 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/ --- (Updated June 14, 2018, 12:06 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-06-13 Thread Chun-Hung Hsiao
> On April 20, 2018, 1:27 p.m., Benjamin Bannier wrote: > > First round of reviews. > > > > I am not a big fan on how reconcilations are modelled here. The counting > > seems to lead to an incomplete encapsulation of correct behavior. I'd much > > rather see standard `libprocess` actor

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-04-20 Thread Benjamin Bannier
> On April 20, 2018, 3:27 p.m., Benjamin Bannier wrote: > > First round of reviews. > > > > I am not a big fan on how reconcilations are modelled here. The counting > > seems to lead to an incomplete encapsulation of correct behavior. I'd much > > rather see standard `libprocess` actor

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-04-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/#review201629 --- First round of reviews. I am not a big fan on how reconcilations

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-04-11 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/ --- (Updated April 12, 2018, 3:36 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65975: Sequentialize reconciliations of storage pools in SLRP.

2018-03-08 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/ --- (Updated March 8, 2018, 11:41 p.m.) Review request for mesos, Benjamin