Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

2018-03-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/#review199462 --- Ship it! Ship It! - Joseph Wu On March 19, 2018, 12:13 p.m.,

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

2018-03-19 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/ --- (Updated March 19, 2018, 12:13 p.m.) Review request for mesos, Akash Gupta, Ben

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

2018-03-14 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/ --- (Updated March 14, 2018, 4:15 p.m.) Review request for mesos, Akash Gupta, Benj

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

2018-03-14 Thread Andrew Schwartzmeyer
> On March 14, 2018, 9:44 a.m., Benjamin Bannier wrote: > > Are we sure that this does not break other flags we forwarded to external > > projects? We seem to go from forwarding an open set of flags to only > > forwarding flags related to `C` and `CXX`. I am thinking e.g., about > > `CMAKE_GEN

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

2018-03-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/#review199181 --- Are we sure that this does not break other flags we forwarded to e

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

2018-03-12 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/#review199032 --- Ship it! I'm fine with these changes, but the description can b