Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review201664 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 19, 2018,

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/ --- (Updated April 20, 2018, 2:34 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 387-390 (patched) > > > > > > Do you know which targets actually require `ENABLE_GRPC` set as a > > pre-proc

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > src/tests/CMakeLists.txt > > Line 237 (original), 250-254 (patched) > > > > > > So `uri_disk_profile_adaptor` is, what, a module? that depends on (and

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote: > > src/tests/CMakeLists.txt > > Line 237 (original), 250-254 (patched) > > > > > > So `uri_disk_profile_adaptor` is, what, a module? that depends on (and

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 387-390 (patched) > > > > > > Do you know which targets actually require `ENABLE_GRPC` set as a > > pre-pro

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote: > > cmake/CompilationConfigure.cmake > > Lines 387-390 (patched) > > > > > > Do you know which targets actually require `ENABLE_GRPC` set as a > > pre-proc

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/ --- (Updated April 17, 2018, 3:20 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 66163: Built storage local resource provider with CMake.

> On April 12, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote: > > src/examples/CMakeLists.txt > > Lines 55-59 (patched) > > > > > > What about non-Linux but not Windows platforms, e.g. MacOS and FreeBSD? Saw in prior

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review201017 --- cmake/CompilationConfigure.cmake Lines 387-390 (patched)

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/ --- (Updated April 12, 2018, 5:15 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199747 --- src/examples/CMakeLists.txt Lines 55-58 (patched)

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199638 --- Bad patch! Reviews applied: [66163, 61118, 61096, 66162, 66161, 6

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199613 --- FAIL: Failed to apply the dependent review: 66094. Failed command

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/ --- (Updated March 20, 2018, 11:47 p.m.) Review request for mesos, Andrew Schwartzm

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199529 --- Bad patch! Reviews applied: [66163, 61118, 61096, 66162, 66161, 6

Re: Review Request 66163: Built storage local resource provider with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66163/#review199508 --- FAIL: Failed to apply the dependent review: 66094. Failed command