Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-08-01 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206773 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-08-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206757 --- Bad patch! Reviews applied: [67932, 67984, 67930, 67931] Failed

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206706 --- FAIL: Failed to apply the dependent review: 67931. Failed

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206693 --- Ship it! I'll clean up for Mesos

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206688 --- src/common/command_utils.cpp Line 186 (original), 186 (patched)

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Liangyu Zhao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/ --- (Updated July 31, 2018, 9:41 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Andrew Schwartzmeyer
> On July 30, 2018, 5:30 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Line 381 (original), 388 (patched) > > > > > > Did we change behavior here?

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-31 Thread Liangyu Zhao via Review Board
> On July 31, 2018, 12:30 a.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Line 381 (original), 388 (patched) > > > > > > Did we change behavior here?

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-30 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206625 --- src/common/command_utils.cpp Lines 186 (patched)

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-30 Thread Andrew Schwartzmeyer
> On July 16, 2018, 12:48 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67930', '67931', '67932']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-30 Thread Andrew Schwartzmeyer
> On July 18, 2018, 3:10 a.m., Mesos Reviewbot Windows wrote: > > Bad review! > > > > Error: > > Circular dependency detected for review 67931. Please fix the 'depends_on' > > field. Did this get fixed? - Andrew --- This is an

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206197 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-18 Thread Liangyu Zhao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/ --- (Updated July 18, 2018, 9:27 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206183 --- Bad review! Error: Circular dependency detected for review

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-17 Thread Liangyu Zhao via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/ --- (Updated July 17, 2018, 11:15 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-17 Thread Andrew Schwartzmeyer
> On July 16, 2018, 12:48 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67930', '67931', '67932']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67932: Use `wclayer` from `hcsshim` to extract file layers.

2018-07-16 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206119 --- FAIL: Some of the unit tests failed. Please check the relevant