Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorters performance.

2018-09-21 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68731/#review208909 --- Ship it! Ship It! - Meng Zhu On Sept. 21, 2018, 4:24 p.m.,

Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorters performance.

2018-09-21 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68731/#review208908 --- src/master/allocator/sorter/sorter.hpp Lines 177-180 (patched)

Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorters performance.

2018-09-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68731/ --- (Updated Sept. 21, 2018, 11:24 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorters performance.

2018-09-21 Thread Benjamin Mahler
> On Sept. 19, 2018, 9:27 p.m., Meng Zhu wrote: > > src/master/allocator/sorter/sorter.hpp > > Lines 163-164 (patched) > > > > > > Why we are enforcing alphabetically sorted? Seems to me unnecessary, > > especially

Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorters performance.

2018-09-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68731/#review208774 --- I am honestly surprised by the improvement this patch brings. Did

Re: Review Request 68731: Added a ScalarResourceQuantities type to improve sorters performance.

2018-09-18 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68731/ --- (Updated Sept. 18, 2018, 9:20 p.m.) Review request for mesos, Gastón Kleiman