Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

2018-09-21 Thread Benjamin Bannier
> On Sept. 19, 2018, 2:43 p.m., Jan Schlicht wrote: > > src/resource_provider/local.hpp > > Lines 47 (patched) > > > > > > This should be defined in `resource_provider/validation.hpp`, not here. > > Implementation

Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

2018-09-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68756/#review208841 --- Ship it! Ship It! - Benjamin Bannier On Sept. 19, 2018,

Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

2018-09-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68756/ --- (Updated Sept. 19, 2018, 6:36 p.m.) Review request for mesos, Benjamin

Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

2018-09-19 Thread Chun-Hung Hsiao
> On Sept. 19, 2018, 12:41 p.m., Benjamin Bannier wrote: > > src/resource_provider/local.cpp > > Lines 38-40 (patched) > > > > > > These trigger warnings with clang, > > ``` > >

Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

2018-09-19 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68756/#review208759 --- src/resource_provider/local.hpp Lines 47 (patched)

***UNCHECKED*** Re: Review Request 68756: Performed RP-specific validations when adding/updating RP configs.

2018-09-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68756/#review208753 --- src/resource_provider/daemon.cpp Lines 463-464 (original),